Title: [151382] releases/WebKitGTK/webkit-2.0/Source/WebKit2
Revision
151382
Author
[email protected]
Date
2013-06-10 05:23:04 -0700 (Mon, 10 Jun 2013)

Log Message

Merge r150758 - Reset all clients on WebPage close
https://bugs.webkit.org/show_bug.cgi?id=112334

Patch by Xan Lopez <[email protected]> on 2013-05-27
Reviewed by Anders Carlsson.

We do not reset the clients on WebPage::close(), so there's a
small chance that someone will try to access them after that. This
won't work and will generally cause runtime warnings, crashes or
other issues. Reset them all to null to prevent this situation.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::close):

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.0/Source/WebKit2/ChangeLog (151381 => 151382)


--- releases/WebKitGTK/webkit-2.0/Source/WebKit2/ChangeLog	2013-06-10 11:33:50 UTC (rev 151381)
+++ releases/WebKitGTK/webkit-2.0/Source/WebKit2/ChangeLog	2013-06-10 12:23:04 UTC (rev 151382)
@@ -1,3 +1,18 @@
+2013-05-27  Xan Lopez  <[email protected]>
+
+        Reset all clients on WebPage close
+        https://bugs.webkit.org/show_bug.cgi?id=112334
+
+        Reviewed by Anders Carlsson.
+
+        We do not reset the clients on WebPage::close(), so there's a
+        small chance that someone will try to access them after that. This
+        won't work and will generally cause runtime warnings, crashes or
+        other issues. Reset them all to null to prevent this situation.
+
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::WebPage::close):
+
 2013-05-27  Carlos Garcia Campos  <[email protected]>
 
         [GTK] WebKitWebView child widgets are not rendered with recent GTK+

Modified: releases/WebKitGTK/webkit-2.0/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (151381 => 151382)


--- releases/WebKitGTK/webkit-2.0/Source/WebKit2/WebProcess/WebPage/WebPage.cpp	2013-06-10 11:33:50 UTC (rev 151381)
+++ releases/WebKitGTK/webkit-2.0/Source/WebKit2/WebProcess/WebPage/WebPage.cpp	2013-06-10 12:23:04 UTC (rev 151382)
@@ -794,6 +794,20 @@
 
     m_sandboxExtensionTracker.invalidate();
 
+#if ENABLE(CONTEXT_MENUS)
+    m_contextMenuClient.initialize(0);
+#endif
+    m_editorClient.initialize(0);
+    m_formClient.initialize(0);
+    m_loaderClient.initialize(0);
+    m_policyClient.initialize(0);
+    m_resourceLoadClient.initialize(0);
+    m_uiClient.initialize(0);
+#if ENABLE(FULLSCREEN_API)
+    m_fullScreenClient.initialize(0);
+#endif
+    m_logDiagnosticMessageClient.initialize(0);
+
     m_underlayPage = nullptr;
     m_printContext = nullptr;
     m_mainFrame->coreFrame()->loader()->detachFromParent();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to