Title: [151423] trunk/Source
Revision
151423
Author
[email protected]
Date
2013-06-10 22:47:40 -0700 (Mon, 10 Jun 2013)

Log Message

[CoordinatedGraphics] Typos in custom shader support
https://bugs.webkit.org/show_bug.cgi?id=117413

Patch by Jae Hyun Park <[email protected]> on 2013-06-10
Reviewed by Noam Rosenthal.

Wrong keyframe is passed when assigning filterValue.

Source/WebCore:

* platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::setLayerAnimationsIfNeeded):

Source/WebKit2:

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::prepareCustomFilterProxiesIfNeeded):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (151422 => 151423)


--- trunk/Source/WebCore/ChangeLog	2013-06-11 05:40:28 UTC (rev 151422)
+++ trunk/Source/WebCore/ChangeLog	2013-06-11 05:47:40 UTC (rev 151423)
@@ -1,3 +1,15 @@
+2013-06-10  Jae Hyun Park  <[email protected]>
+
+        [CoordinatedGraphics] Typos in custom shader support
+        https://bugs.webkit.org/show_bug.cgi?id=117413
+
+        Reviewed by Noam Rosenthal.
+
+        Wrong keyframe is passed when assigning filterValue.
+
+        * platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
+        (WebCore::CoordinatedGraphicsScene::setLayerAnimationsIfNeeded):
+
 2013-06-10  Ryosuke Niwa  <[email protected]>
 
         text-transform: capitalize shouldn't upconvert

Modified: trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp (151422 => 151423)


--- trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp	2013-06-11 05:40:28 UTC (rev 151422)
+++ trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp	2013-06-11 05:47:40 UTC (rev 151423)
@@ -727,7 +727,7 @@
         if (keyframes.property() != AnimatedPropertyWebkitFilter)
             continue;
         for (size_t j = 0; j < keyframes.size(); ++j) {
-            const FilterAnimationValue& filterValue = static_cast<const FilterAnimationValue&>(keyframes.at(i));
+            const FilterAnimationValue& filterValue = static_cast<const FilterAnimationValue&>(keyframes.at(j));
             injectCachedCustomFilterPrograms(filterValue.value());
         }
     }

Modified: trunk/Source/WebKit2/ChangeLog (151422 => 151423)


--- trunk/Source/WebKit2/ChangeLog	2013-06-11 05:40:28 UTC (rev 151422)
+++ trunk/Source/WebKit2/ChangeLog	2013-06-11 05:47:40 UTC (rev 151423)
@@ -1,3 +1,15 @@
+2013-06-10  Jae Hyun Park  <[email protected]>
+
+        [CoordinatedGraphics] Typos in custom shader support
+        https://bugs.webkit.org/show_bug.cgi?id=117413
+
+        Reviewed by Noam Rosenthal.
+
+        Wrong keyframe is passed when assigning filterValue.
+
+        * WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
+        (WebKit::CoordinatedLayerTreeHost::prepareCustomFilterProxiesIfNeeded):
+
 2013-06-10  Seokju Kwon  <[email protected]>
 
         [Qt][GTK] Build fix after r151403

Modified: trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp (151422 => 151423)


--- trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp	2013-06-11 05:40:28 UTC (rev 151422)
+++ trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp	2013-06-11 05:47:40 UTC (rev 151423)
@@ -330,7 +330,7 @@
             if (keyframes.property() != AnimatedPropertyWebkitFilter)
                 continue;
             for (size_t j = 0; j < keyframes.size(); ++j) {
-                const FilterAnimationValue& filterValue = static_cast<const FilterAnimationValue&>(keyframes.at(i));
+                const FilterAnimationValue& filterValue = static_cast<const FilterAnimationValue&>(keyframes.at(j));
                 checkCustomFilterProgramProxies(filterValue.value());
             }
         }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to