Title: [151433] trunk/Source/WebKit2
Revision
151433
Author
[email protected]
Date
2013-06-11 05:12:31 -0700 (Tue, 11 Jun 2013)

Log Message

[EFL][WK2] Add fallback for EWK2UnitTestBase if opengl is not available.
https://bugs.webkit.org/show_bug.cgi?id=117504

Patch by Changhyup Jwa <[email protected]> on 2013-06-11
Reviewed by Christophe Dumez.

There're many fails on efl webkit2 unit test if opengl is not available.
So, add fallback to non-opengl evas engine.

* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::EWK2UnitTestBase::SetUp):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (151432 => 151433)


--- trunk/Source/WebKit2/ChangeLog	2013-06-11 10:47:43 UTC (rev 151432)
+++ trunk/Source/WebKit2/ChangeLog	2013-06-11 12:12:31 UTC (rev 151433)
@@ -1,3 +1,16 @@
+2013-06-11  Changhyup Jwa  <[email protected]>
+
+        [EFL][WK2] Add fallback for EWK2UnitTestBase if opengl is not available.
+        https://bugs.webkit.org/show_bug.cgi?id=117504
+
+        Reviewed by Christophe Dumez.
+
+        There're many fails on efl webkit2 unit test if opengl is not available.
+        So, add fallback to non-opengl evas engine.
+
+        * UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
+        (EWK2UnitTest::EWK2UnitTestBase::SetUp):
+
 2013-06-11  Csaba Osztrogonác  <[email protected]>
 
         Make WTR use its own temporary directory for application cache

Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp (151432 => 151433)


--- trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp	2013-06-11 10:47:43 UTC (rev 151432)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp	2013-06-11 12:12:31 UTC (rev 151433)
@@ -50,9 +50,10 @@
 #if defined(WTF_USE_ACCELERATED_COMPOSITING) && defined(HAVE_ECORE_X)
     const char* engine = "opengl_x11";
     m_ecoreEvas = ecore_evas_new(engine, 0, 0, width, height, 0);
-#else
+    // Graceful fallback to software rendering if evas_gl engine is not available.
+    if (!m_ecoreEvas)
+#endif
     m_ecoreEvas = ecore_evas_new(0, 0, 0, width, height, 0);
-#endif
 
     ecore_evas_show(m_ecoreEvas);
     Evas* evas = ecore_evas_get(m_ecoreEvas);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to