Title: [151492] trunk
Revision
151492
Author
[email protected]
Date
2013-06-12 01:51:48 -0700 (Wed, 12 Jun 2013)

Log Message

[GTK] Remove the WebCoreLayer(Gtk2).a archives before regenerating them
https://bugs.webkit.org/show_bug.cgi?id=116723

Reviewed by Carlos Garcia Campos.

Source/WebKit2: 

* GNUmakefile.am: When generating the WebCoreLayerGtk2.a archive from all the dependency archives, remove the
current archive (if any). Updating an existent archive in an incremental build is not bulletproof and can lead
to corrupt archives and subsequent build failures. On the other hand, the archive generation is not expensive
and produces a working archive without problems even on incremental builds.

Tools: 

* TestWebKitAPI/GNUmakefile.am: When generating the WebCoreLayer.a archive from all the dependency archives,
remove the current archive (if any). Updating an existent archive in an incremental build is not bulletproof
and can lead to corrupt archives and subsequent build failures. On the other hand, the archive generation is
not expensive and produces a working archive without problems even on incremental builds.

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (151491 => 151492)


--- trunk/Source/WebKit2/ChangeLog	2013-06-12 08:45:44 UTC (rev 151491)
+++ trunk/Source/WebKit2/ChangeLog	2013-06-12 08:51:48 UTC (rev 151492)
@@ -1,5 +1,17 @@
 2013-06-12  Zan Dobersek  <[email protected]>
 
+        [GTK] Remove the WebCoreLayer(Gtk2).a archives before regenerating them
+        https://bugs.webkit.org/show_bug.cgi?id=116723
+
+        Reviewed by Carlos Garcia Campos.
+
+        * GNUmakefile.am: When generating the WebCoreLayerGtk2.a archive from all the dependency archives, remove the
+        current archive (if any). Updating an existent archive in an incremental build is not bulletproof and can lead
+        to corrupt archives and subsequent build failures. On the other hand, the archive generation is not expensive
+        and produces a working archive without problems even on incremental builds.
+
+2013-06-12  Zan Dobersek  <[email protected]>
+
         Unreviewed GTK build fix.
 
         * GNUmakefile.list.am: Adding missing build targets to the plugin process after r151480.

Modified: trunk/Source/WebKit2/GNUmakefile.am (151491 => 151492)


--- trunk/Source/WebKit2/GNUmakefile.am	2013-06-12 08:45:44 UTC (rev 151491)
+++ trunk/Source/WebKit2/GNUmakefile.am	2013-06-12 08:51:48 UTC (rev 151492)
@@ -585,6 +585,7 @@
 
 WebCoreLayerGtk2.a: $(webcore_layer_gtk2_deps)
 	$(AM_V_GEN)
+	$(AM_V_at)$(shell rm -f $@)
 	$(AM_V_at)$(foreach archive, $(webcore_layer_gtk2_archives), $(shell ar t $(archive) | xargs -n50 ar cruT $@))
 
 DISTCLEANFILES += \

Modified: trunk/Tools/ChangeLog (151491 => 151492)


--- trunk/Tools/ChangeLog	2013-06-12 08:45:44 UTC (rev 151491)
+++ trunk/Tools/ChangeLog	2013-06-12 08:51:48 UTC (rev 151492)
@@ -1,3 +1,15 @@
+2013-06-12  Zan Dobersek  <[email protected]>
+
+        [GTK] Remove the WebCoreLayer(Gtk2).a archives before regenerating them
+        https://bugs.webkit.org/show_bug.cgi?id=116723
+
+        Reviewed by Carlos Garcia Campos.
+
+        * TestWebKitAPI/GNUmakefile.am: When generating the WebCoreLayer.a archive from all the dependency archives,
+        remove the current archive (if any). Updating an existent archive in an incremental build is not bulletproof
+        and can lead to corrupt archives and subsequent build failures. On the other hand, the archive generation is
+        not expensive and produces a working archive without problems even on incremental builds.
+
 2013-06-11  Santosh Mahto  <[email protected]>
 
         [EFL] Window resize should close the popupmenu

Modified: trunk/Tools/TestWebKitAPI/GNUmakefile.am (151491 => 151492)


--- trunk/Tools/TestWebKitAPI/GNUmakefile.am	2013-06-12 08:45:44 UTC (rev 151491)
+++ trunk/Tools/TestWebKitAPI/GNUmakefile.am	2013-06-12 08:51:48 UTC (rev 151492)
@@ -121,6 +121,7 @@
 
 WebCoreLayer.a: $(webcore_layer_deps)
 	$(AM_V_GEN)
+	$(AM_V_at)$(shell rm -f $@)
 	$(AM_V_at)$(foreach archive, $(webcore_layer_archives), $(shell ar t $(archive) | xargs -n50 ar cruT $@))
 
 DISTCLEANFILES += \
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to