Diff
Modified: trunk/Source/WebCore/ChangeLog (151494 => 151495)
--- trunk/Source/WebCore/ChangeLog 2013-06-12 11:44:33 UTC (rev 151494)
+++ trunk/Source/WebCore/ChangeLog 2013-06-12 12:25:41 UTC (rev 151495)
@@ -1,3 +1,43 @@
+2013-06-12 Christophe Dumez <[email protected]>
+
+ Rename [CallWith] to [ConstructorCallWith] for IDL interfaces
+ https://bugs.webkit.org/show_bug.cgi?id=117531
+
+ Reviewed by Kentaro Hara.
+
+ Rename [CallWith] to [ConstructorCallWith] for IDL interfaces as the
+ meaning is slightly different when [CallWith] is used for IDL operations
+ or attributes. This improves IDL readability a bit and makes it more
+ directly understandable.
+
+ Also removed [ConstructorCallWith] statements from interfaces with custom
+ constructors or no constructor, as this does not have any effect.
+
+ No new tests, no behavior change.
+
+ * Modules/filesystem/FileWriter.idl:
+ * Modules/mediasource/MediaSource.idl:
+ * Modules/mediasource/SourceBufferList.idl:
+ * Modules/mediastream/MediaStream.idl:
+ * Modules/mediastream/RTCPeerConnection.idl:
+ * Modules/notifications/Notification.idl:
+ * Modules/speech/SpeechRecognition.idl:
+ * Modules/speech/SpeechSynthesisUtterance.idl:
+ * Modules/webaudio/OfflineAudioContext.idl:
+ * Modules/websockets/WebSocket.idl:
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (GenerateConstructorDefinition):
+ * bindings/scripts/IDLAttributes.txt:
+ * bindings/scripts/test/TestInterface.idl:
+ * dom/MessageChannel.idl:
+ * fileapi/FileReader.idl:
+ * html/MediaController.idl:
+ * html/track/TextTrackCue.idl:
+ * page/EventSource.idl:
+ * workers/SharedWorker.idl:
+ * workers/Worker.idl:
+ * xml/XMLHttpRequest.idl:
+
2013-06-12 Allan Sandfeld Jensen <[email protected]>
[Qt] Set windows key-code for multimedia keys
Modified: trunk/Source/WebCore/Modules/filesystem/FileWriter.idl (151494 => 151495)
--- trunk/Source/WebCore/Modules/filesystem/FileWriter.idl 2013-06-12 11:44:33 UTC (rev 151494)
+++ trunk/Source/WebCore/Modules/filesystem/FileWriter.idl 2013-06-12 12:25:41 UTC (rev 151495)
@@ -33,7 +33,6 @@
NoInterfaceObject,
Conditional=FILE_SYSTEM,
ActiveDOMObject,
- CallWith=ScriptExecutionContext,
EventTarget,
JSNoStaticTables
] interface FileWriter {
Modified: trunk/Source/WebCore/Modules/mediasource/MediaSource.idl (151494 => 151495)
--- trunk/Source/WebCore/Modules/mediasource/MediaSource.idl 2013-06-12 11:44:33 UTC (rev 151494)
+++ trunk/Source/WebCore/Modules/mediasource/MediaSource.idl 2013-06-12 12:25:41 UTC (rev 151495)
@@ -33,7 +33,7 @@
ActiveDOMObject,
EventTarget,
Constructor,
- CallWith=ScriptExecutionContext,
+ ConstructorCallWith=ScriptExecutionContext,
InterfaceName=WebKitMediaSource
] interface MediaSource {
// All the source buffers created by this object.
Modified: trunk/Source/WebCore/Modules/mediasource/SourceBufferList.idl (151494 => 151495)
--- trunk/Source/WebCore/Modules/mediasource/SourceBufferList.idl 2013-06-12 11:44:33 UTC (rev 151494)
+++ trunk/Source/WebCore/Modules/mediasource/SourceBufferList.idl 2013-06-12 12:25:41 UTC (rev 151495)
@@ -32,7 +32,6 @@
Conditional=MEDIA_SOURCE,
IndexedGetter,
EventTarget,
- CallWith=ScriptExecutionContext,
InterfaceName=WebKitSourceBufferList
] interface SourceBufferList {
readonly attribute unsigned long length;
Modified: trunk/Source/WebCore/Modules/mediastream/MediaStream.idl (151494 => 151495)
--- trunk/Source/WebCore/Modules/mediastream/MediaStream.idl 2013-06-12 11:44:33 UTC (rev 151494)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStream.idl 2013-06-12 12:25:41 UTC (rev 151495)
@@ -28,7 +28,7 @@
Constructor,
Constructor(MediaStream stream),
Constructor(MediaStreamTrack[] tracks),
- CallWith=ScriptExecutionContext,
+ ConstructorCallWith=ScriptExecutionContext,
SkipVTableValidation,
InterfaceName=webkitMediaStream
] interface MediaStream {
Modified: trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.idl (151494 => 151495)
--- trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.idl 2013-06-12 11:44:33 UTC (rev 151494)
+++ trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.idl 2013-06-12 12:25:41 UTC (rev 151495)
@@ -33,7 +33,7 @@
ActiveDOMObject,
Constructor(Dictionary rtcIceServers, optional Dictionary mediaConstraints),
ConstructorRaisesException,
- CallWith=ScriptExecutionContext,
+ ConstructorCallWith=ScriptExecutionContext,
EventTarget,
InterfaceName=webkitRTCPeerConnection
] interface RTCPeerConnection {
Modified: trunk/Source/WebCore/Modules/notifications/Notification.idl (151494 => 151495)
--- trunk/Source/WebCore/Modules/notifications/Notification.idl 2013-06-12 11:44:33 UTC (rev 151494)
+++ trunk/Source/WebCore/Modules/notifications/Notification.idl 2013-06-12 12:25:41 UTC (rev 151495)
@@ -35,7 +35,7 @@
EventTarget,
#if defined(ENABLE_NOTIFICATIONS) && ENABLE_NOTIFICATIONS
Constructor(DOMString title, [Default=Undefined] optional Dictionary options),
- CallWith=ScriptExecutionContext,
+ ConstructorCallWith=ScriptExecutionContext,
#else
#endif
] interface Notification {
Modified: trunk/Source/WebCore/Modules/speech/SpeechRecognition.idl (151494 => 151495)
--- trunk/Source/WebCore/Modules/speech/SpeechRecognition.idl 2013-06-12 11:44:33 UTC (rev 151494)
+++ trunk/Source/WebCore/Modules/speech/SpeechRecognition.idl 2013-06-12 12:25:41 UTC (rev 151495)
@@ -27,7 +27,7 @@
Conditional=SCRIPTED_SPEECH,
ActiveDOMObject,
Constructor,
- CallWith=ScriptExecutionContext,
+ ConstructorCallWith=ScriptExecutionContext,
EventTarget,
InterfaceName=webkitSpeechRecognition
] interface SpeechRecognition {
Modified: trunk/Source/WebCore/Modules/speech/SpeechSynthesisUtterance.idl (151494 => 151495)
--- trunk/Source/WebCore/Modules/speech/SpeechSynthesisUtterance.idl 2013-06-12 11:44:33 UTC (rev 151494)
+++ trunk/Source/WebCore/Modules/speech/SpeechSynthesisUtterance.idl 2013-06-12 12:25:41 UTC (rev 151495)
@@ -26,7 +26,7 @@
[
Conditional=SPEECH_SYNTHESIS,
EventTarget,
- CallWith=ScriptExecutionContext,
+ ConstructorCallWith=ScriptExecutionContext,
Constructor([Default=NullString] optional DOMString text)
] interface SpeechSynthesisUtterance {
attribute DOMString text;
Modified: trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.idl (151494 => 151495)
--- trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.idl 2013-06-12 11:44:33 UTC (rev 151494)
+++ trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.idl 2013-06-12 12:25:41 UTC (rev 151495)
@@ -28,7 +28,7 @@
JSGenerateToJSObject,
Constructor(unsigned long numberOfChannels, unsigned long numberOfFrames, float sampleRate),
ConstructorRaisesException,
- CallWith=ScriptExecutionContext,
+ ConstructorCallWith=ScriptExecutionContext,
InterfaceName=webkitOfflineAudioContext
] interface OfflineAudioContext : AudioContext {
Modified: trunk/Source/WebCore/Modules/websockets/WebSocket.idl (151494 => 151495)
--- trunk/Source/WebCore/Modules/websockets/WebSocket.idl 2013-06-12 11:44:33 UTC (rev 151494)
+++ trunk/Source/WebCore/Modules/websockets/WebSocket.idl 2013-06-12 12:25:41 UTC (rev 151495)
@@ -38,7 +38,7 @@
Constructor(DOMString url, sequence<DOMString> protocols),
Constructor(DOMString url, DOMString protocol),
ConstructorRaisesException,
- CallWith=ScriptExecutionContext,
+ ConstructorCallWith=ScriptExecutionContext,
EventTarget,
JSNoStaticTables,
] interface WebSocket {
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (151494 => 151495)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2013-06-12 11:44:33 UTC (rev 151494)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2013-06-12 12:25:41 UTC (rev 151495)
@@ -4175,7 +4175,7 @@
my $numParameters = @{$function->parameters};
my ($dummy, $paramIndex) = GenerateParametersCheck($outputArray, $function, $interface, $numParameters, $interfaceName, "constructorCallback", undef, undef, undef);
- if ($codeGenerator->ExtendedAttributeContains($interface->extendedAttributes->{"CallWith"}, "ScriptExecutionContext")) {
+ if ($codeGenerator->ExtendedAttributeContains($interface->extendedAttributes->{"ConstructorCallWith"}, "ScriptExecutionContext")) {
push(@constructorArgList, "context");
push(@$outputArray, " ScriptExecutionContext* context = castedThis->scriptExecutionContext();\n");
push(@$outputArray, " if (!context)\n");
Modified: trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt (151494 => 151495)
--- trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt 2013-06-12 11:44:33 UTC (rev 151494)
+++ trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt 2013-06-12 12:25:41 UTC (rev 151495)
@@ -27,6 +27,7 @@
Clamp
Conditional=*
Constructor
+ConstructorCallWith=ScriptExecutionContext
ConstructorConditional=*
ConstructorRaisesException
ConstructorTemplate=Event|TypedArray
Modified: trunk/Source/WebCore/bindings/scripts/test/TestInterface.idl (151494 => 151495)
--- trunk/Source/WebCore/bindings/scripts/test/TestInterface.idl 2013-06-12 11:44:33 UTC (rev 151494)
+++ trunk/Source/WebCore/bindings/scripts/test/TestInterface.idl 2013-06-12 12:25:41 UTC (rev 151495)
@@ -32,7 +32,7 @@
ActiveDOMObject,
CustomNamedSetter,
Conditional=Condition1|Condition2,
- CallWith=ScriptExecutionContext,
+ ConstructorCallWith=ScriptExecutionContext,
Constructor(DOMString str1, [Default=Undefined] optional DOMString str2),
ConstructorRaisesException,
ConstructorConditional=TEST_INTERFACE,
Modified: trunk/Source/WebCore/dom/MessageChannel.idl (151494 => 151495)
--- trunk/Source/WebCore/dom/MessageChannel.idl 2013-06-12 11:44:33 UTC (rev 151494)
+++ trunk/Source/WebCore/dom/MessageChannel.idl 2013-06-12 12:25:41 UTC (rev 151495)
@@ -28,7 +28,7 @@
GlobalContext=WindowAndWorker,
Conditional=CHANNEL_MESSAGING,
Constructor,
- CallWith=ScriptExecutionContext,
+ ConstructorCallWith=ScriptExecutionContext,
JSCustomMarkFunction,
JSNoStaticTables,
ImplementationLacksVTable
Modified: trunk/Source/WebCore/fileapi/FileReader.idl (151494 => 151495)
--- trunk/Source/WebCore/fileapi/FileReader.idl 2013-06-12 11:44:33 UTC (rev 151494)
+++ trunk/Source/WebCore/fileapi/FileReader.idl 2013-06-12 12:25:41 UTC (rev 151495)
@@ -34,7 +34,7 @@
Conditional=BLOB,
ActiveDOMObject,
Constructor,
- CallWith=ScriptExecutionContext,
+ ConstructorCallWith=ScriptExecutionContext,
EventTarget,
JSNoStaticTables
] interface FileReader {
Modified: trunk/Source/WebCore/html/MediaController.idl (151494 => 151495)
--- trunk/Source/WebCore/html/MediaController.idl 2013-06-12 11:44:33 UTC (rev 151494)
+++ trunk/Source/WebCore/html/MediaController.idl 2013-06-12 12:25:41 UTC (rev 151495)
@@ -26,7 +26,7 @@
[
Conditional=VIDEO,
Constructor,
- CallWith=ScriptExecutionContext,
+ ConstructorCallWith=ScriptExecutionContext,
JSGenerateToJSObject,
EventTarget
] interface MediaController {
Modified: trunk/Source/WebCore/html/track/TextTrackCue.idl (151494 => 151495)
--- trunk/Source/WebCore/html/track/TextTrackCue.idl 2013-06-12 11:44:33 UTC (rev 151494)
+++ trunk/Source/WebCore/html/track/TextTrackCue.idl 2013-06-12 12:25:41 UTC (rev 151495)
@@ -27,7 +27,7 @@
Conditional=VIDEO_TRACK,
JSGenerateToNativeObject,
Constructor(double startTime, double endTime, DOMString text),
- CallWith=ScriptExecutionContext,
+ ConstructorCallWith=ScriptExecutionContext,
EventTarget,
JSCustomMarkFunction,
CustomIsReachable,
Modified: trunk/Source/WebCore/page/EventSource.idl (151494 => 151495)
--- trunk/Source/WebCore/page/EventSource.idl 2013-06-12 11:44:33 UTC (rev 151494)
+++ trunk/Source/WebCore/page/EventSource.idl 2013-06-12 12:25:41 UTC (rev 151495)
@@ -33,7 +33,7 @@
GlobalContext=WindowAndWorker,
ActiveDOMObject,
Constructor(DOMString url, optional Dictionary eventSourceInit),
- CallWith=ScriptExecutionContext,
+ ConstructorCallWith=ScriptExecutionContext,
ConstructorRaisesException,
EventTarget,
JSNoStaticTables
Modified: trunk/Source/WebCore/workers/SharedWorker.idl (151494 => 151495)
--- trunk/Source/WebCore/workers/SharedWorker.idl 2013-06-12 11:44:33 UTC (rev 151494)
+++ trunk/Source/WebCore/workers/SharedWorker.idl 2013-06-12 12:25:41 UTC (rev 151495)
@@ -33,8 +33,6 @@
EnabledAtRuntime,
Conditional=SHARED_WORKERS,
CustomConstructor(DOMString scriptURL, [Default=NullString] optional DOMString name),
- CallWith=ScriptExecutionContext,
- ConstructorRaisesException,
JSCustomMarkFunction,
JSGenerateToNativeObject,
JSGenerateToJSObject
Modified: trunk/Source/WebCore/workers/Worker.idl (151494 => 151495)
--- trunk/Source/WebCore/workers/Worker.idl 2013-06-12 11:44:33 UTC (rev 151494)
+++ trunk/Source/WebCore/workers/Worker.idl 2013-06-12 12:25:41 UTC (rev 151495)
@@ -28,8 +28,6 @@
[
Conditional=WORKERS,
CustomConstructor(DOMString scriptUrl),
- CallWith=ScriptExecutionContext,
- ConstructorRaisesException,
JSGenerateToNativeObject,
JSGenerateToJSObject
] interface Worker : AbstractWorker {
Modified: trunk/Source/WebCore/xml/XMLHttpRequest.idl (151494 => 151495)
--- trunk/Source/WebCore/xml/XMLHttpRequest.idl 2013-06-12 11:44:33 UTC (rev 151494)
+++ trunk/Source/WebCore/xml/XMLHttpRequest.idl 2013-06-12 12:25:41 UTC (rev 151495)
@@ -40,7 +40,7 @@
GlobalContext=WindowAndWorker,
ActiveDOMObject,
Constructor,
- CallWith=ScriptExecutionContext,
+ ConstructorCallWith=ScriptExecutionContext,
JSCustomMarkFunction,
EventTarget,
JSNoStaticTables
