Title: [151520] trunk/Source
- Revision
- 151520
- Author
- [email protected]
- Date
- 2013-06-12 12:58:29 -0700 (Wed, 12 Jun 2013)
Log Message
"Open Video in New Window" doesn't make sense in fullscreen
https://bugs.webkit.org/show_bug.cgi?id=117556
Patch by Ruth Fong <[email protected]> on 2013-06-12
Reviewed by Beth Dakin.
Source/WebCore:
No new tests needed.
* WebCore.exp.in: Added WebKit2 hook for mediaIsInFullscreen() method.
Source/WebKit2:
Adds method mediaIsInFullscreen() that checks if a media element is in
fullscreen mode, which is needed to decide when to display the
"Open Video in New Window" context menu item.
* WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:
(WKBundleHitTestResultMediaIsInFullscreen): Added.
Hooks into new InjectedBundleHitTestResult::mediaIsInFullscreen() method.
* WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h:
* WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:
(WebKit::InjectedBundleHitTestResult::mediaIsInFullscreen): Added.
Checks if media element is in fullscreen.
* WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (151519 => 151520)
--- trunk/Source/WebCore/ChangeLog 2013-06-12 19:52:04 UTC (rev 151519)
+++ trunk/Source/WebCore/ChangeLog 2013-06-12 19:58:29 UTC (rev 151520)
@@ -1,3 +1,14 @@
+2013-06-12 Ruth Fong <[email protected]>
+
+ "Open Video in New Window" doesn't make sense in fullscreen
+ https://bugs.webkit.org/show_bug.cgi?id=117556
+
+ Reviewed by Beth Dakin.
+
+ No new tests needed.
+
+ * WebCore.exp.in: Added WebKit2 hook for mediaIsInFullscreen() method.
+
2013-06-12 Ryosuke Niwa <[email protected]>
Accessibility code assumes an area element's parent is a map element
Modified: trunk/Source/WebCore/WebCore.exp.in (151519 => 151520)
--- trunk/Source/WebCore/WebCore.exp.in 2013-06-12 19:52:04 UTC (rev 151519)
+++ trunk/Source/WebCore/WebCore.exp.in 2013-06-12 19:58:29 UTC (rev 151520)
@@ -1374,6 +1374,7 @@
__ZNK7WebCore13HitTestResult15spellingToolTipERNS_13TextDirectionE
__ZNK7WebCore13HitTestResult16absoluteImageURLEv
__ZNK7WebCore13HitTestResult16absoluteMediaURLEv
+__ZNK7WebCore13HitTestResult19mediaIsInFullscreenEv
__ZNK7WebCore13HitTestResult16altDisplayStringEv
__ZNK7WebCore13HitTestResult17isContentEditableEv
__ZNK7WebCore13HitTestResult18titleDisplayStringEv
Modified: trunk/Source/WebKit2/ChangeLog (151519 => 151520)
--- trunk/Source/WebKit2/ChangeLog 2013-06-12 19:52:04 UTC (rev 151519)
+++ trunk/Source/WebKit2/ChangeLog 2013-06-12 19:58:29 UTC (rev 151520)
@@ -1,5 +1,25 @@
2013-06-12 Ruth Fong <[email protected]>
+ "Open Video in New Window" doesn't make sense in fullscreen
+ https://bugs.webkit.org/show_bug.cgi?id=117556
+
+ Reviewed by Beth Dakin.
+
+ Adds method mediaIsInFullscreen() that checks if a media element is in
+ fullscreen mode, which is needed to decide when to display the
+ "Open Video in New Window" context menu item.
+
+ * WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:
+ (WKBundleHitTestResultMediaIsInFullscreen): Added.
+ Hooks into new InjectedBundleHitTestResult::mediaIsInFullscreen() method.
+ * WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h:
+ * WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:
+ (WebKit::InjectedBundleHitTestResult::mediaIsInFullscreen): Added.
+ Checks if media element is in fullscreen.
+ * WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:
+
+2013-06-12 Ruth Fong <[email protected]>
+
Allow for toggling fullscreen on <video> elements
https://bugs.webkit.org/show_bug.cgi?id=117220
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp (151519 => 151520)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp 2013-06-12 19:52:04 UTC (rev 151519)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp 2013-06-12 19:58:29 UTC (rev 151520)
@@ -74,6 +74,11 @@
return toCopiedURLAPI(toImpl(hitTestResultRef)->absoluteMediaURL());
}
+bool WKBundleHitTestResultMediaIsInFullscreen(WKBundleHitTestResultRef hitTestResultRef)
+{
+ return toImpl(hitTestResultRef)->mediaIsInFullscreen();
+}
+
WKRect WKBundleHitTestResultGetImageRect(WKBundleHitTestResultRef hitTestResultRef)
{
return toAPI(toImpl(hitTestResultRef)->imageRect());
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h (151519 => 151520)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h 2013-06-12 19:52:04 UTC (rev 151519)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h 2013-06-12 19:58:29 UTC (rev 151520)
@@ -44,6 +44,7 @@
WK_EXPORT WKURLRef WKBundleHitTestResultCopyAbsolutePDFURL(WKBundleHitTestResultRef hitTestResult);
WK_EXPORT WKURLRef WKBundleHitTestResultCopyAbsoluteLinkURL(WKBundleHitTestResultRef hitTestResult);
WK_EXPORT WKURLRef WKBundleHitTestResultCopyAbsoluteMediaURL(WKBundleHitTestResultRef hitTestResult);
+WK_EXPORT bool WKBundleHitTestResultMediaIsInFullscreen(WKBundleHitTestResultRef hitTestResult);
WK_EXPORT WKRect WKBundleHitTestResultGetImageRect(WKBundleHitTestResultRef hitTestResult);
WK_EXPORT bool WKBundleHitTestResultGetIsSelected(WKBundleHitTestResultRef hitTestResult);
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp (151519 => 151520)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp 2013-06-12 19:52:04 UTC (rev 151519)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp 2013-06-12 19:58:29 UTC (rev 151520)
@@ -98,6 +98,11 @@
return m_hitTestResult.absoluteMediaURL().string();
}
+bool InjectedBundleHitTestResult::mediaIsInFullscreen() const
+{
+ return m_hitTestResult.mediaIsInFullscreen();
+}
+
String InjectedBundleHitTestResult::linkLabel() const
{
return m_hitTestResult.textContent();
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleHitTestResult.h (151519 => 151520)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleHitTestResult.h 2013-06-12 19:52:04 UTC (rev 151519)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleHitTestResult.h 2013-06-12 19:58:29 UTC (rev 151520)
@@ -51,6 +51,7 @@
String absolutePDFURL() const;
String absoluteLinkURL() const;
String absoluteMediaURL() const;
+ bool mediaIsInFullscreen() const;
String linkLabel() const;
String linkTitle() const;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
