Title: [151565] trunk
- Revision
- 151565
- Author
- [email protected]
- Date
- 2013-06-13 11:24:21 -0700 (Thu, 13 Jun 2013)
Log Message
Updating the -webkit-background-blend-mode property dynamically does not trigger a redraw of the element.
Source/WebCore:
Adding krit's fix: actual blending values should be compared, not the sets.
https://bugs.webkit.org/show_bug.cgi?id=117223
Patch by Mihai Tica <[email protected]> on 2013-06-13
Reviewed by Dirk Schulze.
Test: css3/compositing/background-blend-mode-image-color-dynamic.html
* rendering/style/FillLayer.cpp:
(WebCore::FillLayer::operator==):
LayoutTests:
Adding test that sets background blend modes from script, after the page is loaded.
https://bugs.webkit.org/show_bug.cgi?id=117223
Patch by Mihai Tica <[email protected]> on 2013-06-13
Reviewed by Dirk Schulze.
* fast/repaint/background-blend-mode-image-color-dynamic-expected.html: Added.
* fast/repaint/background-blend-mode-image-color-dynamic.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (151564 => 151565)
--- trunk/LayoutTests/ChangeLog 2013-06-13 18:22:23 UTC (rev 151564)
+++ trunk/LayoutTests/ChangeLog 2013-06-13 18:24:21 UTC (rev 151565)
@@ -1,3 +1,15 @@
+2013-06-13 Mihai Tica <[email protected]>
+
+ Updating the -webkit-background-blend-mode property dynamically does not trigger a redraw of the element.
+
+ Adding test that sets background blend modes from script, after the page is loaded.
+ https://bugs.webkit.org/show_bug.cgi?id=117223
+
+ Reviewed by Dirk Schulze.
+
+ * fast/repaint/background-blend-mode-image-color-dynamic-expected.html: Added.
+ * fast/repaint/background-blend-mode-image-color-dynamic.html: Added.
+
2013-06-13 Christophe Dumez <[email protected]>
Support byte and octet types in bindings generators
Added: trunk/LayoutTests/fast/repaint/background-blend-mode-image-color-dynamic-expected.html (0 => 151565)
--- trunk/LayoutTests/fast/repaint/background-blend-mode-image-color-dynamic-expected.html (rev 0)
+++ trunk/LayoutTests/fast/repaint/background-blend-mode-image-color-dynamic-expected.html 2013-06-13 18:24:21 UTC (rev 151565)
@@ -0,0 +1,16 @@
+<!DOCTYPE HTML>
+<html>
+<head>
+<style>
+ div {
+ margin: 5px;
+ width: 130px;
+ height: 130px;
+ background: url('resources/ducky.png') no-repeat 0 0 /100% 100%, green;
+ float: left;
+ }
+</style>
+<!-- This file should contain a duck with multiply blending. -->
+<body>
+ <div style="-webkit-background-blend-mode: multiply, normal"></div>
+</body>
Added: trunk/LayoutTests/fast/repaint/background-blend-mode-image-color-dynamic.html (0 => 151565)
--- trunk/LayoutTests/fast/repaint/background-blend-mode-image-color-dynamic.html (rev 0)
+++ trunk/LayoutTests/fast/repaint/background-blend-mode-image-color-dynamic.html 2013-06-13 18:24:21 UTC (rev 151565)
@@ -0,0 +1,25 @@
+<!DOCTYPE HTML>
+<html>
+<head>
+<script src="" type="text/_javascript_"></script>
+
+<style>
+ div {
+ margin: 5px;
+ width: 130px;
+ height: 130px;
+ background: url('resources/ducky.png') no-repeat 0 0 /100% 100%, green;
+ -webkit-background-blend-mode: normal, normal;
+ float: left;
+ }
+</style>
+<!-- This file should contain a duck with multiply blending set from script. -->
+<body>
+ <script>
+
+ function repaintTest() {
+ document.getElementById('blender').style.webkitBackgroundBlendMode = "multiply, normal";
+ }
+ </script>
+ <div id="blender"></div>
+</body>
Modified: trunk/Source/WebCore/ChangeLog (151564 => 151565)
--- trunk/Source/WebCore/ChangeLog 2013-06-13 18:22:23 UTC (rev 151564)
+++ trunk/Source/WebCore/ChangeLog 2013-06-13 18:24:21 UTC (rev 151565)
@@ -1,3 +1,17 @@
+2013-06-13 Mihai Tica <[email protected]>
+
+ Updating the -webkit-background-blend-mode property dynamically does not trigger a redraw of the element.
+
+ Adding krit's fix: actual blending values should be compared, not the sets.
+ https://bugs.webkit.org/show_bug.cgi?id=117223
+
+ Reviewed by Dirk Schulze.
+
+ Test: css3/compositing/background-blend-mode-image-color-dynamic.html
+
+ * rendering/style/FillLayer.cpp:
+ (WebCore::FillLayer::operator==):
+
2013-06-13 Beth Dakin <[email protected]>
Headers and footers should be pinned to the left edge of the window when scrolling
Modified: trunk/Source/WebCore/rendering/style/FillLayer.cpp (151564 => 151565)
--- trunk/Source/WebCore/rendering/style/FillLayer.cpp 2013-06-13 18:22:23 UTC (rev 151564)
+++ trunk/Source/WebCore/rendering/style/FillLayer.cpp 2013-06-13 18:24:21 UTC (rev 151565)
@@ -153,7 +153,7 @@
return StyleImage::imagesEquivalent(m_image.get(), o.m_image.get()) && m_xPosition == o.m_xPosition && m_yPosition == o.m_yPosition
&& m_backgroundXOrigin == o.m_backgroundXOrigin && m_backgroundYOrigin == o.m_backgroundYOrigin
&& m_attachment == o.m_attachment && m_clip == o.m_clip && m_composite == o.m_composite
- && m_blendModeSet == o.m_blendModeSet && m_origin == o.m_origin && m_repeatX == o.m_repeatX
+ && m_blendMode == o.m_blendMode && m_origin == o.m_origin && m_repeatX == o.m_repeatX
&& m_repeatY == o.m_repeatY && m_sizeType == o.m_sizeType && m_sizeLength == o.m_sizeLength
&& m_type == o.m_type && ((m_next && o.m_next) ? *m_next == *o.m_next : m_next == o.m_next);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
