Title: [151671] trunk/Source/WTF
Revision
151671
Author
[email protected]
Date
2013-06-18 00:02:00 -0700 (Tue, 18 Jun 2013)

Log Message

A static_assert() in RetainPtr.h sometimes causes the build to fail.

Wrap the first argument to a static_assert() in parentheses since it
contains a comma, which sometimes tricks the preprocessor into thinking
the macro is being passed three arguments rather than two.

Reviewed by Brian Weinstein.

* wtf/RetainPtr.h:
(WTF::RetainPtr::RetainPtr):

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (151670 => 151671)


--- trunk/Source/WTF/ChangeLog	2013-06-18 07:00:19 UTC (rev 151670)
+++ trunk/Source/WTF/ChangeLog	2013-06-18 07:02:00 UTC (rev 151671)
@@ -1,3 +1,16 @@
+2013-06-17  Andy Estes  <[email protected]>
+
+        A static_assert() in RetainPtr.h sometimes causes the build to fail.
+
+        Wrap the first argument to a static_assert() in parentheses since it
+        contains a comma, which sometimes tricks the preprocessor into thinking
+        the macro is being passed three arguments rather than two.
+
+        Reviewed by Brian Weinstein.
+
+        * wtf/RetainPtr.h:
+        (WTF::RetainPtr::RetainPtr):
+
 2013-06-17  Zan Dobersek  <[email protected]>
 
         REGRESSION (r149184): Build errors in RefPtr.h when building with Clang, C++98 standard

Modified: trunk/Source/WTF/wtf/RetainPtr.h (151670 => 151671)


--- trunk/Source/WTF/wtf/RetainPtr.h	2013-06-18 07:00:19 UTC (rev 151670)
+++ trunk/Source/WTF/wtf/RetainPtr.h	2013-06-18 07:02:00 UTC (rev 151671)
@@ -78,7 +78,7 @@
             : m_ptr(ptr)
         {
 #ifdef __OBJC__
-            static_assert(!std::is_convertible<T, id>::value, "Don't use adoptCF with Objective-C pointer types, use adoptNS.");
+            static_assert((!std::is_convertible<T, id>::value), "Don't use adoptCF with Objective-C pointer types, use adoptNS.");
 #endif
         }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to