Title: [151674] trunk
- Revision
- 151674
- Author
- [email protected]
- Date
- 2013-06-18 01:18:40 -0700 (Tue, 18 Jun 2013)
Log Message
[GTK][GStreamer] Fullscreen option in video element context menu not working
https://bugs.webkit.org/show_bug.cgi?id=105191
.:
Fullscreen with native controls is outdated and even broken in
[GTK][WK2], so they are deactivated for now.
Patch by Xabier Rodriguez Calvar <[email protected]> on 2013-06-18
Reviewed by Philippe Normand.
* Source/autotools/SetupAutoconfHeader.m4: Removed the use of
fullscreen native media controls.
LayoutTests:
Patch by Xabier Rodriguez Calvar <[email protected]> on 2013-06-18
Reviewed by Philippe Normand.
* platform/gtk-wk1/TestExpectations:
fullscreen/video-controls-drag.html does not time out anymore.
* platform/gtk-wk2/TestExpectations:
media/video-display-aspect-ratio.html crashes sometimes.
* platform/gtk/TestExpectations:
media/video-playing-and-pause.html was already flaky.
Modified Paths
Diff
Modified: trunk/ChangeLog (151673 => 151674)
--- trunk/ChangeLog 2013-06-18 08:09:55 UTC (rev 151673)
+++ trunk/ChangeLog 2013-06-18 08:18:40 UTC (rev 151674)
@@ -1,3 +1,16 @@
+2013-06-18 Xabier Rodriguez Calvar <[email protected]>
+
+ [GTK][GStreamer] Fullscreen option in video element context menu not working
+ https://bugs.webkit.org/show_bug.cgi?id=105191
+
+ Fullscreen with native controls is outdated and even broken in
+ [GTK][WK2], so they are deactivated for now.
+
+ Reviewed by Philippe Normand.
+
+ * Source/autotools/SetupAutoconfHeader.m4: Removed the use of
+ fullscreen native media controls.
+
2013-06-17 Michael Brüning <[email protected]>
[Qt] Remove Qt specific QTKIT flagged code.
Modified: trunk/LayoutTests/ChangeLog (151673 => 151674)
--- trunk/LayoutTests/ChangeLog 2013-06-18 08:09:55 UTC (rev 151673)
+++ trunk/LayoutTests/ChangeLog 2013-06-18 08:18:40 UTC (rev 151674)
@@ -1,3 +1,17 @@
+2013-06-18 Xabier Rodriguez Calvar <[email protected]>
+
+ [GTK][GStreamer] Fullscreen option in video element context menu not working
+ https://bugs.webkit.org/show_bug.cgi?id=105191
+
+ Reviewed by Philippe Normand.
+
+ * platform/gtk-wk1/TestExpectations:
+ fullscreen/video-controls-drag.html does not time out anymore.
+ * platform/gtk-wk2/TestExpectations:
+ media/video-display-aspect-ratio.html crashes sometimes.
+ * platform/gtk/TestExpectations:
+ media/video-playing-and-pause.html was already flaky.
+
2013-06-18 Zan Dobersek <[email protected]>
Unreviewed GTK gardening.
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (151673 => 151674)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2013-06-18 08:09:55 UTC (rev 151673)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2013-06-18 08:18:40 UTC (rev 151674)
@@ -646,6 +646,8 @@
webkit.org/b/117583 http/tests/media/video-load-twice.html [ Failure Pass ]
+webkit.org/b/105191 media/video-playing-and-pause.html [ Failure Pass ]
+
#////////////////////////////////////////////////////////////////////////////////////////
# End of Flaky tests
#////////////////////////////////////////////////////////////////////////////////////////
Modified: trunk/LayoutTests/platform/gtk-wk1/TestExpectations (151673 => 151674)
--- trunk/LayoutTests/platform/gtk-wk1/TestExpectations 2013-06-18 08:09:55 UTC (rev 151673)
+++ trunk/LayoutTests/platform/gtk-wk1/TestExpectations 2013-06-18 08:18:40 UTC (rev 151674)
@@ -82,7 +82,6 @@
webkit.org/b/108363 fullscreen/full-screen-crash-offsetLeft.html [ Timeout ]
webkit.org/b/108363 fullscreen/full-screen-no-style-sharing.html [ Timeout ]
webkit.org/b/108363 fullscreen/full-screen-stacking-context.html [ Timeout ]
-webkit.org/b/108363 fullscreen/video-controls-drag.html [ Timeout ]
webkit.org/b/108363 fullscreen/video-controls-override.html [ Timeout ]
webkit.org/b/108363 fullscreen/video-specified-size.html [ Timeout ]
Modified: trunk/LayoutTests/platform/gtk-wk2/TestExpectations (151673 => 151674)
--- trunk/LayoutTests/platform/gtk-wk2/TestExpectations 2013-06-18 08:09:55 UTC (rev 151673)
+++ trunk/LayoutTests/platform/gtk-wk2/TestExpectations 2013-06-18 08:18:40 UTC (rev 151674)
@@ -226,6 +226,8 @@
webkit.org/b/116974 accessibility/title-ui-element-correctness.html [ Crash ]
+webkit.org/b/117551 media/video-display-aspect-ratio.html [ Crash Pass ]
+
#////////////////////////////////////////////////////////////////////////////////////////
# End of Crashing tests
#////////////////////////////////////////////////////////////////////////////////////////
Modified: trunk/Source/autotools/SetupAutoconfHeader.m4 (151673 => 151674)
--- trunk/Source/autotools/SetupAutoconfHeader.m4 2013-06-18 08:09:55 UTC (rev 151673)
+++ trunk/Source/autotools/SetupAutoconfHeader.m4 2013-06-18 08:18:40 UTC (rev 151674)
@@ -56,10 +56,6 @@
if test "$enable_debug" = "yes"; then
AC_DEFINE([GST_DISABLE_DEPRECATED], [1], [ ])
fi
-
- if test "$enable_video" = "yes"; then
- AC_DEFINE([WTF_USE_NATIVE_FULLSCREEN_VIDEO], [1], [ ])
- fi
fi
if test "$enable_web_audio" = "yes"; then
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
