Title: [151680] trunk/Source/WebCore
- Revision
- 151680
- Author
- [email protected]
- Date
- 2013-06-18 04:23:37 -0700 (Tue, 18 Jun 2013)
Log Message
[WebSpeech] Speech Recognition requires convertValue support in JSDictionary
https://bugs.webkit.org/show_bug.cgi?id=117731
Patch by Praveen R Jadhav <[email protected]> on 2013-06-18
Reviewed by Christophe Dumez.
Build fails after enabling ENABLE_SCRIPTED_SPEECH feature. This patch
resolves the issue.
No new tests. No change in behaviour.
* bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue):
* bindings/js/JSDictionary.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (151679 => 151680)
--- trunk/Source/WebCore/ChangeLog 2013-06-18 10:30:22 UTC (rev 151679)
+++ trunk/Source/WebCore/ChangeLog 2013-06-18 11:23:37 UTC (rev 151680)
@@ -1,3 +1,19 @@
+2013-06-18 Praveen R Jadhav <[email protected]>
+
+ [WebSpeech] Speech Recognition requires convertValue support in JSDictionary
+ https://bugs.webkit.org/show_bug.cgi?id=117731
+
+ Reviewed by Christophe Dumez.
+
+ Build fails after enabling ENABLE_SCRIPTED_SPEECH feature. This patch
+ resolves the issue.
+
+ No new tests. No change in behaviour.
+
+ * bindings/js/JSDictionary.cpp:
+ (WebCore::JSDictionary::convertValue):
+ * bindings/js/JSDictionary.h:
+
2013-06-18 Mary Wu <[email protected]>
[BlackBerry] only notify download client when download error
Modified: trunk/Source/WebCore/bindings/js/JSDictionary.cpp (151679 => 151680)
--- trunk/Source/WebCore/bindings/js/JSDictionary.cpp 2013-06-18 10:30:22 UTC (rev 151679)
+++ trunk/Source/WebCore/bindings/js/JSDictionary.cpp 2013-06-18 11:23:37 UTC (rev 151680)
@@ -52,6 +52,10 @@
#include "JSMediaStream.h"
#endif
+#if ENABLE(SCRIPTED_SPEECH)
+#include "JSSpeechRecognitionResultList.h"
+#endif
+
using namespace JSC;
namespace WebCore {
@@ -249,6 +253,13 @@
}
#endif
+#if ENABLE(SCRIPTED_SPEECH)
+void JSDictionary::convertValue(JSC::ExecState*, JSC::JSValue value, RefPtr<SpeechRecognitionResultList>& result)
+{
+ result = toSpeechRecognitionResultList(value);
+}
+#endif
+
bool JSDictionary::getWithUndefinedOrNullCheck(const String& propertyName, String& result) const
{
ASSERT(isValid());
Modified: trunk/Source/WebCore/bindings/js/JSDictionary.h (151679 => 151680)
--- trunk/Source/WebCore/bindings/js/JSDictionary.h 2013-06-18 10:30:22 UTC (rev 151679)
+++ trunk/Source/WebCore/bindings/js/JSDictionary.h 2013-06-18 11:23:37 UTC (rev 151680)
@@ -50,6 +50,10 @@
class TrackBase;
class VoidCallback;
+#if ENABLE(SCRIPTED_SPEECH)
+class SpeechRecognitionResultList;
+#endif
+
class JSDictionary {
public:
JSDictionary(JSC::ExecState* exec, JSC::JSObject* initializerObject)
@@ -127,6 +131,9 @@
static void convertValue(JSC::ExecState*, JSC::JSValue, RefPtr<DOMError>& result);
static void convertValue(JSC::ExecState*, JSC::JSValue, RefPtr<VoidCallback>& result);
#endif
+#if ENABLE(SCRIPTED_SPEECH)
+ static void convertValue(JSC::ExecState*, JSC::JSValue, RefPtr<SpeechRecognitionResultList>&);
+#endif
JSC::ExecState* m_exec;
JSC::Strong<JSC::JSObject> m_initializerObject;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes