Title: [151682] trunk/Source/WebCore
- Revision
- 151682
- Author
- [email protected]
- Date
- 2013-06-18 06:04:58 -0700 (Tue, 18 Jun 2013)
Log Message
[GTK] Remove comment about possibility of handling ObjCPolymorphic (it's used by ObjC bindings only)
https://bugs.webkit.org/show_bug.cgi?id=117546
Patch by Diego Pino Garcia <[email protected]> on 2013-06-18
Reviewed by Xan Lopez.
According to the WebKit IDL spec the modifier ObjCPolymorphic only
applies to the Objective-C bindings generator
* bindings/scripts/CodeGeneratorGObject.pm:
(IsPolymorphic): Remove comment. Search parameter 'type' in array, instead of
concatening a series of 'or' conditionals.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (151681 => 151682)
--- trunk/Source/WebCore/ChangeLog 2013-06-18 12:24:02 UTC (rev 151681)
+++ trunk/Source/WebCore/ChangeLog 2013-06-18 13:04:58 UTC (rev 151682)
@@ -1,3 +1,17 @@
+2013-06-18 Diego Pino Garcia <[email protected]>
+
+ [GTK] Remove comment about possibility of handling ObjCPolymorphic (it's used by ObjC bindings only)
+ https://bugs.webkit.org/show_bug.cgi?id=117546
+
+ Reviewed by Xan Lopez.
+
+ According to the WebKit IDL spec the modifier ObjCPolymorphic only
+ applies to the Objective-C bindings generator
+
+ * bindings/scripts/CodeGeneratorGObject.pm:
+ (IsPolymorphic): Remove comment. Search parameter 'type' in array, instead of
+ concatening a series of 'or' conditionals.
+
2013-06-18 Víctor Manuel Jáquez Leal <[email protected]>
Fix after r151673
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm (151681 => 151682)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2013-06-18 12:24:02 UTC (rev 151681)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2013-06-18 13:04:58 UTC (rev 151682)
@@ -1382,9 +1382,7 @@
sub IsPolymorphic {
my $type = shift;
- # FIXME: should we use ObjCPolymorphic attribute? or is it specific to ObjC bindings?
- return 1 if $type eq "Node" or $type eq "Event" or $type eq "HTMLCollection" or $type eq "StyleSheet" or $type eq "Blob";
- return 0;
+ return scalar(grep {$_ eq $type} qw(Blob Event HTMLCollection Node StyleSheet));
}
sub GenerateEventTargetIface {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
