Title: [151734] trunk/Source/WebCore
Revision
151734
Author
[email protected]
Date
2013-06-19 08:23:32 -0700 (Wed, 19 Jun 2013)

Log Message

[BlackBerry] Several tests crash due to an assert when creating an ImageBuffer
https://bugs.webkit.org/show_bug.cgi?id=117793

Patch by Carlos Garcia Campos <[email protected]> on 2013-06-19
Reviewed by Rob Buis.

JIRA 388741

Fixes a crash in several layout tests due to an assert when
creating an ImageBuffer with an empty size.

* platform/graphics/blackberry/ImageBufferBlackBerry.cpp:
(WebCore::ImageBuffer::ImageBuffer): Return early if the given
size is empty.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (151733 => 151734)


--- trunk/Source/WebCore/ChangeLog	2013-06-19 15:03:56 UTC (rev 151733)
+++ trunk/Source/WebCore/ChangeLog	2013-06-19 15:23:32 UTC (rev 151734)
@@ -1,3 +1,19 @@
+2013-06-19  Carlos Garcia Campos  <[email protected]>
+
+        [BlackBerry] Several tests crash due to an assert when creating an ImageBuffer
+        https://bugs.webkit.org/show_bug.cgi?id=117793
+
+        Reviewed by Rob Buis.
+
+        JIRA 388741
+
+        Fixes a crash in several layout tests due to an assert when
+        creating an ImageBuffer with an empty size.
+
+        * platform/graphics/blackberry/ImageBufferBlackBerry.cpp:
+        (WebCore::ImageBuffer::ImageBuffer): Return early if the given
+        size is empty.
+
 2013-06-19  Víctor Manuel Jáquez Leal  <[email protected]>
 
         [GStreamer] [texmap] the bytesPerLine is wrong when updating the texture

Modified: trunk/Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp (151733 => 151734)


--- trunk/Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp	2013-06-19 15:03:56 UTC (rev 151733)
+++ trunk/Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp	2013-06-19 15:23:32 UTC (rev 151734)
@@ -168,6 +168,9 @@
     m_data.m_platformLayer = nullptr;
     m_data.m_window = 0;
 
+    if (m_size.isEmpty())
+        return;
+
     // anything bigger then defaultTileSize is just a problem for the HW.
     const int maxTileSize = BlackBerry::Platform::Graphics::TiledImage::defaultTileSize();
     if (maxTileSize <= size.width() || maxTileSize <= size.height()) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to