Title: [151762] trunk/Source/WebCore
- Revision
- 151762
- Author
- [email protected]
- Date
- 2013-06-19 19:18:07 -0700 (Wed, 19 Jun 2013)
Log Message
[Mac] Common crashes when playing media
https://bugs.webkit.org/show_bug.cgi?id=117813
<rdar://problem/13837412>
Reviewed by Eric Carlson.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(-[WebCoreAVFLoaderDelegate resourceLoader:didCancelLoadingRequest:]):
This method may be called from a secondary thread, but it does things that are
not thread safe.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (151761 => 151762)
--- trunk/Source/WebCore/ChangeLog 2013-06-20 01:06:22 UTC (rev 151761)
+++ trunk/Source/WebCore/ChangeLog 2013-06-20 02:18:07 UTC (rev 151762)
@@ -1,3 +1,16 @@
+2013-06-19 Alexey Proskuryakov <[email protected]>
+
+ [Mac] Common crashes when playing media
+ https://bugs.webkit.org/show_bug.cgi?id=117813
+ <rdar://problem/13837412>
+
+ Reviewed by Eric Carlson.
+
+ * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+ (-[WebCoreAVFLoaderDelegate resourceLoader:didCancelLoadingRequest:]):
+ This method may be called from a secondary thread, but it does things that are
+ not thread safe.
+
2013-06-19 Yuki Sekiguchi <[email protected]>
Incomplete repaint of input elements in writing-mode overflow
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (151761 => 151762)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2013-06-20 01:06:22 UTC (rev 151761)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2013-06-20 02:18:07 UTC (rev 151762)
@@ -1709,7 +1709,10 @@
if (!m_callback)
return;
- return m_callback->didCancelLoadingRequest(loadingRequest);
+ dispatch_async(dispatch_get_main_queue(), ^{
+ if (m_callback)
+ m_callback->didCancelLoadingRequest(loadingRequest);
+ });
}
- (void)setCallback:(MediaPlayerPrivateAVFoundationObjC*)callback
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
