Title: [151785] trunk/Source/WebCore
- Revision
- 151785
- Author
- [email protected]
- Date
- 2013-06-20 11:24:08 -0700 (Thu, 20 Jun 2013)
Log Message
Roll-on in-band captions are displayed bottom-to-top rather than top-to-bottom.
https://bugs.webkit.org/show_bug.cgi?id=117811
Reviewed by Eric Carlson.
When comparing Generic cues, we should check that their type is Generic, not WebVTT.
* html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGeneric::isOrderedBefore):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (151784 => 151785)
--- trunk/Source/WebCore/ChangeLog 2013-06-20 18:07:48 UTC (rev 151784)
+++ trunk/Source/WebCore/ChangeLog 2013-06-20 18:24:08 UTC (rev 151785)
@@ -1,3 +1,15 @@
+2013-06-19 Jer Noble <[email protected]>
+
+ Roll-on in-band captions are displayed bottom-to-top rather than top-to-bottom.
+ https://bugs.webkit.org/show_bug.cgi?id=117811
+
+ Reviewed by Eric Carlson.
+
+ When comparing Generic cues, we should check that their type is Generic, not WebVTT.
+
+ * html/track/TextTrackCueGeneric.cpp:
+ (WebCore::TextTrackCueGeneric::isOrderedBefore):
+
2013-06-20 Ralph Thomas <[email protected]>
[CMake][CSS Shaders] Add WebCore files for CSS Shaders to CMakeLists.txt
Modified: trunk/Source/WebCore/html/track/TextTrackCueGeneric.cpp (151784 => 151785)
--- trunk/Source/WebCore/html/track/TextTrackCueGeneric.cpp 2013-06-20 18:07:48 UTC (rev 151784)
+++ trunk/Source/WebCore/html/track/TextTrackCueGeneric.cpp 2013-06-20 18:24:08 UTC (rev 151785)
@@ -178,7 +178,7 @@
if (TextTrackCue::isOrderedBefore(that))
return true;
- if (that->cueType() == WebVTT && startTime() == that->startTime() && endTime() == that->endTime()) {
+ if (that->cueType() == Generic && startTime() == that->startTime() && endTime() == that->endTime()) {
// Further order generic cues by their calculated line value.
std::pair<double, double> thisPosition = getPositionCoordinates();
std::pair<double, double> thatPosition = that->getPositionCoordinates();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
