Title: [151806] branches/dfgFourthTier/Source/_javascript_Core
Revision
151806
Author
[email protected]
Date
2013-06-20 14:42:51 -0700 (Thu, 20 Jun 2013)

Log Message

fourthTier: FTL should clear character switch jump tables
https://bugs.webkit.org/show_bug.cgi?id=117852

Reviewed by Sam Weinig.
        
The FTL just uses LLVM's switch, which results in LLVM allocating its own switch
jump tables as needed.

* bytecode/CodeBlock.h:
(JSC::CodeBlock::clearCharacterSwitchJumpTables):
* ftl/FTLLink.cpp:
(JSC::FTL::link):

Modified Paths

Diff

Modified: branches/dfgFourthTier/Source/_javascript_Core/ChangeLog (151805 => 151806)


--- branches/dfgFourthTier/Source/_javascript_Core/ChangeLog	2013-06-20 21:37:10 UTC (rev 151805)
+++ branches/dfgFourthTier/Source/_javascript_Core/ChangeLog	2013-06-20 21:42:51 UTC (rev 151806)
@@ -1,5 +1,20 @@
 2013-06-20  Filip Pizlo  <[email protected]>
 
+        fourthTier: FTL should clear character switch jump tables
+        https://bugs.webkit.org/show_bug.cgi?id=117852
+
+        Reviewed by Sam Weinig.
+        
+        The FTL just uses LLVM's switch, which results in LLVM allocating its own switch
+        jump tables as needed.
+
+        * bytecode/CodeBlock.h:
+        (JSC::CodeBlock::clearCharacterSwitchJumpTables):
+        * ftl/FTLLink.cpp:
+        (JSC::FTL::link):
+
+2013-06-20  Filip Pizlo  <[email protected]>
+
         fourthTier: FTL should support SwitchChar
         https://bugs.webkit.org/show_bug.cgi?id=117849
 

Modified: branches/dfgFourthTier/Source/_javascript_Core/bytecode/CodeBlock.h (151805 => 151806)


--- branches/dfgFourthTier/Source/_javascript_Core/bytecode/CodeBlock.h	2013-06-20 21:37:10 UTC (rev 151805)
+++ branches/dfgFourthTier/Source/_javascript_Core/bytecode/CodeBlock.h	2013-06-20 21:42:51 UTC (rev 151806)
@@ -714,6 +714,12 @@
     size_t numberOfCharacterSwitchJumpTables() const { return m_rareData ? m_rareData->m_characterSwitchJumpTables.size() : 0; }
     SimpleJumpTable& addCharacterSwitchJumpTable() { createRareDataIfNecessary(); m_rareData->m_characterSwitchJumpTables.append(SimpleJumpTable()); return m_rareData->m_characterSwitchJumpTables.last(); }
     SimpleJumpTable& characterSwitchJumpTable(int tableIndex) { RELEASE_ASSERT(m_rareData); return m_rareData->m_characterSwitchJumpTables[tableIndex]; }
+    void clearCharacterSwitchJumpTables()
+    {
+        if (!m_rareData)
+            return;
+        m_rareData->m_characterSwitchJumpTables.clear();
+    }
 
     size_t numberOfStringSwitchJumpTables() const { return m_rareData ? m_rareData->m_stringSwitchJumpTables.size() : 0; }
     StringJumpTable& addStringSwitchJumpTable() { createRareDataIfNecessary(); m_rareData->m_stringSwitchJumpTables.append(StringJumpTable()); return m_rareData->m_stringSwitchJumpTables.last(); }

Modified: branches/dfgFourthTier/Source/_javascript_Core/ftl/FTLLink.cpp (151805 => 151806)


--- branches/dfgFourthTier/Source/_javascript_Core/ftl/FTLLink.cpp	2013-06-20 21:37:10 UTC (rev 151805)
+++ branches/dfgFourthTier/Source/_javascript_Core/ftl/FTLLink.cpp	2013-06-20 21:42:51 UTC (rev 151806)
@@ -54,6 +54,7 @@
     
     // LLVM will create its own jump tables as needed.
     codeBlock->clearImmediateSwitchJumpTables();
+    codeBlock->clearCharacterSwitchJumpTables();
     
     // Create the entrypoint.
     // FIXME: This is a total kludge - LLVM should just use our calling convention.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to