[webkit-changes] [151833] trunk/Source/WebKit2

Fri, 21 Jun 2013 04:40:46 -0700

Title: [151833] trunk/Source/WebKit2
Revision
151833
Author
[email protected]
Date
2013-06-21 04:41:39 -0700 (Fri, 21 Jun 2013)

Log Message

[GTK] Do not try to load videos in unit tests
https://bugs.webkit.org/show_bug.cgi?id=117866

Reviewed by Philippe Normand.

It makes the tests slower, and generates and error because we use
a fake src.

* UIProcess/API/gtk/tests/TestContextMenu.cpp:
(testContextMenuDefaultMenu): Use preload='none' in video tag.
* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewMouseTarget): Ditto.

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (151832 => 151833)


--- trunk/Source/WebKit2/ChangeLog	2013-06-21 10:34:57 UTC (rev 151832)
+++ trunk/Source/WebKit2/ChangeLog	2013-06-21 11:41:39 UTC (rev 151833)
@@ -1,3 +1,18 @@
+2013-06-21  Carlos Garcia Campos  <[email protected]>
+
+        [GTK] Do not try to load videos in unit tests
+        https://bugs.webkit.org/show_bug.cgi?id=117866
+
+        Reviewed by Philippe Normand.
+
+        It makes the tests slower, and generates and error because we use
+        a fake src.
+
+        * UIProcess/API/gtk/tests/TestContextMenu.cpp:
+        (testContextMenuDefaultMenu): Use preload='none' in video tag.
+        * UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
+        (testWebViewMouseTarget): Ditto.
+
 2013-06-21  Christophe Dumez  <[email protected]>
 
         REGRESSION (r150663): Using webkitAudioContext in Inspector makes it undefined everywhere

Modified: trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestContextMenu.cpp (151832 => 151833)


--- trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestContextMenu.cpp	2013-06-21 10:34:57 UTC (rev 151832)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestContextMenu.cpp	2013-06-21 11:41:39 UTC (rev 151833)
@@ -355,7 +355,7 @@
         " <img style='position:absolute; left:1; top:10' src='' width=5 height=5></img>"
         " <a style='position:absolute; left:1; top:20' href='' title='WebKitGTK+ Logo'><img src='' width=5 height=5></img></a>"
         " <input style='position:absolute; left:1; top:30' size='10'></input>"
-        " <video style='position:absolute; left:1; top:50' width='300' height='300' controls='controls'><source src='' type='video/ogg' /></video>"
+        " <video style='position:absolute; left:1; top:50' width='300' height='300' controls='controls' preload='none'><source src='' type='video/ogg' /></video>"
         "</body></html>";
     test->loadHtml(linksHTML, "file:///");
     test->waitUntilLoadFinished();

Modified: trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp (151832 => 151833)


--- trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp	2013-06-21 10:34:57 UTC (rev 151832)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp	2013-06-21 11:41:39 UTC (rev 151833)
@@ -478,7 +478,7 @@
         " <a style='position:absolute; left:1; top:20' href='' title='WebKitGTK+ Logo'><img src='' width=5 height=5></img></a>"
         " <input style='position:absolute; left:1; top:30' size='10'></input>"
         " <div style='position:absolute; left:1; top:50; width:30; height:30; overflow:scroll'>&nbsp;</div>"
-        " <video style='position:absolute; left:1; top:100' width='300' height='300' controls='controls'><source src='' type='video/ogg' /></video>"
+        " <video style='position:absolute; left:1; top:100' width='300' height='300' controls='controls' preload='none'><source src='' type='video/ogg' /></video>"
         "</body></html>";
 
     test->loadHtml(linksHoveredHTML, "file:///");

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to