Title: [151838] trunk/Source/WebCore
- Revision
- 151838
- Author
- [email protected]
- Date
- 2013-06-21 09:01:52 -0700 (Fri, 21 Jun 2013)
Log Message
HTMLMediaElement should inherit from MediaPlayerClient privately
https://bugs.webkit.org/show_bug.cgi?id=117874
Reviewed by Andreas Kling.
Fixing FIXME: HTMLMediaElement was stuck with public inheritance from
MediaPlayerClient due to the Chromium port.
This can now be fixed to a private inheritance.
* html/HTMLMediaElement.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (151837 => 151838)
--- trunk/Source/WebCore/ChangeLog 2013-06-21 15:58:41 UTC (rev 151837)
+++ trunk/Source/WebCore/ChangeLog 2013-06-21 16:01:52 UTC (rev 151838)
@@ -1,5 +1,18 @@
2013-06-21 Allan Sandfeld Jensen <[email protected]>
+ HTMLMediaElement should inherit from MediaPlayerClient privately
+ https://bugs.webkit.org/show_bug.cgi?id=117874
+
+ Reviewed by Andreas Kling.
+
+ Fixing FIXME: HTMLMediaElement was stuck with public inheritance from
+ MediaPlayerClient due to the Chromium port.
+ This can now be fixed to a private inheritance.
+
+ * html/HTMLMediaElement.h:
+
+2013-06-21 Allan Sandfeld Jensen <[email protected]>
+
Remove Chromium-only TouchDisambiguation
https://bugs.webkit.org/show_bug.cgi?id=117873
Modified: trunk/Source/WebCore/html/HTMLMediaElement.h (151837 => 151838)
--- trunk/Source/WebCore/html/HTMLMediaElement.h 2013-06-21 15:58:41 UTC (rev 151837)
+++ trunk/Source/WebCore/html/HTMLMediaElement.h 2013-06-21 16:01:52 UTC (rev 151838)
@@ -88,11 +88,7 @@
typedef Vector<CueInterval> CueList;
#endif
-// FIXME: The inheritance from MediaPlayerClient here should be private inheritance.
-// But it can't be until the Chromium WebMediaPlayerClientImpl class is fixed so it
-// no longer depends on typecasting a MediaPlayerClient to an HTMLMediaElement.
-
-class HTMLMediaElement : public HTMLElement, public MediaPlayerClient, public MediaPlayerSupportsTypeClient, private MediaCanStartListener, public ActiveDOMObject, public MediaControllerInterface
+class HTMLMediaElement : public HTMLElement, private MediaPlayerClient, public MediaPlayerSupportsTypeClient, private MediaCanStartListener, public ActiveDOMObject, public MediaControllerInterface
#if ENABLE(VIDEO_TRACK)
, private AudioTrackClient
, private TextTrackClient
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
