Title: [151842] trunk/Source/WebCore
- Revision
- 151842
- Author
- [email protected]
- Date
- 2013-06-21 09:48:31 -0700 (Fri, 21 Jun 2013)
Log Message
Unreviewed, rolling out r151838.
http://trac.webkit.org/changeset/151838
https://bugs.webkit.org/show_bug.cgi?id=117880
Breaks MediaPlayerPrivateQt on Mac (Requested by carewolf on
#webkit).
* html/HTMLMediaElement.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (151841 => 151842)
--- trunk/Source/WebCore/ChangeLog 2013-06-21 16:35:34 UTC (rev 151841)
+++ trunk/Source/WebCore/ChangeLog 2013-06-21 16:48:31 UTC (rev 151842)
@@ -1,3 +1,14 @@
+2013-06-21 Commit Queue <[email protected]>
+
+ Unreviewed, rolling out r151838.
+ http://trac.webkit.org/changeset/151838
+ https://bugs.webkit.org/show_bug.cgi?id=117880
+
+ Breaks MediaPlayerPrivateQt on Mac (Requested by carewolf on
+ #webkit).
+
+ * html/HTMLMediaElement.h:
+
2013-06-20 Brent Fulgham <[email protected]>
[Windows] AX: Radio buttons with "tab" role should describe themselves as tabs
Modified: trunk/Source/WebCore/html/HTMLMediaElement.h (151841 => 151842)
--- trunk/Source/WebCore/html/HTMLMediaElement.h 2013-06-21 16:35:34 UTC (rev 151841)
+++ trunk/Source/WebCore/html/HTMLMediaElement.h 2013-06-21 16:48:31 UTC (rev 151842)
@@ -88,7 +88,11 @@
typedef Vector<CueInterval> CueList;
#endif
-class HTMLMediaElement : public HTMLElement, private MediaPlayerClient, public MediaPlayerSupportsTypeClient, private MediaCanStartListener, public ActiveDOMObject, public MediaControllerInterface
+// FIXME: The inheritance from MediaPlayerClient here should be private inheritance.
+// But it can't be until the Chromium WebMediaPlayerClientImpl class is fixed so it
+// no longer depends on typecasting a MediaPlayerClient to an HTMLMediaElement.
+
+class HTMLMediaElement : public HTMLElement, public MediaPlayerClient, public MediaPlayerSupportsTypeClient, private MediaCanStartListener, public ActiveDOMObject, public MediaControllerInterface
#if ENABLE(VIDEO_TRACK)
, private AudioTrackClient
, private TextTrackClient
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
