Title: [151852] trunk
- Revision
- 151852
- Author
- [email protected]
- Date
- 2013-06-21 13:21:07 -0700 (Fri, 21 Jun 2013)
Log Message
AX: audio/video playback control timers (elapsed and remaining) should be exposed as ApplicationTimerRole
https://bugs.webkit.org/show_bug.cgi?id=117883
Patch by James Craig <[email protected]> on 2013-06-21
Reviewed by Chris Fleizach.
Some of the media controls were returning the wrong role. Updated existing test coverage.
Source/WebCore:
* accessibility/AccessibilityMediaControls.h:
(WebCore::AccessibilityMediaTimeDisplay::roleValue):
LayoutTests:
* accessibility/media-element.html:
* platform/mac/accessibility/media-element-expected.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (151851 => 151852)
--- trunk/LayoutTests/ChangeLog 2013-06-21 19:59:44 UTC (rev 151851)
+++ trunk/LayoutTests/ChangeLog 2013-06-21 20:21:07 UTC (rev 151852)
@@ -1,3 +1,15 @@
+2013-06-21 James Craig <[email protected]>
+
+ AX: audio/video playback control timers (elapsed and remaining) should be exposed as ApplicationTimerRole
+ https://bugs.webkit.org/show_bug.cgi?id=117883
+
+ Reviewed by Chris Fleizach.
+
+ Some of the media controls were returning the wrong role. Updated existing test coverage.
+
+ * accessibility/media-element.html:
+ * platform/mac/accessibility/media-element-expected.txt:
+
2013-06-20 Brent Fulgham <[email protected]>
[Windows] AX: Radio buttons with "tab" role should describe themselves as tabs.
Modified: trunk/LayoutTests/accessibility/media-element.html (151851 => 151852)
--- trunk/LayoutTests/accessibility/media-element.html 2013-06-21 19:59:44 UTC (rev 151851)
+++ trunk/LayoutTests/accessibility/media-element.html 2013-06-21 20:21:07 UTC (rev 151852)
@@ -20,6 +20,7 @@
{
debug(indent(indentLevel) + "description: " + axObject.description);
debug(indent(indentLevel) + "role: " + axObject.role);
+ if (axObject.subrole != 'AXSubrole: ') debug(indent(indentLevel) + "subrole: " + axObject.subrole);
debug("<br>");
}
Modified: trunk/LayoutTests/platform/mac/accessibility/media-element-expected.txt (151851 => 151852)
--- trunk/LayoutTests/platform/mac/accessibility/media-element-expected.txt 2013-06-21 19:59:44 UTC (rev 151851)
+++ trunk/LayoutTests/platform/mac/accessibility/media-element-expected.txt 2013-06-21 20:21:07 UTC (rev 151852)
@@ -17,11 +17,21 @@
description: AXDescription: elapsed time
- role: AXRole: AXStaticText
+ role: AXRole: AXGroup
+ subrole: AXSubrole: AXApplicationTimer
+ description: AXDescription:
+ role: AXRole: AXGroup
+
+
+ description: AXDescription:
+ role: AXRole: AXStaticText
+
+
description: AXDescription:
role: AXRole: AXSlider
+ subrole: AXSubrole: AXTimeline
description: AXDescription:
@@ -29,9 +39,18 @@
description: AXDescription: remaining time
- role: AXRole: AXStaticText
+ role: AXRole: AXGroup
+ subrole: AXSubrole: AXApplicationTimer
+ description: AXDescription:
+ role: AXRole: AXGroup
+
+
+ description: AXDescription:
+ role: AXRole: AXStaticText
+
+
description: AXDescription: enter fullscreen
role: AXRole: AXButton
Modified: trunk/Source/WebCore/ChangeLog (151851 => 151852)
--- trunk/Source/WebCore/ChangeLog 2013-06-21 19:59:44 UTC (rev 151851)
+++ trunk/Source/WebCore/ChangeLog 2013-06-21 20:21:07 UTC (rev 151852)
@@ -1,3 +1,15 @@
+2013-06-21 James Craig <[email protected]>
+
+ AX: audio/video playback control timers (elapsed and remaining) should be exposed as ApplicationTimerRole
+ https://bugs.webkit.org/show_bug.cgi?id=117883
+
+ Reviewed by Chris Fleizach.
+
+ Some of the media controls were returning the wrong role. Updated existing test coverage.
+
+ * accessibility/AccessibilityMediaControls.h:
+ (WebCore::AccessibilityMediaTimeDisplay::roleValue):
+
2013-06-21 Alex Christensen <[email protected]>
Added glext.h from http://www.opengl.org/registry/oldspecs/glext.h for Windows
Modified: trunk/Source/WebCore/accessibility/AccessibilityMediaControls.h (151851 => 151852)
--- trunk/Source/WebCore/accessibility/AccessibilityMediaControls.h 2013-06-21 19:59:44 UTC (rev 151851)
+++ trunk/Source/WebCore/accessibility/AccessibilityMediaControls.h 2013-06-21 20:21:07 UTC (rev 151852)
@@ -100,7 +100,7 @@
static PassRefPtr<AccessibilityObject> create(RenderObject*);
virtual ~AccessibilityMediaTimeDisplay() { }
- virtual AccessibilityRole roleValue() const { return StaticTextRole; }
+ virtual AccessibilityRole roleValue() const { return ApplicationTimerRole; }
virtual String stringValue() const;
virtual String accessibilityDescription() const;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
