Title: [151868] trunk
- Revision
- 151868
- Author
- [email protected]
- Date
- 2013-06-21 16:39:41 -0700 (Fri, 21 Jun 2013)
Log Message
AX: Title for ListItemRole should consist of concatenated child text elements.
https://bugs.webkit.org/show_bug.cgi?id=117892
Reviewed by Chris Fleizach.
Source/WebCore:
accessibility/listitem-title.html
* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::visibleText): Add ListItemRole to set of
elements that concatenate their children for display purposes.
(WebCore::AccessibilityNodeObject::title): Ditto.
LayoutTests:
* accessibility/listitem-title.html: Added.
* platform/mac/accessibility/listitem-title-expected.txt: Added.
* platform/win/accessibility/listitem-title-expected.txt: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (151867 => 151868)
--- trunk/LayoutTests/ChangeLog 2013-06-21 23:28:01 UTC (rev 151867)
+++ trunk/LayoutTests/ChangeLog 2013-06-21 23:39:41 UTC (rev 151868)
@@ -1,3 +1,14 @@
+2013-06-21 Brent Fulgham <[email protected]>
+
+ AX: Title for ListItemRole should consist of concatenated child text elements.
+ https://bugs.webkit.org/show_bug.cgi?id=117892
+
+ Reviewed by Chris Fleizach.
+
+ * accessibility/listitem-title.html: Added.
+ * platform/mac/accessibility/listitem-title-expected.txt: Added.
+ * platform/win/accessibility/listitem-title-expected.txt: Added.
+
2013-06-21 Robert Hogan <[email protected]>
Ignoring padding-right of inline elements in containers with undefined width
Added: trunk/LayoutTests/accessibility/listitem-title.html (0 => 151868)
--- trunk/LayoutTests/accessibility/listitem-title.html (rev 0)
+++ trunk/LayoutTests/accessibility/listitem-title.html 2013-06-21 23:39:41 UTC (rev 151868)
@@ -0,0 +1,34 @@
+<!DOCTYPE html>
+<html>
+<script>
+ if (window.testRunner)
+ testRunner.dumpAsText();
+</script>
+<body id="body">
+
+ <ul>
+ <li><span class="a">test</span><span class="b">1</span></li>
+ <li id="test b"><span class="a">test</span><span class="b">2</span></li>
+ </ul>
+
+ <ol>
+ <li id="test a"><span class="a">test</span><span class="b">1</span></li>
+ <li><span class="a">test</span><span class="b">2</span></li>
+ </ol>
+
+ <BR><BR><BR><hr><BR>
+ <div id="result"></div>
+
+ <script>
+ if (window.accessibilityController) {
+ var result = document.getElementById("result");
+
+ var ulListElement = window.accessibilityController.accessibleElementById("test a");
+ result.innerText += 'il in ul title: ' + ulListElement.title + "\n\n";
+
+ var olListElement = window.accessibilityController.accessibleElementById("test b");
+ result.innerText += 'il in ol title: ' + olListElement.title + "\n\n";
+ }
+ </script>
+</body>
+</html>
Added: trunk/LayoutTests/platform/mac/listitem-title-actual.txt (0 => 151868)
--- trunk/LayoutTests/platform/mac/listitem-title-actual.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/listitem-title-actual.txt 2013-06-21 23:39:41 UTC (rev 151868)
@@ -0,0 +1,13 @@
+test1
+test2
+test1
+test2
+
+
+
+
+il in ul title: AXTitle: test 1
+
+il in ol title: AXTitle: test 2
+
+
Added: trunk/LayoutTests/platform/win/accessibility/listitem-title-expected.txt (0 => 151868)
--- trunk/LayoutTests/platform/win/accessibility/listitem-title-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/win/accessibility/listitem-title-expected.txt 2013-06-21 23:39:41 UTC (rev 151868)
@@ -0,0 +1,13 @@
+test1
+test2
+test1
+test2
+
+
+
+
+il in ul title: test 1
+
+il in ol title: test 2
+
+
Modified: trunk/Source/WebCore/ChangeLog (151867 => 151868)
--- trunk/Source/WebCore/ChangeLog 2013-06-21 23:28:01 UTC (rev 151867)
+++ trunk/Source/WebCore/ChangeLog 2013-06-21 23:39:41 UTC (rev 151868)
@@ -1,3 +1,17 @@
+2013-06-21 Brent Fulgham <[email protected]>
+
+ AX: Title for ListItemRole should consist of concatenated child text elements.
+ https://bugs.webkit.org/show_bug.cgi?id=117892
+
+ Reviewed by Chris Fleizach.
+
+ accessibility/listitem-title.html
+
+ * accessibility/AccessibilityNodeObject.cpp:
+ (WebCore::AccessibilityNodeObject::visibleText): Add ListItemRole to set of
+ elements that concatenate their children for display purposes.
+ (WebCore::AccessibilityNodeObject::title): Ditto.
+
2013-06-21 Sergio Correia <[email protected]>
[MediaStream]: Remove ``>= 0'' assertion from a size_t variable
Modified: trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp (151867 => 151868)
--- trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2013-06-21 23:28:01 UTC (rev 151867)
+++ trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2013-06-21 23:39:41 UTC (rev 151868)
@@ -1261,6 +1261,7 @@
case ToggleButtonRole:
case CheckBoxRole:
case ListBoxOptionRole:
+ case ListItemRole:
case MenuButtonRole:
case MenuItemRole:
case RadioButtonRole:
@@ -1605,6 +1606,7 @@
case ToggleButtonRole:
case CheckBoxRole:
case ListBoxOptionRole:
+ case ListItemRole:
case MenuButtonRole:
case MenuItemRole:
case RadioButtonRole:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
