Title: [151909] trunk/Source/WebCore
Revision
151909
Author
par...@webkit.org
Date
2013-06-24 07:16:42 -0700 (Mon, 24 Jun 2013)

Log Message

Use SetFilePointer instead of SetFilePointerEx in FileSystemWin
https://bugs.webkit.org/show_bug.cgi?id=116205

Reviewed by Ryosuke Niwa.

SetFilePointerEx is not available on Windows CE, so use SetFilePointer.
Also add a extra return for the case of an failure.

* platform/win/FileSystemWin.cpp:
(WebCore::seekFile):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (151908 => 151909)


--- trunk/Source/WebCore/ChangeLog	2013-06-24 14:07:53 UTC (rev 151908)
+++ trunk/Source/WebCore/ChangeLog	2013-06-24 14:16:42 UTC (rev 151909)
@@ -1,3 +1,16 @@
+2013-06-24  Patrick Gansterer  <par...@webkit.org>
+
+        Use SetFilePointer instead of SetFilePointerEx in FileSystemWin
+        https://bugs.webkit.org/show_bug.cgi?id=116205
+
+        Reviewed by Ryosuke Niwa.
+
+        SetFilePointerEx is not available on Windows CE, so use SetFilePointer.
+        Also add a extra return for the case of an failure.
+
+        * platform/win/FileSystemWin.cpp:
+        (WebCore::seekFile):
+
 2013-06-24  Christophe Dumez  <ch.du...@sisa.samsung.com>
 
         Introduce WindowTimers IDL interface

Modified: trunk/Source/WebCore/platform/win/FileSystemWin.cpp (151908 => 151909)


--- trunk/Source/WebCore/platform/win/FileSystemWin.cpp	2013-06-24 14:07:53 UTC (rev 151908)
+++ trunk/Source/WebCore/platform/win/FileSystemWin.cpp	2013-06-24 14:16:42 UTC (rev 151909)
@@ -359,12 +359,12 @@
     LARGE_INTEGER largeOffset;
     largeOffset.QuadPart = offset;
 
-    LARGE_INTEGER newOffset;
-    newOffset.QuadPart = 0;
+    largeOffset.LowPart = SetFilePointer(handle, largeOffset.LowPart, &largeOffset.HighPart, moveMethod);
 
-    SetFilePointerEx(handle, largeOffset, &newOffset, moveMethod);
+    if (largeOffset.LowPart == INVALID_SET_FILE_POINTER && GetLastError() != NO_ERROR)
+        return -1;
 
-    return newOffset.QuadPart;
+    return largeOffset.QuadPart;
 }
 
 int writeToFile(PlatformFileHandle handle, const char* data, int length)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to