Title: [151956] trunk/Source/WebCore
Revision
151956
Author
[email protected]
Date
2013-06-24 23:28:00 -0700 (Mon, 24 Jun 2013)

Log Message

Update AbstractWorker, Worker and SharedWorker to match the specification
https://bugs.webkit.org/show_bug.cgi?id=117930

Reviewed by Kentaro Hara.

Update AbstractWorker, Worker and SharedWorker to match the spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#abstractworker
http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#worker
http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#sharedworker

Worker and SharedWorker no longer inherit from AbstractWorker. Web IDL 'implements'
statements are used instead. Worker and SharedWorker can now inherit from EventTarget
as per the specification.

No new tests, no behavior change.

* workers/AbstractWorker.idl:
* workers/SharedWorker.idl:
* workers/Worker.idl:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (151955 => 151956)


--- trunk/Source/WebCore/ChangeLog	2013-06-25 05:58:25 UTC (rev 151955)
+++ trunk/Source/WebCore/ChangeLog	2013-06-25 06:28:00 UTC (rev 151956)
@@ -1,3 +1,25 @@
+2013-06-24  Christophe Dumez  <[email protected]>
+
+        Update AbstractWorker, Worker and SharedWorker to match the specification
+        https://bugs.webkit.org/show_bug.cgi?id=117930
+
+        Reviewed by Kentaro Hara.
+
+        Update AbstractWorker, Worker and SharedWorker to match the spec:
+        http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#abstractworker
+        http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#worker
+        http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#sharedworker
+
+        Worker and SharedWorker no longer inherit from AbstractWorker. Web IDL 'implements'
+        statements are used instead. Worker and SharedWorker can now inherit from EventTarget
+        as per the specification.
+
+        No new tests, no behavior change.
+
+        * workers/AbstractWorker.idl:
+        * workers/SharedWorker.idl:
+        * workers/Worker.idl:
+
 2013-06-24  Andy Estes  <[email protected]>
 
         DerivedSources.make should optionally include SupplementalDependencies.dep

Modified: trunk/Source/WebCore/workers/AbstractWorker.idl (151955 => 151956)


--- trunk/Source/WebCore/workers/AbstractWorker.idl	2013-06-25 05:58:25 UTC (rev 151955)
+++ trunk/Source/WebCore/workers/AbstractWorker.idl	2013-06-25 06:28:00 UTC (rev 151956)
@@ -32,19 +32,7 @@
 [
     NoInterfaceObject,
     Conditional=WORKERS,
-    ActiveDOMObject,
-    CustomToJSObject,
-    EventTarget
 ] interface AbstractWorker {
-
     attribute EventListener onerror;
-
-    void addEventListener(DOMString type,
-                          EventListener listener,
-                          optional boolean useCapture);
-    void removeEventListener(DOMString type,
-                             EventListener listener,
-                             optional boolean useCapture);
-    [RaisesException] boolean dispatchEvent(Event evt);
 };
 

Modified: trunk/Source/WebCore/workers/SharedWorker.idl (151955 => 151956)


--- trunk/Source/WebCore/workers/SharedWorker.idl	2013-06-25 05:58:25 UTC (rev 151955)
+++ trunk/Source/WebCore/workers/SharedWorker.idl	2013-06-25 06:28:00 UTC (rev 151956)
@@ -35,8 +35,11 @@
     CustomConstructor(DOMString scriptURL, [Default=NullString] optional DOMString name),
     JSCustomMarkFunction,
     JSGenerateToNativeObject,
-    JSGenerateToJSObject
-] interface SharedWorker : AbstractWorker {
+    JSGenerateToJSObject,
+    ActiveDOMObject
+] interface SharedWorker : EventTarget {
     readonly attribute MessagePort port;
 };
 
+SharedWorker implements AbstractWorker;
+

Modified: trunk/Source/WebCore/workers/Worker.idl (151955 => 151956)


--- trunk/Source/WebCore/workers/Worker.idl	2013-06-25 05:58:25 UTC (rev 151955)
+++ trunk/Source/WebCore/workers/Worker.idl	2013-06-25 06:28:00 UTC (rev 151956)
@@ -29,8 +29,9 @@
     Conditional=WORKERS,
     CustomConstructor(DOMString scriptUrl),
     JSGenerateToNativeObject,
-    JSGenerateToJSObject
-] interface Worker : AbstractWorker {
+    JSGenerateToJSObject,
+    ActiveDOMObject
+] interface Worker : EventTarget {
 
     attribute EventListener onmessage;
 
@@ -44,3 +45,5 @@
     void terminate();
 };
 
+Worker implements AbstractWorker;
+
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to