Title: [152150] trunk/Source/WebCore
- Revision
- 152150
- Author
- [email protected]
- Date
- 2013-06-27 19:28:21 -0700 (Thu, 27 Jun 2013)
Log Message
HTMLAudioElement doesn't have to know about isVideo function
https://bugs.webkit.org/show_bug.cgi?id=118116
Reviewed by Eric Carlson.
Minor code cleanup to remove isVideo function from HTMLAudioElement.
We can use default function in HTMLMediaElement as hasVideo does.
* html/HTMLAudioElement.h:
* html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::isVideo):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (152149 => 152150)
--- trunk/Source/WebCore/ChangeLog 2013-06-28 02:26:41 UTC (rev 152149)
+++ trunk/Source/WebCore/ChangeLog 2013-06-28 02:28:21 UTC (rev 152150)
@@ -1,5 +1,19 @@
2013-06-27 Kangil Han <[email protected]>
+ HTMLAudioElement doesn't have to know about isVideo function
+ https://bugs.webkit.org/show_bug.cgi?id=118116
+
+ Reviewed by Eric Carlson.
+
+ Minor code cleanup to remove isVideo function from HTMLAudioElement.
+ We can use default function in HTMLMediaElement as hasVideo does.
+
+ * html/HTMLAudioElement.h:
+ * html/HTMLMediaElement.h:
+ (WebCore::HTMLMediaElement::isVideo):
+
+2013-06-27 Kangil Han <[email protected]>
+
Adopt is/toHTMLInputElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118130
Modified: trunk/Source/WebCore/html/HTMLAudioElement.h (152149 => 152150)
--- trunk/Source/WebCore/html/HTMLAudioElement.h 2013-06-28 02:26:41 UTC (rev 152149)
+++ trunk/Source/WebCore/html/HTMLAudioElement.h 2013-06-28 02:28:21 UTC (rev 152150)
@@ -41,8 +41,6 @@
private:
HTMLAudioElement(const QualifiedName&, Document*, bool);
-
- virtual bool isVideo() const { return false; }
};
inline bool isHTMLAudioElement(Node* node)
Modified: trunk/Source/WebCore/html/HTMLMediaElement.h (152149 => 152150)
--- trunk/Source/WebCore/html/HTMLMediaElement.h 2013-06-28 02:26:41 UTC (rev 152149)
+++ trunk/Source/WebCore/html/HTMLMediaElement.h 2013-06-28 02:28:21 UTC (rev 152150)
@@ -101,7 +101,7 @@
public:
MediaPlayer* player() const { return m_player.get(); }
- virtual bool isVideo() const = 0;
+ virtual bool isVideo() const { return false; }
virtual bool hasVideo() const { return false; }
virtual bool hasAudio() const;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
