Title: [152166] trunk/Source/WebKit2
Revision
152166
Author
[email protected]
Date
2013-06-28 08:00:52 -0700 (Fri, 28 Jun 2013)

Log Message

Don't fire process-became-responsive callback when disconnecting it.
<http://webkit.org/b/118166>

Reviewed by Anders Carlsson.

When disconnecting from a web process, call ResponsivenessTimer::invalidate() instead of
stop() to avoid firing the didBecomeResponsive() callback.

This lets the UI process react faster to actually unresponsive processes.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::disconnect):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (152165 => 152166)


--- trunk/Source/WebKit2/ChangeLog	2013-06-28 14:49:24 UTC (rev 152165)
+++ trunk/Source/WebKit2/ChangeLog	2013-06-28 15:00:52 UTC (rev 152166)
@@ -1,3 +1,18 @@
+2013-06-28  Andreas Kling  <[email protected]>
+
+        Don't fire process-became-responsive callback when disconnecting it.
+        <http://webkit.org/b/118166>
+
+        Reviewed by Anders Carlsson.
+
+        When disconnecting from a web process, call ResponsivenessTimer::invalidate() instead of
+        stop() to avoid firing the didBecomeResponsive() callback.
+
+        This lets the UI process react faster to actually unresponsive processes.
+
+        * UIProcess/WebProcessProxy.cpp:
+        (WebKit::WebProcessProxy::disconnect):
+
 2013-06-28  Sergio Villar Senin  <[email protected]>
 
         [WK2][GTK] 100% CPU usage rendering a page with animations

Modified: trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp (152165 => 152166)


--- trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp	2013-06-28 14:49:24 UTC (rev 152165)
+++ trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp	2013-06-28 15:00:52 UTC (rev 152166)
@@ -146,7 +146,7 @@
         m_webConnection = nullptr;
     }
 
-    m_responsivenessTimer.stop();
+    m_responsivenessTimer.invalidate();
 
     Vector<RefPtr<WebFrameProxy>> frames;
     copyValuesToVector(m_frameMap, frames);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to