Title: [152195] trunk/Tools
- Revision
- 152195
- Author
- [email protected]
- Date
- 2013-06-28 16:40:09 -0700 (Fri, 28 Jun 2013)
Log Message
[Mac] Newer versions of clang use a default template instantiation depth that is too small for TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=118208
Reviewed by Mark Rowe.
Newer versions of clang use a default template depth of 128, but this
is too small for Tests/WTF/HashSet.cpp. Use 256 instead, which was the
previous default.
Clang lowered the default to keep recursive template instantiation
from overflowing the stack (see <rdar://problem/13935016>), but
TestWebKitAPI's C++ files don't trigger a stack overflow even with the
higher limit. If for some reason this starts happening then we can
lower the limit back down.
* TestWebKitAPI/Configurations/Base.xcconfig: Build TestWebKitAPI with -ftemplate-depth=256.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (152194 => 152195)
--- trunk/Tools/ChangeLog 2013-06-28 23:11:39 UTC (rev 152194)
+++ trunk/Tools/ChangeLog 2013-06-28 23:40:09 UTC (rev 152195)
@@ -1,3 +1,22 @@
+2013-06-28 Andy Estes <[email protected]>
+
+ [Mac] Newer versions of clang use a default template instantiation depth that is too small for TestWebKitAPI
+ https://bugs.webkit.org/show_bug.cgi?id=118208
+
+ Reviewed by Mark Rowe.
+
+ Newer versions of clang use a default template depth of 128, but this
+ is too small for Tests/WTF/HashSet.cpp. Use 256 instead, which was the
+ previous default.
+
+ Clang lowered the default to keep recursive template instantiation
+ from overflowing the stack (see <rdar://problem/13935016>), but
+ TestWebKitAPI's C++ files don't trigger a stack overflow even with the
+ higher limit. If for some reason this starts happening then we can
+ lower the limit back down.
+
+ * TestWebKitAPI/Configurations/Base.xcconfig: Build TestWebKitAPI with -ftemplate-depth=256.
+
2013-06-28 Nick Diego Yamane <[email protected]>
[Tools] Add support for "webKitBranchBuild" git option when calculating jhbuildPath
Modified: trunk/Tools/TestWebKitAPI/Configurations/Base.xcconfig (152194 => 152195)
--- trunk/Tools/TestWebKitAPI/Configurations/Base.xcconfig 2013-06-28 23:11:39 UTC (rev 152194)
+++ trunk/Tools/TestWebKitAPI/Configurations/Base.xcconfig 2013-06-28 23:40:09 UTC (rev 152195)
@@ -43,6 +43,7 @@
GCC_WARN_UNUSED_VARIABLE = YES
WARNING_CFLAGS = -Wall -W -Wno-unused-parameter
LINKER_DISPLAYS_MANGLED_NAMES = YES;
+OTHER_CPLUSPLUSFLAGS = $(OTHER_CPLUSPLUSFLAGS) -ftemplate-depth=256;
// DEBUG_DEFINES, GCC_OPTIMIZATION_LEVEL, STRIP_INSTALLED_PRODUCT and DEAD_CODE_STRIPPING vary between the debug and normal variants.
// We set up the values for each variant here, and have the Debug configuration in the Xcode project use the _debug variant.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
