Title: [152233] trunk/WebKitLibraries
Revision
152233
Author
[email protected]
Date
2013-07-01 11:12:31 -0700 (Mon, 01 Jul 2013)

Log Message

[Windows] Unreviewed correction to DEBUG_ALL target.  Target was undefining DEBUG_ALL and DEBUG_INTERNAL,
which prevented proper build operation.

* win/tools/vsprops/debugsuffix.props: We should DEFINE (not UNDEFINE) the DEBUG_ALL and DEBUG_INTERNAL
macros when building with 'debugsuffix' target.

Modified Paths

Diff

Modified: trunk/WebKitLibraries/ChangeLog (152232 => 152233)


--- trunk/WebKitLibraries/ChangeLog	2013-07-01 18:04:34 UTC (rev 152232)
+++ trunk/WebKitLibraries/ChangeLog	2013-07-01 18:12:31 UTC (rev 152233)
@@ -1,3 +1,11 @@
+2013-07-01  Brent Fulgham  <[email protected]>
+
+        [Windows] Unreviewed correction to DEBUG_ALL target.  Target was undefining DEBUG_ALL and DEBUG_INTERNAL,
+        which prevented proper build operation.
+
+        * win/tools/vsprops/debugsuffix.props: We should DEFINE (not UNDEFINE) the DEBUG_ALL and DEBUG_INTERNAL
+        macros when building with 'debugsuffix' target.
+
 2013-06-18  Roger Fong  <[email protected]>
 
         Replace tools32 folder with tools and update WebKit Windows solution accordingly.

Modified: trunk/WebKitLibraries/win/tools/vsprops/debugsuffix.props (152232 => 152233)


--- trunk/WebKitLibraries/win/tools/vsprops/debugsuffix.props	2013-07-01 18:04:34 UTC (rev 152232)
+++ trunk/WebKitLibraries/win/tools/vsprops/debugsuffix.props	2013-07-01 18:12:31 UTC (rev 152233)
@@ -8,16 +8,18 @@
     <TargetName>$(TargetName)$(DebugSuffix)</TargetName>
   </PropertyGroup>
   <ItemDefinitionGroup>
-    <ClCompile>
-      <UndefinePreprocessorDefinitions>DEBUG_INTERNAL;DEBUG_ALL;%(UndefinePreprocessorDefinitions)</UndefinePreprocessorDefinitions>
-    </ClCompile>
+    <ClCompile />
     <Lib>
       <OutputFile>$(OutDir)\$(ProjectName)$(DebugSuffix).lib</OutputFile>
     </Lib>
+    <ClCompile>
+      <PreprocessorDefinitions>DEBUG_INTERNAL;DEBUG_ALL;%(PreprocessorDefinitions)</PreprocessorDefinitions>
+    </ClCompile>
   </ItemDefinitionGroup>
   <ItemGroup>
     <BuildMacro Include="DebugSuffix">
       <Value>$(DebugSuffix)</Value>
+      <EnvironmentVariable>true</EnvironmentVariable>
     </BuildMacro>
   </ItemGroup>
 </Project>
\ No newline at end of file
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to