Title: [152317] trunk/Source/WebKit2
- Revision
- 152317
- Author
- [email protected]
- Date
- 2013-07-02 13:07:22 -0700 (Tue, 02 Jul 2013)
Log Message
security/block-test.html fails when NetworkProcess is enabled
https://bugs.webkit.org/show_bug.cgi?id=118320
<rdar://problem/14309423>
Reviewed by Geoff Garen.
* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::wasBlocked):
(WebKit::NetworkResourceLoader::cannotShowURL):
Implemented missing ResourceHandleClient functions.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (152316 => 152317)
--- trunk/Source/WebKit2/ChangeLog 2013-07-02 19:51:47 UTC (rev 152316)
+++ trunk/Source/WebKit2/ChangeLog 2013-07-02 20:07:22 UTC (rev 152317)
@@ -1,3 +1,16 @@
+2013-07-02 Alexey Proskuryakov <[email protected]>
+
+ security/block-test.html fails when NetworkProcess is enabled
+ https://bugs.webkit.org/show_bug.cgi?id=118320
+ <rdar://problem/14309423>
+
+ Reviewed by Geoff Garen.
+
+ * NetworkProcess/NetworkResourceLoader.cpp:
+ (WebKit::NetworkResourceLoader::wasBlocked):
+ (WebKit::NetworkResourceLoader::cannotShowURL):
+ Implemented missing ResourceHandleClient functions.
+
2013-07-02 Ada Chan <[email protected]>
Fix crash when PageBanner::detachFromPage() is called from WebPage::~WebPage().
Modified: trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp (152316 => 152317)
--- trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp 2013-07-02 19:51:47 UTC (rev 152316)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp 2013-07-02 20:07:22 UTC (rev 152317)
@@ -40,6 +40,7 @@
#include "ShareableResource.h"
#include "SharedMemory.h"
#include "WebCoreArgumentCoders.h"
+#include "WebErrors.h"
#include "WebResourceLoaderMessages.h"
#include <WebCore/NotImplemented.h>
#include <WebCore/ResourceBuffer.h>
@@ -239,17 +240,18 @@
send(Messages::WebResourceLoader::DidSendData(bytesSent, totalBytesToBeSent));
}
-// FIXME (NetworkProcess): Many of the following ResourceHandleClient methods definitely need implementations. A few will not.
-// Once we know what they are they can be removed.
+void NetworkResourceLoader::wasBlocked(ResourceHandle* handle)
+{
+ ASSERT_UNUSED(handle, handle == m_handle);
-void NetworkResourceLoader::wasBlocked(ResourceHandle*)
-{
- notImplemented();
+ didFail(handle, WebKit::blockedError(request()));
}
-void NetworkResourceLoader::cannotShowURL(ResourceHandle*)
+void NetworkResourceLoader::cannotShowURL(ResourceHandle* handle)
{
- notImplemented();
+ ASSERT_UNUSED(handle, handle == m_handle);
+
+ didFail(handle, WebKit::cannotShowURLError(request()));
}
bool NetworkResourceLoader::shouldUseCredentialStorage(ResourceHandle* handle)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
