Title: [152370] branches/safari-537-branch/Tools
Revision
152370
Author
[email protected]
Date
2013-07-03 11:40:19 -0700 (Wed, 03 Jul 2013)

Log Message

Merged r152195.

Modified Paths

Diff

Modified: branches/safari-537-branch/Tools/ChangeLog (152369 => 152370)


--- branches/safari-537-branch/Tools/ChangeLog	2013-07-03 18:06:00 UTC (rev 152369)
+++ branches/safari-537-branch/Tools/ChangeLog	2013-07-03 18:40:19 UTC (rev 152370)
@@ -1,3 +1,27 @@
+2013-07-03  Alexey Proskuryakov  <[email protected]>
+
+        Merge r152195.
+
+    2013-06-28  Andy Estes  <[email protected]>
+
+            [Mac] Newer versions of clang use a default template instantiation depth that is too small for TestWebKitAPI
+            https://bugs.webkit.org/show_bug.cgi?id=118208
+
+            Reviewed by Mark Rowe.
+
+            Newer versions of clang use a default template depth of 128, but this
+            is too small for Tests/WTF/HashSet.cpp. Use 256 instead, which was the
+            previous default.
+
+            Clang lowered the default to keep recursive template instantiation
+            from overflowing the stack (see <rdar://problem/13935016>), but
+            TestWebKitAPI's C++ files don't trigger a stack overflow even with the
+            higher limit. If for some reason this starts happening then we can
+            lower the limit back down.
+
+            * TestWebKitAPI/Configurations/Base.xcconfig: Build TestWebKitAPI with -ftemplate-depth=256.
+
+
 2013-07-01  Lucas Forschler  <[email protected]>
 
         Merge r152265

Modified: branches/safari-537-branch/Tools/TestWebKitAPI/Configurations/Base.xcconfig (152369 => 152370)


--- branches/safari-537-branch/Tools/TestWebKitAPI/Configurations/Base.xcconfig	2013-07-03 18:06:00 UTC (rev 152369)
+++ branches/safari-537-branch/Tools/TestWebKitAPI/Configurations/Base.xcconfig	2013-07-03 18:40:19 UTC (rev 152370)
@@ -43,6 +43,7 @@
 GCC_WARN_UNUSED_VARIABLE = YES
 WARNING_CFLAGS = -Wall -W -Wno-unused-parameter
 LINKER_DISPLAYS_MANGLED_NAMES = YES;
+OTHER_CPLUSPLUSFLAGS = $(OTHER_CPLUSPLUSFLAGS) -ftemplate-depth=256;
 
 // DEBUG_DEFINES, GCC_OPTIMIZATION_LEVEL, STRIP_INSTALLED_PRODUCT and DEAD_CODE_STRIPPING vary between the debug and normal variants.
 // We set up the values for each variant here, and have the Debug configuration in the Xcode project use the _debug variant.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to