Title: [152398] trunk/Source/WebCore
- Revision
- 152398
- Author
- [email protected]
- Date
- 2013-07-04 06:18:13 -0700 (Thu, 04 Jul 2013)
Log Message
[GTK] Leak: Free PangoFontDescription* in RenderThemeGtk3
https://bugs.webkit.org/show_bug.cgi?id=118386
Patch by Brian Holt <[email protected]> on 2013-07-04
Reviewed by Carlos Garcia Campos.
Free PangoFontDescription* allocated by gtk_style_context_get (transfer full).
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::spinButtonArrowSize):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (152397 => 152398)
--- trunk/Source/WebCore/ChangeLog 2013-07-04 12:10:45 UTC (rev 152397)
+++ trunk/Source/WebCore/ChangeLog 2013-07-04 13:18:13 UTC (rev 152398)
@@ -1,5 +1,17 @@
2013-07-04 Brian Holt <[email protected]>
+ [GTK] Leak: Free PangoFontDescription* in RenderThemeGtk3
+ https://bugs.webkit.org/show_bug.cgi?id=118386
+
+ Reviewed by Carlos Garcia Campos.
+
+ Free PangoFontDescription* allocated by gtk_style_context_get (transfer full).
+
+ * platform/gtk/RenderThemeGtk3.cpp:
+ (WebCore::spinButtonArrowSize):
+
+2013-07-04 Brian Holt <[email protected]>
+
[ATK] Leak: AtkAttributeSet* should be freed
https://bugs.webkit.org/show_bug.cgi?id=118307
Modified: trunk/Source/WebCore/platform/gtk/RenderThemeGtk3.cpp (152397 => 152398)
--- trunk/Source/WebCore/platform/gtk/RenderThemeGtk3.cpp 2013-07-04 12:10:45 UTC (rev 152397)
+++ trunk/Source/WebCore/platform/gtk/RenderThemeGtk3.cpp 2013-07-04 13:18:13 UTC (rev 152398)
@@ -763,10 +763,11 @@
static gint spinButtonArrowSize(GtkStyleContext* context)
{
- const PangoFontDescription* fontDescription;
+ PangoFontDescription* fontDescription;
gtk_style_context_get(context, static_cast<GtkStateFlags>(0), "font", &fontDescription, NULL);
gint fontSize = pango_font_description_get_size(fontDescription);
gint arrowSize = max(PANGO_PIXELS(fontSize), minSpinButtonArrowSize);
+ pango_font_description_free(fontDescription);
return arrowSize - arrowSize % 2; // Force even.
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
