Title: [152410] trunk/Source/WebKit2
- Revision
- 152410
- Author
- [email protected]
- Date
- 2013-07-05 01:41:34 -0700 (Fri, 05 Jul 2013)
Log Message
TestWebKitFaviconDatabase/clear-database is not testing things properly
https://bugs.webkit.org/show_bug.cgi?id=118404
Patch by Xabier Rodriguez Calvar <[email protected]> on 2013-07-05
Reviewed by Carlos Garcia Campos.
* UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp:
(testClearDatabase): Check for an existing icon that can make the
test fail if clear database is not working.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (152409 => 152410)
--- trunk/Source/WebKit2/ChangeLog 2013-07-05 07:36:43 UTC (rev 152409)
+++ trunk/Source/WebKit2/ChangeLog 2013-07-05 08:41:34 UTC (rev 152410)
@@ -1,3 +1,14 @@
+2013-07-05 Xabier Rodriguez Calvar <[email protected]>
+
+ TestWebKitFaviconDatabase/clear-database is not testing things properly
+ https://bugs.webkit.org/show_bug.cgi?id=118404
+
+ Reviewed by Carlos Garcia Campos.
+
+ * UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp:
+ (testClearDatabase): Check for an existing icon that can make the
+ test fail if clear database is not working.
+
2013-07-04 Anders Carlsson <[email protected]>
Paint the page background if we haven't received our first update
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp (152409 => 152410)
--- trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp 2013-07-05 07:36:43 UTC (rev 152409)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp 2013-07-05 08:41:34 UTC (rev 152410)
@@ -153,7 +153,7 @@
WebKitFaviconDatabase* database = webkit_web_context_get_favicon_database(test->m_webContext);
webkit_favicon_database_clear(database);
- GOwnPtr<char> iconURI(webkit_favicon_database_get_favicon_uri(database, kServer->getURIForPath("/").data()));
+ GOwnPtr<char> iconURI(webkit_favicon_database_get_favicon_uri(database, kServer->getURIForPath("/foo").data()));
g_assert(!iconURI);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes