Title: [152413] trunk/LayoutTests
- Revision
- 152413
- Author
- [email protected]
- Date
- 2013-07-05 03:26:42 -0700 (Fri, 05 Jul 2013)
Log Message
[New multicol] Change test to follow the pattern of the other tests
https://bugs.webkit.org/show_bug.cgi?id=117698
Patch by Mihai Maerean <[email protected]> on 2013-07-05
Reviewed by Andreas Kling.
Test is a ref test against the old multicol code, like all the other tests in LayoutTests/fast/multicol/newmulticol/
This is a follow up of bug 116614, testing that flow threads don't end up being cloned in region based multi
columns with columns:1 where the only child has column-span:all.
* fast/multicol/newmulticol/direct-child-column-span-all-expected.html: Added.
* fast/multicol/newmulticol/direct-child-column-span-all-expected.txt: Removed.
* fast/multicol/newmulticol/direct-child-column-span-all.html:
Modified Paths
Added Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (152412 => 152413)
--- trunk/LayoutTests/ChangeLog 2013-07-05 10:13:47 UTC (rev 152412)
+++ trunk/LayoutTests/ChangeLog 2013-07-05 10:26:42 UTC (rev 152413)
@@ -1,3 +1,18 @@
+2013-07-05 Mihai Maerean <[email protected]>
+
+ [New multicol] Change test to follow the pattern of the other tests
+ https://bugs.webkit.org/show_bug.cgi?id=117698
+
+ Reviewed by Andreas Kling.
+
+ Test is a ref test against the old multicol code, like all the other tests in LayoutTests/fast/multicol/newmulticol/
+ This is a follow up of bug 116614, testing that flow threads don't end up being cloned in region based multi
+ columns with columns:1 where the only child has column-span:all.
+
+ * fast/multicol/newmulticol/direct-child-column-span-all-expected.html: Added.
+ * fast/multicol/newmulticol/direct-child-column-span-all-expected.txt: Removed.
+ * fast/multicol/newmulticol/direct-child-column-span-all.html:
+
2013-07-05 Denis Nomiyama <[email protected]>
[GTK] fast/text/font-kerning.html fails
Added: trunk/LayoutTests/fast/multicol/newmulticol/direct-child-column-span-all-expected.html (0 => 152413)
--- trunk/LayoutTests/fast/multicol/newmulticol/direct-child-column-span-all-expected.html (rev 0)
+++ trunk/LayoutTests/fast/multicol/newmulticol/direct-child-column-span-all-expected.html 2013-07-05 10:26:42 UTC (rev 152413)
@@ -0,0 +1,17 @@
+<!doctype html>
+<html>
+ <head>
+ <style type="text/css">
+ #article1 { -webkit-columns: 1; }
+ #p1 { -webkit-column-span: all; }
+ </style>
+ </head>
+ <body>
+ <div id="article1">
+ <p id="p1">PASS</p>
+ </div>
+ <div>Test passes if it doesn't crash or assert.</div>
+ <div>Test added as part of <a href="" - [New multicol] Change test to follow the pattern of the other tests</a></div>
+ <div>This is a follow up of <a href="" testing that flow threads don't end up being cloned in region based multi columns with columns:1 where the only child has column-span:all.</div>
+ </body>
+</html>
\ No newline at end of file
Deleted: trunk/LayoutTests/fast/multicol/newmulticol/direct-child-column-span-all-expected.txt (152412 => 152413)
--- trunk/LayoutTests/fast/multicol/newmulticol/direct-child-column-span-all-expected.txt 2013-07-05 10:13:47 UTC (rev 152412)
+++ trunk/LayoutTests/fast/multicol/newmulticol/direct-child-column-span-all-expected.txt 2013-07-05 10:26:42 UTC (rev 152413)
@@ -1,3 +0,0 @@
-PASS
-
-test passes if it doesn't crash or assert.
Modified: trunk/LayoutTests/fast/multicol/newmulticol/direct-child-column-span-all.html (152412 => 152413)
--- trunk/LayoutTests/fast/multicol/newmulticol/direct-child-column-span-all.html 2013-07-05 10:13:47 UTC (rev 152412)
+++ trunk/LayoutTests/fast/multicol/newmulticol/direct-child-column-span-all.html 2013-07-05 10:26:42 UTC (rev 152413)
@@ -7,16 +7,16 @@
</style>
<script type="text/_javascript_">
- if(window.testRunner)
- window.testRunner.dumpAsText();
- if(window.internals)
- internals.settings.setRegionBasedColumnsEnabled(true);
+ if(window.internals)
+ internals.settings.setRegionBasedColumnsEnabled(true);
</script>
</head>
<body>
<div id="article1">
<p id="p1">PASS</p>
</div>
- test passes if it doesn't crash or assert.
+ <div>Test passes if it doesn't crash or assert.</div>
+ <div>Test added as part of <a href="" - [New multicol] Change test to follow the pattern of the other tests</a></div>
+ <div>This is a follow up of <a href="" testing that flow threads don't end up being cloned in region based multi columns with columns:1 where the only child has column-span:all.</div>
</body>
</html>
\ No newline at end of file
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
