Title: [152424] trunk
- Revision
- 152424
- Author
- [email protected]
- Date
- 2013-07-05 14:28:23 -0700 (Fri, 05 Jul 2013)
Log Message
iframe constrained by max-width in full screen
https://bugs.webkit.org/show_bug.cgi?id=118250
Patch by Zalan Bujtas <[email protected]> on 2013-07-05
Reviewed by Antti Koivisto.
Ensure that contents inside iframe can go full screen properly.
Set max-width and max-height values to the default 'none', so that iframes are not
constrained when entering full screen.
Source/WebCore:
Test: fullscreen/full-screen-iframe-with-max-width-height.html
* css/fullscreen.css:
(iframe:-webkit-full-screen):
LayoutTests:
* fullscreen/full-screen-iframe-with-max-width-height-expected.txt: Added.
* fullscreen/full-screen-iframe-with-max-width-height.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (152423 => 152424)
--- trunk/LayoutTests/ChangeLog 2013-07-05 21:03:09 UTC (rev 152423)
+++ trunk/LayoutTests/ChangeLog 2013-07-05 21:28:23 UTC (rev 152424)
@@ -1,3 +1,18 @@
+2013-07-05 Zalan Bujtas <[email protected]>
+
+ iframe constrained by max-width in full screen
+ https://bugs.webkit.org/show_bug.cgi?id=118250
+
+ Reviewed by Antti Koivisto.
+
+ Ensure that contents inside iframe can go full screen properly.
+
+ Set max-width and max-height values to the default 'none', so that iframes are not
+ constrained when entering full screen.
+
+ * fullscreen/full-screen-iframe-with-max-width-height-expected.txt: Added.
+ * fullscreen/full-screen-iframe-with-max-width-height.html: Added.
+
2013-07-05 Eric Carlson <[email protected]>
[Mac] .webkitClosedCaptionsVisible doesn't work with "Automatic" caption mode
Added: trunk/LayoutTests/fullscreen/full-screen-iframe-with-max-width-height-expected.txt (0 => 152424)
--- trunk/LayoutTests/fullscreen/full-screen-iframe-with-max-width-height-expected.txt (rev 0)
+++ trunk/LayoutTests/fullscreen/full-screen-iframe-with-max-width-height-expected.txt 2013-07-05 21:28:23 UTC (rev 152424)
@@ -0,0 +1,4 @@
+
+EVENT(webkitfullscreenchange) TEST(frame.getBoundingClientRect().right == document.body.getBoundingClientRect().right && frame.getBoundingClientRect().bottom == document.body.getBoundingClientRect().bottom) OK
+END OF TEST
+
Added: trunk/LayoutTests/fullscreen/full-screen-iframe-with-max-width-height.html (0 => 152424)
--- trunk/LayoutTests/fullscreen/full-screen-iframe-with-max-width-height.html (rev 0)
+++ trunk/LayoutTests/fullscreen/full-screen-iframe-with-max-width-height.html 2013-07-05 21:28:23 UTC (rev 152424)
@@ -0,0 +1,17 @@
+<body style="margin: 0px;">
+ <iframe id='fullscreenFrame' src='' style='max-width: 10px; max-height: 10px;' frameborder='0' webkitallowfullscreen></iframe>
+ <script src=''></script>
+ <script>
+ var frame = document.getElementById('fullscreenFrame');
+ var testDiv = frame.contentWindow.document.getElementById('testDiv');
+ // Bail out early if the full screen API is not enabled or is missing:
+ if (Element.prototype.webkitRequestFullScreen == undefined) {
+ logResult(false, "Element.prototype.webkitRequestFullScreen == undefined");
+ endTest();
+ } else {
+ // Test if the iframe expands full screen when max-width/max-height are set.
+ waitForEventTestAndEnd(document, 'webkitfullscreenchange', "frame.getBoundingClientRect().right == document.body.getBoundingClientRect().right && frame.getBoundingClientRect().bottom == document.body.getBoundingClientRect().bottom");
+ runWithKeyDown(function(){ testDiv.webkitRequestFullScreen(); });
+ }
+ </script>
+</body>
Modified: trunk/Source/WebCore/ChangeLog (152423 => 152424)
--- trunk/Source/WebCore/ChangeLog 2013-07-05 21:03:09 UTC (rev 152423)
+++ trunk/Source/WebCore/ChangeLog 2013-07-05 21:28:23 UTC (rev 152424)
@@ -1,3 +1,20 @@
+2013-07-05 Zalan Bujtas <[email protected]>
+
+ iframe constrained by max-width in full screen
+ https://bugs.webkit.org/show_bug.cgi?id=118250
+
+ Reviewed by Antti Koivisto.
+
+ Ensure that contents inside iframe can go full screen properly.
+
+ Set max-width and max-height values to the default 'none', so that iframes are not
+ constrained when entering full screen.
+
+ Test: fullscreen/full-screen-iframe-with-max-width-height.html
+
+ * css/fullscreen.css:
+ (iframe:-webkit-full-screen):
+
2013-07-05 Eric Carlson <[email protected]>
[Mac] .webkitClosedCaptionsVisible doesn't work with "Automatic" caption mode
Modified: trunk/Source/WebCore/css/fullscreen.css (152423 => 152424)
--- trunk/Source/WebCore/css/fullscreen.css 2013-07-05 21:03:09 UTC (rev 152423)
+++ trunk/Source/WebCore/css/fullscreen.css 2013-07-05 21:28:23 UTC (rev 152424)
@@ -51,4 +51,6 @@
width: 100% !important;
left: 0 !important;
top: 0 !important;
+ max-width: none !important;
+ max-height: none !important;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
