Title: [152444] trunk/Tools
Revision
152444
Author
[email protected]
Date
2013-07-08 02:00:34 -0700 (Mon, 08 Jul 2013)

Log Message

[GTK] Leak: GFile* leaking in beginDragWithFilesCallback
https://bugs.webkit.org/show_bug.cgi?id=118412

Patch by Brian Holt <[email protected]> on 2013-07-08
Reviewed by Martin Robinson.

An adoptRef is required to balance ref and deref calls.

* DumpRenderTree/gtk/EventSender.cpp:
(beginDragWithFilesCallback):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (152443 => 152444)


--- trunk/Tools/ChangeLog	2013-07-08 08:37:35 UTC (rev 152443)
+++ trunk/Tools/ChangeLog	2013-07-08 09:00:34 UTC (rev 152444)
@@ -1,3 +1,15 @@
+2013-07-08  Brian Holt  <[email protected]>
+
+        [GTK] Leak: GFile* leaking in beginDragWithFilesCallback
+        https://bugs.webkit.org/show_bug.cgi?id=118412
+
+        Reviewed by Martin Robinson.
+
+        An adoptRef is required to balance ref and deref calls.
+
+        * DumpRenderTree/gtk/EventSender.cpp:
+        (beginDragWithFilesCallback):
+
 2013-07-06  Sergio Correia  <[email protected]>
 
         Update list of EFL WK2 API tests

Modified: trunk/Tools/DumpRenderTree/gtk/EventSender.cpp (152443 => 152444)


--- trunk/Tools/DumpRenderTree/gtk/EventSender.cpp	2013-07-08 08:37:35 UTC (rev 152443)
+++ trunk/Tools/DumpRenderTree/gtk/EventSender.cpp	2013-07-08 09:00:34 UTC (rev 152444)
@@ -541,7 +541,7 @@
     GOwnPtr<gchar> scheme(g_file_get_uri_scheme(parentDirectory.get()));
     if (g_str_equal(scheme.get(), "http") || g_str_equal(scheme.get(), "https")) {
         GOwnPtr<gchar> currentDirectory(g_get_current_dir());
-        parentDirectory = g_file_new_for_path(currentDirectory.get());
+        parentDirectory = adoptGRef(g_file_new_for_path(currentDirectory.get()));
     }
 
     JSStringRef lengthProperty = JSStringCreateWithUTF8CString("length");
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to