Title: [152484] trunk/Tools
- Revision
- 152484
- Author
- [email protected]
- Date
- 2013-07-08 23:46:13 -0700 (Mon, 08 Jul 2013)
Log Message
KURL unit test fixture class should have a meaningful name
https://bugs.webkit.org/show_bug.cgi?id=118467
Reviewed by Sam Weinig.
* TestWebKitAPI/Tests/WebCore/KURL.cpp:
(TestWebKitAPI::TEST_F): Use 'KURLTest' as the name for the KURL unit test's fixture class
instead of the generic and inappropriate 'WebCore' name.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (152483 => 152484)
--- trunk/Tools/ChangeLog 2013-07-09 05:39:16 UTC (rev 152483)
+++ trunk/Tools/ChangeLog 2013-07-09 06:46:13 UTC (rev 152484)
@@ -1,3 +1,14 @@
+2013-07-08 Zan Dobersek <[email protected]>
+
+ KURL unit test fixture class should have a meaningful name
+ https://bugs.webkit.org/show_bug.cgi?id=118467
+
+ Reviewed by Sam Weinig.
+
+ * TestWebKitAPI/Tests/WebCore/KURL.cpp:
+ (TestWebKitAPI::TEST_F): Use 'KURLTest' as the name for the KURL unit test's fixture class
+ instead of the generic and inappropriate 'WebCore' name.
+
2013-07-08 Antti Koivisto <[email protected]>
Add Deque::removeLast
Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/KURL.cpp (152483 => 152484)
--- trunk/Tools/TestWebKitAPI/Tests/WebCore/KURL.cpp 2013-07-09 05:39:16 UTC (rev 152483)
+++ trunk/Tools/TestWebKitAPI/Tests/WebCore/KURL.cpp 2013-07-09 06:46:13 UTC (rev 152484)
@@ -32,7 +32,7 @@
namespace TestWebKitAPI {
-class WebCore: public testing::Test {
+class KURLTest : public testing::Test {
public:
virtual void SetUp()
{
@@ -40,7 +40,7 @@
}
};
-TEST_F(WebCore, KURLConstructorDefault)
+TEST_F(KURLTest, KURLConstructorDefault)
{
KURL kurl;
@@ -50,7 +50,7 @@
EXPECT_FALSE(kurl.isValid());
}
-TEST_F(WebCore, KURLConstructorConstChar)
+TEST_F(KURLTest, KURLConstructorConstChar)
{
KURL kurl(ParsedURLString, "http://username:[email protected]:8080/index.html?var=val#fragment");
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
