Title: [152527] trunk/Source/WebCore
Revision
152527
Author
[email protected]
Date
2013-07-10 00:41:42 -0700 (Wed, 10 Jul 2013)

Log Message

Change recently ratified extensions prefixes from WEBKIT_WEBGL_ to WEBGL_
https://bugs.webkit.org/show_bug.cgi?id=117786

Patch by Karol Świniarski <[email protected]> on 2013-07-10
Reviewed by Dean Jackson.

According to WebGL's revision 10, extensions should be named: WEBGL_lose_context,
WEBGL_depth_texture, WEBGL_compressed_texture_s3tc.

No new tests. Covered by existing tests:
LayoutTests/webgl/conformance/extensions/get-extension.html
LayoutTests/webgl/conformance/context/context-lost.html
LayoutTests/webgl/conformance/extensions/webgl-depth-texture.html
LayoutTests/webgl/conformance/extensions/webgl-compressed-texture-s3tc.html

* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (152526 => 152527)


--- trunk/Source/WebCore/ChangeLog	2013-07-10 06:55:46 UTC (rev 152526)
+++ trunk/Source/WebCore/ChangeLog	2013-07-10 07:41:42 UTC (rev 152527)
@@ -1,3 +1,23 @@
+2013-07-10  Karol Świniarski  <[email protected]>
+
+        Change recently ratified extensions prefixes from WEBKIT_WEBGL_ to WEBGL_
+        https://bugs.webkit.org/show_bug.cgi?id=117786
+
+        Reviewed by Dean Jackson.
+
+        According to WebGL's revision 10, extensions should be named: WEBGL_lose_context,
+        WEBGL_depth_texture, WEBGL_compressed_texture_s3tc.
+
+        No new tests. Covered by existing tests:
+        LayoutTests/webgl/conformance/extensions/get-extension.html
+        LayoutTests/webgl/conformance/context/context-lost.html
+        LayoutTests/webgl/conformance/extensions/webgl-depth-texture.html
+        LayoutTests/webgl/conformance/extensions/webgl-compressed-texture-s3tc.html
+
+        * html/canvas/WebGLRenderingContext.cpp:
+        (WebCore::WebGLRenderingContext::getExtension):
+        (WebCore::WebGLRenderingContext::getSupportedExtensions):
+
 2013-07-09  Byungwoo Lee  <[email protected]>
 
         Unreviewed build fix.

Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp (152526 => 152527)


--- trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp	2013-07-10 06:55:46 UTC (rev 152526)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp	2013-07-10 07:41:42 UTC (rev 152527)
@@ -2405,11 +2405,7 @@
         }
         return m_oesElementIndexUint.get();
     }
-    if (equalIgnoringCase(name, "WEBGL_lose_context")
-        // FIXME: remove this after a certain grace period.
-        || equalIgnoringCase(name, "WEBKIT_WEBGL_lose_context")
-        // FIXME: Is it safe to remove WEBKIT_lose_context now?
-        || equalIgnoringCase(name, "WEBKIT_lose_context")) {
+    if (equalIgnoringCase(name, "WEBGL_lose_context")) {
         if (!m_webglLoseContext)
             m_webglLoseContext = WebGLLoseContext::create(this);
         return m_webglLoseContext.get();
@@ -2425,17 +2421,13 @@
         if (!m_webglCompressedTexturePVRTC)
             m_webglCompressedTexturePVRTC = WebGLCompressedTexturePVRTC::create(this);
     }
-    if ((equalIgnoringCase(name, "WEBGL_compressed_texture_s3tc")
-         // FIXME: remove this after a certain grace period.
-         || equalIgnoringCase(name, "WEBKIT_WEBGL_compressed_texture_s3tc"))
+    if (equalIgnoringCase(name, "WEBGL_compressed_texture_s3tc")
         && WebGLCompressedTextureS3TC::supported(this)) {
         if (!m_webglCompressedTextureS3TC)
             m_webglCompressedTextureS3TC = WebGLCompressedTextureS3TC::create(this);
         return m_webglCompressedTextureS3TC.get();
     }
-    if ((equalIgnoringCase(name, "WEBGL_depth_texture")
-        // FIXME: remove this after a certain grace period.
-        || equalIgnoringCase(name, "WEBKIT_WEBGL_depth_texture"))
+    if (equalIgnoringCase(name, "WEBGL_depth_texture")
         && WebGLDepthTexture::supported(graphicsContext3D())) {
         if (!m_webglDepthTexture) {
             m_context->getExtensions()->ensureEnabled("GL_CHROMIUM_depth_texture");
@@ -2958,9 +2950,9 @@
     if (WebGLCompressedTexturePVRTC::supported(this))
         result.append("WEBKIT_WEBGL_compressed_texture_pvrtc");
     if (WebGLCompressedTextureS3TC::supported(this))
-        result.append("WEBKIT_WEBGL_compressed_texture_s3tc");
+        result.append("WEBGL_compressed_texture_s3tc");
     if (WebGLDepthTexture::supported(graphicsContext3D()))
-        result.append("WEBKIT_WEBGL_depth_texture");
+        result.append("WEBGL_depth_texture");
     if (supportsDrawBuffers())
         result.append("EXT_draw_buffers");
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to