Diff
Modified: trunk/LayoutTests/ChangeLog (152531 => 152532)
--- trunk/LayoutTests/ChangeLog 2013-07-10 08:46:19 UTC (rev 152531)
+++ trunk/LayoutTests/ChangeLog 2013-07-10 08:57:30 UTC (rev 152532)
@@ -1,3 +1,17 @@
+2013-07-10 James Craig <[email protected]>
+
+ AX: AccessibilityNodeObject::supportsRequiredAttribute() should switch on CellRole
+ https://bugs.webkit.org/show_bug.cgi?id=117817
+
+ Reviewed by Chris Fleizach.
+
+ CellRole supports the required attribute now for accessibility, according to ARIA spec.
+
+ * platform/mac/accessibility/table-attributes-expected.txt:
+ * platform/mac/accessibility/table-cell-spans-expected.txt:
+ * platform/mac/accessibility/table-cells-expected.txt:
+ * platform/mac/accessibility/table-sections-expected.txt:
+
2013-07-10 Ádám Kallai <[email protected]>
[Qt] Unreviewed gardening.
Modified: trunk/LayoutTests/platform/mac/accessibility/table-attributes-expected.txt (152531 => 152532)
--- trunk/LayoutTests/platform/mac/accessibility/table-attributes-expected.txt 2013-07-10 08:46:19 UTC (rev 152531)
+++ trunk/LayoutTests/platform/mac/accessibility/table-attributes-expected.txt 2013-07-10 08:57:30 UTC (rev 152532)
@@ -32,6 +32,7 @@
AXRowIndexRange: NSRange: {0, 2}
AXColumnIndexRange: NSRange: {0, 2}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -58,6 +59,7 @@
AXRowIndexRange: NSRange: {0, 2}
AXColumnIndexRange: NSRange: {0, 2}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -84,6 +86,7 @@
AXRowIndexRange: NSRange: {0, 2}
AXColumnIndexRange: NSRange: {2, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -110,6 +113,7 @@
AXRowIndexRange: NSRange: {0, 1}
AXColumnIndexRange: NSRange: {3, 2}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -136,6 +140,7 @@
AXRowIndexRange: NSRange: {0, 1}
AXColumnIndexRange: NSRange: {3, 2}
AXARIABusy: 0
+AXRequired: 0
------------
@@ -166,6 +171,7 @@
AXRowIndexRange: NSRange: {0, 2}
AXColumnIndexRange: NSRange: {0, 2}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -192,6 +198,7 @@
AXRowIndexRange: NSRange: {1, 1}
AXColumnIndexRange: NSRange: {3, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -218,6 +225,7 @@
AXRowIndexRange: NSRange: {2, 2}
AXColumnIndexRange: NSRange: {0, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -244,6 +252,7 @@
AXRowIndexRange: NSRange: {3, 1}
AXColumnIndexRange: NSRange: {1, 1}
AXARIABusy: 0
+AXRequired: 0
------------
@@ -522,6 +531,7 @@
AXRowIndexRange: NSRange: {0, 2}
AXColumnIndexRange: NSRange: {0, 2}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -548,6 +558,7 @@
AXRowIndexRange: NSRange: {0, 2}
AXColumnIndexRange: NSRange: {2, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -574,6 +585,7 @@
AXRowIndexRange: NSRange: {0, 1}
AXColumnIndexRange: NSRange: {3, 2}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -600,6 +612,7 @@
AXRowIndexRange: NSRange: {1, 1}
AXColumnIndexRange: NSRange: {3, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -626,6 +639,7 @@
AXRowIndexRange: NSRange: {1, 1}
AXColumnIndexRange: NSRange: {4, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -652,6 +666,7 @@
AXRowIndexRange: NSRange: {2, 2}
AXColumnIndexRange: NSRange: {0, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -678,6 +693,7 @@
AXRowIndexRange: NSRange: {2, 1}
AXColumnIndexRange: NSRange: {1, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -704,6 +720,7 @@
AXRowIndexRange: NSRange: {2, 1}
AXColumnIndexRange: NSRange: {2, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -730,6 +747,7 @@
AXRowIndexRange: NSRange: {2, 1}
AXColumnIndexRange: NSRange: {3, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -756,6 +774,7 @@
AXRowIndexRange: NSRange: {2, 1}
AXColumnIndexRange: NSRange: {4, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -782,6 +801,7 @@
AXRowIndexRange: NSRange: {3, 1}
AXColumnIndexRange: NSRange: {1, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -808,6 +828,7 @@
AXRowIndexRange: NSRange: {3, 1}
AXColumnIndexRange: NSRange: {2, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -834,6 +855,7 @@
AXRowIndexRange: NSRange: {3, 1}
AXColumnIndexRange: NSRange: {3, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -860,6 +882,7 @@
AXRowIndexRange: NSRange: {3, 1}
AXColumnIndexRange: NSRange: {4, 1}
AXARIABusy: 0
+AXRequired: 0
------------
Modified: trunk/LayoutTests/platform/mac/accessibility/table-cell-spans-expected.txt (152531 => 152532)
--- trunk/LayoutTests/platform/mac/accessibility/table-cell-spans-expected.txt 2013-07-10 08:46:19 UTC (rev 152531)
+++ trunk/LayoutTests/platform/mac/accessibility/table-cell-spans-expected.txt 2013-07-10 08:57:30 UTC (rev 152532)
@@ -32,6 +32,7 @@
AXRowIndexRange: NSRange: {0, 2}
AXColumnIndexRange: NSRange: {0, 2}
AXARIABusy: 0
+AXRequired: 0
{0, 2}, {0, 2}
@@ -61,6 +62,7 @@
AXRowIndexRange: NSRange: {0, 2}
AXColumnIndexRange: NSRange: {0, 2}
AXARIABusy: 0
+AXRequired: 0
{0, 2}, {0, 2}
@@ -90,6 +92,7 @@
AXRowIndexRange: NSRange: {2, 2}
AXColumnIndexRange: NSRange: {0, 1}
AXARIABusy: 0
+AXRequired: 0
{2, 2}, {0, 1}
@@ -119,6 +122,7 @@
AXRowIndexRange: NSRange: {2, 2}
AXColumnIndexRange: NSRange: {0, 1}
AXARIABusy: 0
+AXRequired: 0
{2, 2}, {0, 1}
@@ -148,6 +152,7 @@
AXRowIndexRange: NSRange: {2, 1}
AXColumnIndexRange: NSRange: {3, 1}
AXARIABusy: 0
+AXRequired: 0
{2, 1}, {3, 1}
Modified: trunk/LayoutTests/platform/mac/accessibility/table-cells-expected.txt (152531 => 152532)
--- trunk/LayoutTests/platform/mac/accessibility/table-cells-expected.txt 2013-07-10 08:46:19 UTC (rev 152531)
+++ trunk/LayoutTests/platform/mac/accessibility/table-cells-expected.txt 2013-07-10 08:57:30 UTC (rev 152532)
@@ -34,6 +34,7 @@
AXRowIndexRange: NSRange: {0, 2}
AXColumnIndexRange: NSRange: {0, 2}
AXARIABusy: 0
+AXRequired: 0
------------------------
[3,1]
@@ -61,6 +62,7 @@
AXRowIndexRange: NSRange: {1, 1}
AXColumnIndexRange: NSRange: {3, 1}
AXARIABusy: 0
+AXRequired: 0
------------------------
[1,1]
@@ -88,6 +90,7 @@
AXRowIndexRange: NSRange: {0, 2}
AXColumnIndexRange: NSRange: {0, 2}
AXARIABusy: 0
+AXRequired: 0
------------------------
[2,2]
@@ -115,6 +118,7 @@
AXRowIndexRange: NSRange: {2, 1}
AXColumnIndexRange: NSRange: {2, 1}
AXARIABusy: 0
+AXRequired: 0
------------------------
[3,5]
@@ -142,6 +146,7 @@
AXRowIndexRange: NSRange: {5, 1}
AXColumnIndexRange: NSRange: {3, 1}
AXARIABusy: 0
+AXRequired: 0
------------------------
[100,0]
Modified: trunk/LayoutTests/platform/mac/accessibility/table-sections-expected.txt (152531 => 152532)
--- trunk/LayoutTests/platform/mac/accessibility/table-sections-expected.txt 2013-07-10 08:46:19 UTC (rev 152531)
+++ trunk/LayoutTests/platform/mac/accessibility/table-sections-expected.txt 2013-07-10 08:57:30 UTC (rev 152532)
@@ -41,6 +41,7 @@
AXRowIndexRange: NSRange: {0, 1}
AXColumnIndexRange: NSRange: {0, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -67,6 +68,7 @@
AXRowIndexRange: NSRange: {0, 1}
AXColumnIndexRange: NSRange: {1, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -93,6 +95,7 @@
AXRowIndexRange: NSRange: {0, 1}
AXColumnIndexRange: NSRange: {2, 1}
AXARIABusy: 0
+AXRequired: 0
------------
@@ -123,6 +126,7 @@
AXRowIndexRange: NSRange: {0, 1}
AXColumnIndexRange: NSRange: {0, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -149,6 +153,7 @@
AXRowIndexRange: NSRange: {1, 1}
AXColumnIndexRange: NSRange: {0, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -175,6 +180,7 @@
AXRowIndexRange: NSRange: {2, 1}
AXColumnIndexRange: NSRange: {0, 1}
AXARIABusy: 0
+AXRequired: 0
------------
@@ -397,6 +403,7 @@
AXRowIndexRange: NSRange: {0, 1}
AXColumnIndexRange: NSRange: {0, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -423,6 +430,7 @@
AXRowIndexRange: NSRange: {0, 1}
AXColumnIndexRange: NSRange: {1, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -449,6 +457,7 @@
AXRowIndexRange: NSRange: {0, 1}
AXColumnIndexRange: NSRange: {2, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -475,6 +484,7 @@
AXRowIndexRange: NSRange: {1, 1}
AXColumnIndexRange: NSRange: {0, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -501,6 +511,7 @@
AXRowIndexRange: NSRange: {1, 1}
AXColumnIndexRange: NSRange: {1, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -527,6 +538,7 @@
AXRowIndexRange: NSRange: {1, 1}
AXColumnIndexRange: NSRange: {2, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -553,6 +565,7 @@
AXRowIndexRange: NSRange: {2, 1}
AXColumnIndexRange: NSRange: {0, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -579,6 +592,7 @@
AXRowIndexRange: NSRange: {2, 1}
AXColumnIndexRange: NSRange: {1, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -605,6 +619,7 @@
AXRowIndexRange: NSRange: {2, 1}
AXColumnIndexRange: NSRange: {2, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -631,6 +646,7 @@
AXRowIndexRange: NSRange: {3, 1}
AXColumnIndexRange: NSRange: {0, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -657,6 +673,7 @@
AXRowIndexRange: NSRange: {3, 1}
AXColumnIndexRange: NSRange: {1, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -683,6 +700,7 @@
AXRowIndexRange: NSRange: {3, 1}
AXColumnIndexRange: NSRange: {2, 1}
AXARIABusy: 0
+AXRequired: 0
------------
@@ -745,6 +763,7 @@
AXRowIndexRange: NSRange: {0, 1}
AXColumnIndexRange: NSRange: {0, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -771,6 +790,7 @@
AXRowIndexRange: NSRange: {0, 1}
AXColumnIndexRange: NSRange: {1, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -797,6 +817,7 @@
AXRowIndexRange: NSRange: {0, 1}
AXColumnIndexRange: NSRange: {2, 1}
AXARIABusy: 0
+AXRequired: 0
------------
@@ -827,6 +848,7 @@
AXRowIndexRange: NSRange: {0, 1}
AXColumnIndexRange: NSRange: {0, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -853,6 +875,7 @@
AXRowIndexRange: NSRange: {1, 1}
AXColumnIndexRange: NSRange: {0, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -879,6 +902,7 @@
AXRowIndexRange: NSRange: {2, 1}
AXColumnIndexRange: NSRange: {0, 1}
AXARIABusy: 0
+AXRequired: 0
------------
@@ -1101,6 +1125,7 @@
AXRowIndexRange: NSRange: {0, 1}
AXColumnIndexRange: NSRange: {0, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -1127,6 +1152,7 @@
AXRowIndexRange: NSRange: {0, 1}
AXColumnIndexRange: NSRange: {1, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -1153,6 +1179,7 @@
AXRowIndexRange: NSRange: {0, 1}
AXColumnIndexRange: NSRange: {2, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -1179,6 +1206,7 @@
AXRowIndexRange: NSRange: {1, 1}
AXColumnIndexRange: NSRange: {0, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -1205,6 +1233,7 @@
AXRowIndexRange: NSRange: {1, 1}
AXColumnIndexRange: NSRange: {1, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -1231,6 +1260,7 @@
AXRowIndexRange: NSRange: {1, 1}
AXColumnIndexRange: NSRange: {2, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -1257,6 +1287,7 @@
AXRowIndexRange: NSRange: {2, 1}
AXColumnIndexRange: NSRange: {0, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -1283,6 +1314,7 @@
AXRowIndexRange: NSRange: {2, 1}
AXColumnIndexRange: NSRange: {1, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -1309,6 +1341,7 @@
AXRowIndexRange: NSRange: {2, 1}
AXColumnIndexRange: NSRange: {2, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -1335,6 +1368,7 @@
AXRowIndexRange: NSRange: {3, 1}
AXColumnIndexRange: NSRange: {0, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -1361,6 +1395,7 @@
AXRowIndexRange: NSRange: {3, 1}
AXColumnIndexRange: NSRange: {1, 1}
AXARIABusy: 0
+AXRequired: 0
------------
AXRole: AXCell
@@ -1387,6 +1422,7 @@
AXRowIndexRange: NSRange: {3, 1}
AXColumnIndexRange: NSRange: {2, 1}
AXARIABusy: 0
+AXRequired: 0
------------
Modified: trunk/Source/WebCore/ChangeLog (152531 => 152532)
--- trunk/Source/WebCore/ChangeLog 2013-07-10 08:46:19 UTC (rev 152531)
+++ trunk/Source/WebCore/ChangeLog 2013-07-10 08:57:30 UTC (rev 152532)
@@ -1,3 +1,16 @@
+2013-07-10 James Craig <[email protected]>
+
+ AX: AccessibilityNodeObject::supportsRequiredAttribute() should switch on CellRole
+ https://bugs.webkit.org/show_bug.cgi?id=117817
+
+ Reviewed by Chris Fleizach.
+
+ CellRole supports the required attribute now for accessibility, according to ARIA spec.
+ Updated existing test coverage.
+
+ * accessibility/AccessibilityNodeObject.cpp:
+ (WebCore::AccessibilityNodeObject::supportsRequiredAttribute):
+
2013-07-10 Csaba Osztrogonác <[email protected]>
REGRESSION(r151957): WebGL textures do not show
Modified: trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp (152531 => 152532)
--- trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2013-07-10 08:46:19 UTC (rev 152531)
+++ trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2013-07-10 08:57:30 UTC (rev 152532)
@@ -721,6 +721,7 @@
bool AccessibilityNodeObject::supportsRequiredAttribute() const
{
switch (roleValue()) {
+ case CellRole:
case CheckBoxRole:
case ComboBoxRole:
case GridRole:
