Title: [152560] trunk/Tools
Revision
152560
Author
[email protected]
Date
2013-07-11 00:00:10 -0700 (Thu, 11 Jul 2013)

Log Message

Handle "load,provisional,failed" with the on_error callback on EFL MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=118538

Patch by Sergio Correia <[email protected]> on 2013-07-10
Reviewed by Christophe Dumez.

When attempting some odd url such as ``foo'', MiniBrowser will now show an
error message such as "Cannot resolve hostname (foo)".

Previously, it had the following behavior if MiniBrowser was started with
such urls, e.g ``./MiniBrowser foo'':

- Debug:
It wouldt hit WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp(460) and crash.

- Release:
No asserts, naturally, but the view would remain blank, even if we tried to
change to a valid url.

* MiniBrowser/efl/main.c:
(window_create):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (152559 => 152560)


--- trunk/Tools/ChangeLog	2013-07-11 01:15:37 UTC (rev 152559)
+++ trunk/Tools/ChangeLog	2013-07-11 07:00:10 UTC (rev 152560)
@@ -1,3 +1,26 @@
+2013-07-10  Sergio Correia  <[email protected]>
+
+        Handle "load,provisional,failed" with the on_error callback on EFL MiniBrowser
+        https://bugs.webkit.org/show_bug.cgi?id=118538
+
+        Reviewed by Christophe Dumez.
+
+        When attempting some odd url such as ``foo'', MiniBrowser will now show an
+        error message such as "Cannot resolve hostname (foo)".
+
+        Previously, it had the following behavior if MiniBrowser was started with
+        such urls, e.g ``./MiniBrowser foo'':
+
+        - Debug:
+        It wouldt hit WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp(460) and crash.
+
+        - Release:
+        No asserts, naturally, but the view would remain blank, even if we tried to
+        change to a valid url.
+
+        * MiniBrowser/efl/main.c:
+        (window_create):
+
 2013-07-10  Simon Pena  <[email protected]>
 
         [GTK] WebKitTestRunner tries to remove an already deleted event in EventSenderProxy::replaySavedEvents

Modified: trunk/Tools/MiniBrowser/efl/main.c (152559 => 152560)


--- trunk/Tools/MiniBrowser/efl/main.c	2013-07-11 01:15:37 UTC (rev 152559)
+++ trunk/Tools/MiniBrowser/efl/main.c	2013-07-11 07:00:10 UTC (rev 152560)
@@ -1847,6 +1847,7 @@
     evas_object_smart_callback_add(window->ewk_view, "file,chooser,request", on_file_chooser_request, window);
     evas_object_smart_callback_add(window->ewk_view, "favicon,changed", on_view_favicon_changed, window);
     evas_object_smart_callback_add(window->ewk_view, "load,error", on_error, window);
+    evas_object_smart_callback_add(window->ewk_view, "load,provisional,failed", on_error, window);
     evas_object_smart_callback_add(window->ewk_view, "load,progress", on_progress, window);
     evas_object_smart_callback_add(window->ewk_view, "title,changed", on_title_changed, window);
     evas_object_smart_callback_add(window->ewk_view, "url,changed", on_url_changed, window);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to