Title: [152570] trunk/Source
- Revision
- 152570
- Author
- [email protected]
- Date
- 2013-07-11 08:17:13 -0700 (Thu, 11 Jul 2013)
Log Message
[Coordinated Graphics] Parameter of commitSceneState should be const
https://bugs.webkit.org/show_bug.cgi?id=118564
Patch by Jae Hyun Park <[email protected]> on 2013-07-11
Reviewed by Noam Rosenthal.
Parameter of commitSceneState should be const as there should not be any
modifications to the passed CoordinatedGraphicsState.
Source/WebCore:
* platform/graphics/texmap/coordinated/CompositingCoordinator.h:
Source/WebKit2:
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::commitSceneState):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (152569 => 152570)
--- trunk/Source/WebCore/ChangeLog 2013-07-11 14:54:36 UTC (rev 152569)
+++ trunk/Source/WebCore/ChangeLog 2013-07-11 15:17:13 UTC (rev 152570)
@@ -1,3 +1,15 @@
+2013-07-11 Jae Hyun Park <[email protected]>
+
+ [Coordinated Graphics] Parameter of commitSceneState should be const
+ https://bugs.webkit.org/show_bug.cgi?id=118564
+
+ Reviewed by Noam Rosenthal.
+
+ Parameter of commitSceneState should be const as there should not be any
+ modifications to the passed CoordinatedGraphicsState.
+
+ * platform/graphics/texmap/coordinated/CompositingCoordinator.h:
+
2013-07-11 Radu Stavila <[email protected]>
NamedFlowCollection getters should follow the same pattern as HTMLCollection
Modified: trunk/Source/WebCore/platform/graphics/texmap/coordinated/CompositingCoordinator.h (152569 => 152570)
--- trunk/Source/WebCore/platform/graphics/texmap/coordinated/CompositingCoordinator.h 2013-07-11 14:54:36 UTC (rev 152569)
+++ trunk/Source/WebCore/platform/graphics/texmap/coordinated/CompositingCoordinator.h 2013-07-11 15:17:13 UTC (rev 152570)
@@ -63,7 +63,7 @@
virtual void didFlushRootLayer() = 0;
virtual void willSyncLayerState(CoordinatedGraphicsLayerState&) = 0;
virtual void notifyFlushRequired() = 0;
- virtual void commitSceneState(CoordinatedGraphicsState&) = 0;
+ virtual void commitSceneState(const CoordinatedGraphicsState&) = 0;
virtual void paintLayerContents(const GraphicsLayer*, GraphicsContext&, const IntRect& clipRect) = 0;
};
Modified: trunk/Source/WebKit2/ChangeLog (152569 => 152570)
--- trunk/Source/WebKit2/ChangeLog 2013-07-11 14:54:36 UTC (rev 152569)
+++ trunk/Source/WebKit2/ChangeLog 2013-07-11 15:17:13 UTC (rev 152570)
@@ -1,3 +1,17 @@
+2013-07-11 Jae Hyun Park <[email protected]>
+
+ [Coordinated Graphics] Parameter of commitSceneState should be const
+ https://bugs.webkit.org/show_bug.cgi?id=118564
+
+ Reviewed by Noam Rosenthal.
+
+ Parameter of commitSceneState should be const as there should not be any
+ modifications to the passed CoordinatedGraphicsState.
+
+ * WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
+ (WebKit::CoordinatedLayerTreeHost::commitSceneState):
+ * WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
+
2013-07-10 Mark Rowe <[email protected]>
<rdar://problem/14395759> PluginProcess sometimes logs an error about being unable to load WebKit2.framework.
Modified: trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp (152569 => 152570)
--- trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp 2013-07-11 14:54:36 UTC (rev 152569)
+++ trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp 2013-07-11 15:17:13 UTC (rev 152570)
@@ -360,7 +360,7 @@
}
}
-void CoordinatedLayerTreeHost::commitSceneState(WebCore::CoordinatedGraphicsState& state)
+void CoordinatedLayerTreeHost::commitSceneState(const WebCore::CoordinatedGraphicsState& state)
{
m_webPage->send(Messages::CoordinatedLayerTreeHostProxy::CommitCoordinatedGraphicsState(state));
m_isWaitingForRenderer = true;
Modified: trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h (152569 => 152570)
--- trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h 2013-07-11 14:54:36 UTC (rev 152569)
+++ trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h 2013-07-11 15:17:13 UTC (rev 152570)
@@ -106,7 +106,7 @@
virtual void didFlushRootLayer() OVERRIDE;
virtual void willSyncLayerState(WebCore::CoordinatedGraphicsLayerState&) OVERRIDE;
virtual void notifyFlushRequired() OVERRIDE { scheduleLayerFlush(); };
- virtual void commitSceneState(WebCore::CoordinatedGraphicsState&) OVERRIDE;
+ virtual void commitSceneState(const WebCore::CoordinatedGraphicsState&) OVERRIDE;
virtual void paintLayerContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, const WebCore::IntRect& clipRect) OVERRIDE;
#if ENABLE(CSS_SHADERS)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
