Title: [152578] trunk/Source/WebKit2
- Revision
- 152578
- Author
- [email protected]
- Date
- 2013-07-11 15:27:04 -0700 (Thu, 11 Jul 2013)
Log Message
WebResourceCacheManager::cfURLCacheHostNamesWithCallback leaks an array (pointed out by the
clang static analyzer)
https://bugs.webkit.org/show_bug.cgi?id=118533
Reviewed by Anders Carlsson.
* WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp:
(WebKit::WebResourceCacheManager::cfURLCacheHostNamesWithCallback):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (152577 => 152578)
--- trunk/Source/WebKit2/ChangeLog 2013-07-11 21:57:18 UTC (rev 152577)
+++ trunk/Source/WebKit2/ChangeLog 2013-07-11 22:27:04 UTC (rev 152578)
@@ -1,3 +1,14 @@
+2013-07-11 Jessie Berlin <[email protected]>
+
+ WebResourceCacheManager::cfURLCacheHostNamesWithCallback leaks an array (pointed out by the
+ clang static analyzer)
+ https://bugs.webkit.org/show_bug.cgi?id=118533
+
+ Reviewed by Anders Carlsson.
+
+ * WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp:
+ (WebKit::WebResourceCacheManager::cfURLCacheHostNamesWithCallback):
+
2013-07-11 Sergio Correia <[email protected]>
Use GOwnPtr in PluginProcessProxyUnix to manage stdOut variable
Modified: trunk/Source/WebKit2/WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp (152577 => 152578)
--- trunk/Source/WebKit2/WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp 2013-07-11 21:57:18 UTC (rev 152577)
+++ trunk/Source/WebKit2/WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp 2013-07-11 22:27:04 UTC (rev 152578)
@@ -64,10 +64,11 @@
void WebResourceCacheManager::cfURLCacheHostNamesWithCallback(CacheCallback callback)
{
WKCFURLCacheCopyAllPartitionNames(^(CFArrayRef partitionNames) {
- CFMutableArrayRef hostNames = CFArrayCreateMutableCopy(0, 0, WKCFURLCacheCopyAllHostNamesInPersistentStoreForPartition(CFSTR("")));
- CFArrayAppendArray(hostNames, partitionNames, CFRangeMake(0, CFArrayGetCount(partitionNames)));
+ RetainPtr<CFArrayRef> hostNamesInPersistentStore = adoptCF(WKCFURLCacheCopyAllHostNamesInPersistentStoreForPartition(CFSTR("")));
+ RetainPtr<CFMutableArrayRef> hostNames = adoptCF(CFArrayCreateMutableCopy(0, 0, hostNamesInPersistentStore.get()));
+ CFArrayAppendArray(hostNames.get(), partitionNames, CFRangeMake(0, CFArrayGetCount(partitionNames)));
CFRelease(partitionNames);
- callback(adoptCF(hostNames));
+ callback(std::move(hostNames));
});
}
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
