Title: [152588] trunk/Source/WebInspectorUI
- Revision
- 152588
- Author
- [email protected]
- Date
- 2013-07-12 05:45:37 -0700 (Fri, 12 Jul 2013)
Log Message
Web Inspector: Pass null for sidebarPanels and role in WebInspector.Sidebar()
https://bugs.webkit.org/show_bug.cgi?id=118589
Patch by Seokju Kwon <[email protected]> on 2013-07-12
Reviewed by Timothy Hatcher.
sidebarPanels : It is necessary to get correct argument after r152141.
Without this, error messages can be displayed.
role : Could pass null for it since default value is "group".
* UserInterface/Main.js:
(WebInspector.contentLoaded):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (152587 => 152588)
--- trunk/Source/WebInspectorUI/ChangeLog 2013-07-12 10:33:54 UTC (rev 152587)
+++ trunk/Source/WebInspectorUI/ChangeLog 2013-07-12 12:45:37 UTC (rev 152588)
@@ -1,3 +1,17 @@
+2013-07-12 Seokju Kwon <[email protected]>
+
+ Web Inspector: Pass null for sidebarPanels and role in WebInspector.Sidebar()
+ https://bugs.webkit.org/show_bug.cgi?id=118589
+
+ Reviewed by Timothy Hatcher.
+
+ sidebarPanels : It is necessary to get correct argument after r152141.
+ Without this, error messages can be displayed.
+ role : Could pass null for it since default value is "group".
+
+ * UserInterface/Main.js:
+ (WebInspector.contentLoaded):
+
2013-07-03 Timothy Hatcher <[email protected]>
Guard remaining calls to decodeURIComponent with a try/catch.
Modified: trunk/Source/WebInspectorUI/UserInterface/Main.js (152587 => 152588)
--- trunk/Source/WebInspectorUI/UserInterface/Main.js 2013-07-12 10:33:54 UTC (rev 152587)
+++ trunk/Source/WebInspectorUI/UserInterface/Main.js 2013-07-12 12:45:37 UTC (rev 152588)
@@ -169,7 +169,7 @@
this.navigationSidebar.addEventListener(WebInspector.Sidebar.Event.WidthDidChange, this._sidebarWidthDidChange, this);
this.navigationSidebar.addEventListener(WebInspector.Sidebar.Event.SidebarPanelSelected, this._navigationSidebarPanelSelected, this);
- this.rightSidebar = this.detailsSidebar = new WebInspector.Sidebar(document.getElementById("details-sidebar"), WebInspector.Sidebar.Sides.Right, "group", WebInspector.UIString("Details"));
+ this.rightSidebar = this.detailsSidebar = new WebInspector.Sidebar(document.getElementById("details-sidebar"), WebInspector.Sidebar.Sides.Right, null, null, WebInspector.UIString("Details"));
this.detailsSidebar.addEventListener(WebInspector.Sidebar.Event.CollapsedStateDidChange, this._sidebarCollapsedStateDidChange, this);
this.detailsSidebar.addEventListener(WebInspector.Sidebar.Event.WidthDidChange, this._sidebarWidthDidChange, this);
this.detailsSidebar.addEventListener(WebInspector.Sidebar.Event.SidebarPanelSelected, this._detailsSidebarPanelSelected, this);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
