Title: [152607] trunk/Source/WebCore
- Revision
- 152607
- Author
- [email protected]
- Date
- 2013-07-12 16:35:15 -0700 (Fri, 12 Jul 2013)
Log Message
[iOS] TextTrackRepresentation not cleared when captions are disabled
https://bugs.webkit.org/show_bug.cgi?id=118623
Reviewed by Dean Jackson.
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Do not return immediately
when captions are disabled so the necessary cleanup happens.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (152606 => 152607)
--- trunk/Source/WebCore/ChangeLog 2013-07-12 22:37:51 UTC (rev 152606)
+++ trunk/Source/WebCore/ChangeLog 2013-07-12 23:35:15 UTC (rev 152607)
@@ -1,3 +1,14 @@
+2013-07-12 Eric Carlson <[email protected]>
+
+ [iOS] TextTrackRepresentation not cleared when captions are disabled
+ https://bugs.webkit.org/show_bug.cgi?id=118623
+
+ Reviewed by Dean Jackson.
+
+ * html/shadow/MediaControlElements.cpp:
+ (WebCore::MediaControlTextTrackContainerElement::updateDisplay): Do not return immediately
+ when captions are disabled so the necessary cleanup happens.
+
2013-07-12 Brent Fulgham <[email protected]>
[Windows] Attempt to satisfy the Open Source Windows bots.
Modified: trunk/Source/WebCore/html/shadow/MediaControlElements.cpp (152606 => 152607)
--- trunk/Source/WebCore/html/shadow/MediaControlElements.cpp 2013-07-12 22:37:51 UTC (rev 152606)
+++ trunk/Source/WebCore/html/shadow/MediaControlElements.cpp 2013-07-12 23:35:15 UTC (rev 152607)
@@ -1227,10 +1227,8 @@
void MediaControlTextTrackContainerElement::updateDisplay()
{
- if (!mediaController()->closedCaptionsVisible()) {
+ if (!mediaController()->closedCaptionsVisible())
removeChildren();
- return;
- }
HTMLMediaElement* mediaElement = toParentMediaElement(this);
// 1. If the media element is an audio element, or is another playback
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
