Title: [152652] trunk/Source/WebInspectorUI
Revision
152652
Author
[email protected]
Date
2013-07-15 12:46:30 -0700 (Mon, 15 Jul 2013)

Log Message

Make sure to add main resources for sub-frames to the Network Timeline.

https://bugs.webkit.org/show_bug.cgi?id=118649

Reviewed by Joseph Pecoraro.

* UserInterface/TimelineManager.js:
(WebInspector.TimelineManager.prototype._mainResourceDidChange): Remove the
call to _clear() and early return for event.target.isMainFrame(). The _clear()
is already handled if needed by the call to _startAutoRecording(), so it was
redundant here and caused the erroneous addition of isMainFrame() early return.

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (152651 => 152652)


--- trunk/Source/WebInspectorUI/ChangeLog	2013-07-15 18:53:27 UTC (rev 152651)
+++ trunk/Source/WebInspectorUI/ChangeLog	2013-07-15 19:46:30 UTC (rev 152652)
@@ -1,5 +1,19 @@
 2013-07-15  Timothy Hatcher  <[email protected]>
 
+        Make sure to add main resources for sub-frames to the Network Timeline.
+
+        https://bugs.webkit.org/show_bug.cgi?id=118649
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/TimelineManager.js:
+        (WebInspector.TimelineManager.prototype._mainResourceDidChange): Remove the
+        call to _clear() and early return for event.target.isMainFrame(). The _clear()
+        is already handled if needed by the call to _startAutoRecording(), so it was
+        redundant here and caused the erroneous addition of isMainFrame() early return.
+
+2013-07-15  Timothy Hatcher  <[email protected]>
+
         Properly handle style text changes while the color popover is open.
 
         https://bugs.webkit.org/show_bug.cgi?id=118575

Modified: trunk/Source/WebInspectorUI/UserInterface/TimelineManager.js (152651 => 152652)


--- trunk/Source/WebInspectorUI/UserInterface/TimelineManager.js	2013-07-15 18:53:27 UTC (rev 152651)
+++ trunk/Source/WebInspectorUI/UserInterface/TimelineManager.js	2013-07-15 19:46:30 UTC (rev 152652)
@@ -404,16 +404,11 @@
         if (!WebInspector.frameResourceManager.mainFrame)
             return;
 
-        if (!event.target.isMainFrame())
-            return;
-
         if (this._startAutoRecording(event))
             return;
 
-        if (!this._recording) {
-            this._clear();
+        if (!this._recording)
             return;
-        }
 
         var mainResource = event.target.mainResource;
         if (mainResource === this._autoRecordingMainResource)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to