Title: [152672] trunk/Source
Revision
152672
Author
[email protected]
Date
2013-07-15 16:41:23 -0700 (Mon, 15 Jul 2013)

Log Message

NetworkStorageSession::createDefaultSession is only implemented by Soup
https://bugs.webkit.org/show_bug.cgi?id=118679

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Remove NetworkStorageSession::createDefaultSession() because
NetworkStorageSession::defaultStorageSession() returns the default
session.

No new tests, no behavior change.

* platform/network/NetworkStorageSession.h:
* platform/network/soup/NetworkStorageSessionSoup.cpp:

Source/WebKit/efl:

Replace NetworkStorageSession::createDefaultSession() with
NetworkStorageSession::defaultStorageSession().

* ewk/ewk_view.cpp:
(_ewk_view_priv_new):
(EWKPrivate::storageSession):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (152671 => 152672)


--- trunk/Source/WebCore/ChangeLog	2013-07-15 23:34:23 UTC (rev 152671)
+++ trunk/Source/WebCore/ChangeLog	2013-07-15 23:41:23 UTC (rev 152672)
@@ -1,3 +1,19 @@
+2013-07-15  Kwang Yul Seo  <[email protected]>
+
+        NetworkStorageSession::createDefaultSession is only implemented by Soup
+        https://bugs.webkit.org/show_bug.cgi?id=118679
+
+        Reviewed by Alexey Proskuryakov.
+
+        Remove NetworkStorageSession::createDefaultSession() because
+        NetworkStorageSession::defaultStorageSession() returns the default
+        session.
+
+        No new tests, no behavior change.
+
+        * platform/network/NetworkStorageSession.h:
+        * platform/network/soup/NetworkStorageSessionSoup.cpp:
+
 2013-07-15  Ryosuke Niwa  <[email protected]>
 
         compositionstart event should contain the text to be replaced

Modified: trunk/Source/WebCore/platform/network/NetworkStorageSession.h (152671 => 152672)


--- trunk/Source/WebCore/platform/network/NetworkStorageSession.h	2013-07-15 23:34:23 UTC (rev 152671)
+++ trunk/Source/WebCore/platform/network/NetworkStorageSession.h	2013-07-15 23:41:23 UTC (rev 152672)
@@ -45,7 +45,6 @@
     WTF_MAKE_NONCOPYABLE(NetworkStorageSession); WTF_MAKE_FAST_ALLOCATED;
 public:
     static NetworkStorageSession& defaultStorageSession();
-    static PassOwnPtr<NetworkStorageSession> createDefaultSession(const String& identifierBase = String());
     static PassOwnPtr<NetworkStorageSession> createPrivateBrowsingSession(const String& identifierBase);
 
     static void switchToNewTestingSession();

Modified: trunk/Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp (152671 => 152672)


--- trunk/Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp	2013-07-15 23:34:23 UTC (rev 152671)
+++ trunk/Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp	2013-07-15 23:41:23 UTC (rev 152672)
@@ -52,12 +52,6 @@
     return *defaultSession();
 }
 
-PassOwnPtr<NetworkStorageSession> NetworkStorageSession::createDefaultSession(const String&)
-{
-    ASSERT(isMainThread());
-    return adoptPtr(new NetworkStorageSession(ResourceHandle::defaultSession()));
-}
-
 PassOwnPtr<NetworkStorageSession> NetworkStorageSession::createPrivateBrowsingSession(const String&)
 {
     ASSERT_NOT_REACHED();

Modified: trunk/Source/WebKit/efl/ChangeLog (152671 => 152672)


--- trunk/Source/WebKit/efl/ChangeLog	2013-07-15 23:34:23 UTC (rev 152671)
+++ trunk/Source/WebKit/efl/ChangeLog	2013-07-15 23:41:23 UTC (rev 152672)
@@ -1,3 +1,17 @@
+2013-07-15  Kwang Yul Seo  <[email protected]>
+
+        NetworkStorageSession::createDefaultSession is only implemented by Soup
+        https://bugs.webkit.org/show_bug.cgi?id=118679
+
+        Reviewed by Alexey Proskuryakov.
+
+        Replace NetworkStorageSession::createDefaultSession() with
+        NetworkStorageSession::defaultStorageSession().
+
+        * ewk/ewk_view.cpp:
+        (_ewk_view_priv_new):
+        (EWKPrivate::storageSession):
+
 2013-07-09  Ryuan Choi  <[email protected]>
 
         [EFL] Add ewk_view_device_pixel_ratio_set

Modified: trunk/Source/WebKit/efl/ewk/ewk_view.cpp (152671 => 152672)


--- trunk/Source/WebKit/efl/ewk/ewk_view.cpp	2013-07-15 23:34:23 UTC (rev 152671)
+++ trunk/Source/WebKit/efl/ewk/ewk_view.cpp	2013-07-15 23:41:23 UTC (rev 152672)
@@ -269,7 +269,7 @@
 #if ENABLE(NAVIGATOR_CONTENT_UTILS) || ENABLE(CUSTOM_SCHEME_HANDLER)
     OwnPtr<WebCore::NavigatorContentUtilsClientEfl> navigatorContentUtilsClient;
 #endif
-    OwnPtr<WebCore::NetworkStorageSession> storageSession;
+    WebCore::NetworkStorageSession* storageSession;
     struct {
         Ewk_Menu menu;
         WebCore::PopupMenuClient* menuClient;
@@ -849,7 +849,7 @@
 
     priv->history = ewk_history_new(static_cast<WebCore::BackForwardListImpl*>(priv->page->backForwardList()));
 
-    priv->storageSession = WebCore::NetworkStorageSession::createDefaultSession();
+    priv->storageSession = &WebCore::NetworkStorageSession::defaultStorageSession();
 
     priv->pageClient = adoptPtr(new PageClientEfl(smartData->self));
 
@@ -4772,7 +4772,7 @@
 {
     EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, 0);
     EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, 0);
-    return priv->storageSession.get();
+    return priv->storageSession;
 }
 
 } // namespace EWKPrivate
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to