Title: [152675] trunk/Tools
Revision
152675
Author
[email protected]
Date
2013-07-15 16:47:32 -0700 (Mon, 15 Jul 2013)

Log Message

[EFL] Add fallback for TestWebKitAPI if opengl is not available.
https://bugs.webkit.org/show_bug.cgi?id=118583

Patch by Dong-Gwan Kim <[email protected]> on 2013-07-15
Reviewed by Christophe Dumez.

There're many fails on efl webkit2 API test if opengl is not available.
So, add fallback to non-opengl evas engine.

* TestWebKitAPI/efl/PlatformWebView.cpp:
(TestWebKitAPI::initEcoreEvas):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (152674 => 152675)


--- trunk/Tools/ChangeLog	2013-07-15 23:44:30 UTC (rev 152674)
+++ trunk/Tools/ChangeLog	2013-07-15 23:47:32 UTC (rev 152675)
@@ -1,3 +1,16 @@
+2013-07-15  Dong-Gwan Kim  <[email protected]>
+
+        [EFL] Add fallback for TestWebKitAPI if opengl is not available.
+        https://bugs.webkit.org/show_bug.cgi?id=118583
+
+        Reviewed by Christophe Dumez.
+
+        There're many fails on efl webkit2 API test if opengl is not available.
+        So, add fallback to non-opengl evas engine.
+
+        * TestWebKitAPI/efl/PlatformWebView.cpp:
+        (TestWebKitAPI::initEcoreEvas):
+
 2013-07-15  Brian Holt  <[email protected]>
 
         check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member

Modified: trunk/Tools/TestWebKitAPI/efl/PlatformWebView.cpp (152674 => 152675)


--- trunk/Tools/TestWebKitAPI/efl/PlatformWebView.cpp	2013-07-15 23:44:30 UTC (rev 152674)
+++ trunk/Tools/TestWebKitAPI/efl/PlatformWebView.cpp	2013-07-15 23:47:32 UTC (rev 152675)
@@ -45,11 +45,13 @@
     if (!ecore_evas_init())
         return 0;
 
-    const char* engine = 0;
+    Ecore_Evas* ecoreEvas;
 #if defined(WTF_USE_ACCELERATED_COMPOSITING) && defined(HAVE_ECORE_X)
-    engine = "opengl_x11";
+    ecoreEvas = ecore_evas_new("opengl_x11", 0, 0, 800, 600, 0);
+    // Graceful fallback to software rendering if evas_gl engine is not available.
+    if (!ecoreEvas)
 #endif
-    Ecore_Evas* ecoreEvas = ecore_evas_new(engine, 0, 0, 800, 600, 0);
+    ecoreEvas = ecore_evas_new(0, 0, 0, 800, 600, 0);
 
     ASSERT(ecoreEvas);
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to