Diff
Modified: trunk/Source/WebCore/ChangeLog (152762 => 152763)
--- trunk/Source/WebCore/ChangeLog 2013-07-17 07:11:19 UTC (rev 152762)
+++ trunk/Source/WebCore/ChangeLog 2013-07-17 07:12:11 UTC (rev 152763)
@@ -1,3 +1,52 @@
+2013-07-17 Kangil Han <[email protected]>
+
+ Use toHTMLMediaElement
+ https://bugs.webkit.org/show_bug.cgi?id=118727
+
+ Reviewed by Ryosuke Niwa.
+
+ To avoid direct use of static_cast, this patch uses toHTMLMediaElement for code cleanup.
+
+ * bindings/js/JSHTMLMediaElementCustom.cpp:
+ (WebCore::JSHTMLMediaElement::setController):
+ * html/HTMLMediaElement.h:
+ (WebCore::toHTMLMediaElement):
+ * html/HTMLSourceElement.cpp:
+ (WebCore::HTMLSourceElement::insertedInto):
+ (WebCore::HTMLSourceElement::removedFrom):
+ * html/HTMLTrackElement.cpp:
+ (WebCore::HTMLTrackElement::removedFrom):
+ (WebCore::HTMLTrackElement::mediaElement):
+ * html/shadow/MediaControlElementTypes.cpp:
+ (WebCore::toParentMediaElement):
+ * loader/SubframeLoader.cpp:
+ (WebCore::SubframeLoader::loadMediaPlayerProxyPlugin):
+ * page/FrameView.cpp:
+ (WebCore::FrameView::updateWidget):
+ * platform/efl/RenderThemeEfl.cpp:
+ (WebCore::RenderThemeEfl::paintMediaFullscreenButton):
+ (WebCore::RenderThemeEfl::paintMediaMuteButton):
+ (WebCore::RenderThemeEfl::paintMediaToggleClosedCaptionsButton):
+ * platform/graphics/wince/MediaPlayerProxy.cpp:
+ (WebCore::WebMediaPlayerProxy::initEngine):
+ (WebCore::WebMediaPlayerProxy::element):
+ * platform/gtk/RenderThemeGtk.cpp:
+ (WebCore::getMediaElementFromRenderObject):
+ * rendering/HitTestResult.cpp:
+ (WebCore::HitTestResult::mediaElement):
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::requiresCompositingForVideo):
+ * rendering/RenderMedia.cpp:
+ (WebCore::RenderMedia::mediaElement):
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::paintMediaSliderTrack):
+ * rendering/RenderThemeWinCE.cpp:
+ (WebCore::mediaElementParent):
+ * testing/Internals.cpp:
+ (WebCore::Internals::simulateAudioInterruption):
+
2013-07-16 Ryuan Choi <[email protected]>
Remove Platform(EFL) guard from Widget::frameRectsChanged
Modified: trunk/Source/WebCore/bindings/js/JSHTMLMediaElementCustom.cpp (152762 => 152763)
--- trunk/Source/WebCore/bindings/js/JSHTMLMediaElementCustom.cpp 2013-07-17 07:11:19 UTC (rev 152762)
+++ trunk/Source/WebCore/bindings/js/JSHTMLMediaElementCustom.cpp 2013-07-17 07:12:11 UTC (rev 152763)
@@ -36,7 +36,7 @@
void JSHTMLMediaElement::setController(ExecState*, JSValue value)
{
- HTMLMediaElement* imp = static_cast<HTMLMediaElement*>(impl());
+ HTMLMediaElement* imp = toHTMLMediaElement(impl());
// 4.8.10.11.2 Media controllers: controller attribute.
// On setting, it must first remove the element's mediagroup attribute, if any,
imp->setMediaGroup(String());
Modified: trunk/Source/WebCore/html/HTMLMediaElement.h (152762 => 152763)
--- trunk/Source/WebCore/html/HTMLMediaElement.h 2013-07-17 07:11:19 UTC (rev 152762)
+++ trunk/Source/WebCore/html/HTMLMediaElement.h 2013-07-17 07:12:11 UTC (rev 152763)
@@ -802,7 +802,7 @@
return node && node->isElementNode() && toElement(node)->isMediaElement();
}
-inline HTMLMediaElement* toMediaElement(Node* node)
+inline HTMLMediaElement* toHTMLMediaElement(Node* node)
{
ASSERT_WITH_SECURITY_IMPLICATION(!node || isMediaElement(node));
return static_cast<HTMLMediaElement*>(node);
Modified: trunk/Source/WebCore/html/HTMLSourceElement.cpp (152762 => 152763)
--- trunk/Source/WebCore/html/HTMLSourceElement.cpp 2013-07-17 07:11:19 UTC (rev 152762)
+++ trunk/Source/WebCore/html/HTMLSourceElement.cpp 2013-07-17 07:12:11 UTC (rev 152763)
@@ -58,7 +58,7 @@
HTMLElement::insertedInto(insertionPoint);
Element* parent = parentElement();
if (parent && parent->isMediaElement())
- static_cast<HTMLMediaElement*>(parentNode())->sourceWasAdded(this);
+ toHTMLMediaElement(parentNode())->sourceWasAdded(this);
return InsertionDone;
}
@@ -68,7 +68,7 @@
if (!parent && removalRoot->isElementNode())
parent = toElement(removalRoot);
if (parent && parent->isMediaElement())
- toMediaElement(parent)->sourceWasRemoved(this);
+ toHTMLMediaElement(parent)->sourceWasRemoved(this);
HTMLElement::removedFrom(removalRoot);
}
Modified: trunk/Source/WebCore/html/HTMLTrackElement.cpp (152762 => 152763)
--- trunk/Source/WebCore/html/HTMLTrackElement.cpp 2013-07-17 07:11:19 UTC (rev 152762)
+++ trunk/Source/WebCore/html/HTMLTrackElement.cpp 2013-07-17 07:12:11 UTC (rev 152763)
@@ -88,7 +88,7 @@
void HTMLTrackElement::removedFrom(ContainerNode* insertionPoint)
{
if (!parentNode() && WebCore::isMediaElement(insertionPoint))
- toMediaElement(insertionPoint)->didRemoveTextTrack(this);
+ toHTMLMediaElement(insertionPoint)->didRemoveTextTrack(this);
HTMLElement::removedFrom(insertionPoint);
}
@@ -356,7 +356,7 @@
{
Element* parent = parentElement();
if (parent && parent->isMediaElement())
- return static_cast<HTMLMediaElement*>(parentNode());
+ return toHTMLMediaElement(parentNode());
return 0;
}
Modified: trunk/Source/WebCore/html/shadow/MediaControlElementTypes.cpp (152762 => 152763)
--- trunk/Source/WebCore/html/shadow/MediaControlElementTypes.cpp 2013-07-17 07:11:19 UTC (rev 152762)
+++ trunk/Source/WebCore/html/shadow/MediaControlElementTypes.cpp 2013-07-17 07:12:11 UTC (rev 152763)
@@ -62,7 +62,7 @@
if (!mediaNode || !mediaNode->isElementNode() || !toElement(mediaNode)->isMediaElement())
return 0;
- return static_cast<HTMLMediaElement*>(mediaNode);
+ return toHTMLMediaElement(mediaNode);
}
MediaControlElementType mediaControlElementType(Node* node)
Modified: trunk/Source/WebCore/loader/SubframeLoader.cpp (152762 => 152763)
--- trunk/Source/WebCore/loader/SubframeLoader.cpp 2013-07-17 07:11:19 UTC (rev 152762)
+++ trunk/Source/WebCore/loader/SubframeLoader.cpp 2013-07-17 07:12:11 UTC (rev 152763)
@@ -261,7 +261,7 @@
if (!m_frame->document()->contentSecurityPolicy()->allowMediaFromSource(completedURL))
return 0;
- HTMLMediaElement* mediaElement = static_cast<HTMLMediaElement*>(node);
+ HTMLMediaElement* mediaElement = toHTMLMediaElement(node);
RenderPart* renderer = toRenderPart(node->renderer());
IntSize size;
Modified: trunk/Source/WebCore/page/FrameView.cpp (152762 => 152763)
--- trunk/Source/WebCore/page/FrameView.cpp 2013-07-17 07:11:19 UTC (rev 152762)
+++ trunk/Source/WebCore/page/FrameView.cpp 2013-07-17 07:12:11 UTC (rev 152763)
@@ -2690,7 +2690,7 @@
// FIXME: It is not clear that Media elements need or want this updateWidget() call.
#if ENABLE(PLUGIN_PROXY_FOR_VIDEO)
else if (ownerElement->isMediaElement())
- static_cast<HTMLMediaElement*>(ownerElement)->updateWidget(CreateAnyWidgetType);
+ toHTMLMediaElement(ownerElement)->updateWidget(CreateAnyWidgetType);
#endif
else
ASSERT_NOT_REACHED();
Modified: trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp (152762 => 152763)
--- trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp 2013-07-17 07:11:19 UTC (rev 152762)
+++ trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp 2013-07-17 07:12:11 UTC (rev 152763)
@@ -1129,7 +1129,7 @@
if (!mediaNode || !mediaNode->isElementNode() || !toElement(mediaNode)->isMediaElement())
return false;
- HTMLMediaElement* mediaElement = static_cast<HTMLMediaElement*>(mediaNode);
+ HTMLMediaElement* mediaElement = toHTMLMediaElement(mediaNode);
if (!emitMediaButtonSignal(FullScreenButton, mediaElement->isFullscreen() ? MediaExitFullscreenButton : MediaEnterFullscreenButton, rect))
return false;
@@ -1144,7 +1144,7 @@
if (!mediaNode || !mediaNode->isElementNode() || !toElement(mediaNode)->isMediaElement())
return false;
- HTMLMediaElement* mediaElement = static_cast<HTMLMediaElement*>(mediaNode);
+ HTMLMediaElement* mediaElement = toHTMLMediaElement(mediaNode);
if (!emitMediaButtonSignal(MuteUnMuteButton, mediaElement->muted() ? MediaMuteButton : MediaUnMuteButton, rect))
return false;
@@ -1286,7 +1286,7 @@
if (!mediaNode || (!mediaNode->hasTagName(videoTag)))
return false;
- HTMLMediaElement* mediaElement = static_cast<HTMLMediaElement*>(mediaNode);
+ HTMLMediaElement* mediaElement = toHTMLMediaElement(mediaNode);
if (!emitMediaButtonSignal(ToggleCaptionsButton, mediaElement->webkitClosedCaptionsVisible() ? MediaShowClosedCaptionsButton : MediaHideClosedCaptionsButton, rect))
return false;
Modified: trunk/Source/WebCore/platform/graphics/wince/MediaPlayerProxy.cpp (152762 => 152763)
--- trunk/Source/WebCore/platform/graphics/wince/MediaPlayerProxy.cpp 2013-07-17 07:11:19 UTC (rev 152762)
+++ trunk/Source/WebCore/platform/graphics/wince/MediaPlayerProxy.cpp 2013-07-17 07:12:11 UTC (rev 152763)
@@ -89,7 +89,7 @@
void WebMediaPlayerProxy::initEngine()
{
- HTMLMediaElement* element = static_cast<HTMLMediaElement*>(m_mediaPlayer->mediaPlayerClient());
+ HTMLMediaElement* element = toHTMLMediaElement(m_mediaPlayer->mediaPlayerClient());
String url = ""
if (url.isEmpty())
@@ -116,7 +116,7 @@
HTMLMediaElement* WebMediaPlayerProxy::element()
{
- return static_cast<HTMLMediaElement*>(m_mediaPlayer->mediaPlayerClient());
+ return toHTMLMediaElement(m_mediaPlayer->mediaPlayerClient());
}
Modified: trunk/Source/WebCore/platform/gtk/RenderThemeGtk.cpp (152762 => 152763)
--- trunk/Source/WebCore/platform/gtk/RenderThemeGtk.cpp 2013-07-17 07:11:19 UTC (rev 152762)
+++ trunk/Source/WebCore/platform/gtk/RenderThemeGtk.cpp 2013-07-17 07:12:11 UTC (rev 152763)
@@ -71,7 +71,7 @@
if (!mediaNode || !mediaNode->isElementNode() || !toElement(mediaNode)->isMediaElement())
return 0;
- return static_cast<HTMLMediaElement*>(mediaNode);
+ return toHTMLMediaElement(mediaNode);
}
void RenderThemeGtk::initMediaButtons()
Modified: trunk/Source/WebCore/rendering/HitTestResult.cpp (152762 => 152763)
--- trunk/Source/WebCore/rendering/HitTestResult.cpp 2013-07-17 07:11:19 UTC (rev 152762)
+++ trunk/Source/WebCore/rendering/HitTestResult.cpp 2013-07-17 07:12:11 UTC (rev 152763)
@@ -382,7 +382,7 @@
return 0;
if (m_innerNonSharedNode->hasTagName(HTMLNames::videoTag) || isHTMLAudioElement(m_innerNonSharedNode.get()))
- return static_cast<HTMLMediaElement*>(m_innerNonSharedNode.get());
+ return toHTMLMediaElement(m_innerNonSharedNode.get());
return 0;
}
#endif
Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.cpp (152762 => 152763)
--- trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2013-07-17 07:11:19 UTC (rev 152762)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2013-07-17 07:12:11 UTC (rev 152763)
@@ -570,7 +570,7 @@
}
#if ENABLE(VIDEO)
else if (renderer->isVideo()) {
- HTMLMediaElement* mediaElement = toMediaElement(renderer->node());
+ HTMLMediaElement* mediaElement = toHTMLMediaElement(renderer->node());
m_graphicsLayer->setContentsToMedia(mediaElement->platformLayer());
}
#endif
Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (152762 => 152763)
--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2013-07-17 07:11:19 UTC (rev 152762)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2013-07-17 07:12:11 UTC (rev 152763)
@@ -2070,7 +2070,7 @@
if (!node || (!node->hasTagName(HTMLNames::videoTag) && !isHTMLAudioElement(node)))
return false;
- HTMLMediaElement* mediaElement = toMediaElement(node);
+ HTMLMediaElement* mediaElement = toHTMLMediaElement(node);
return mediaElement->player() ? mediaElement->player()->supportsAcceleratedRendering() : false;
}
#endif // ENABLE(PLUGIN_PROXY_FOR_VIDEO)
Modified: trunk/Source/WebCore/rendering/RenderMedia.cpp (152762 => 152763)
--- trunk/Source/WebCore/rendering/RenderMedia.cpp 2013-07-17 07:11:19 UTC (rev 152762)
+++ trunk/Source/WebCore/rendering/RenderMedia.cpp 2013-07-17 07:12:11 UTC (rev 152763)
@@ -54,7 +54,7 @@
HTMLMediaElement* RenderMedia::mediaElement() const
{
- return toMediaElement(node());
+ return toHTMLMediaElement(node());
}
void RenderMedia::layout()
Modified: trunk/Source/WebCore/rendering/RenderThemeMac.mm (152762 => 152763)
--- trunk/Source/WebCore/rendering/RenderThemeMac.mm 2013-07-17 07:11:19 UTC (rev 152762)
+++ trunk/Source/WebCore/rendering/RenderThemeMac.mm 2013-07-17 07:12:11 UTC (rev 152763)
@@ -343,7 +343,7 @@
if (!mediaNode || !mediaNode->isMediaElement())
return false;
- HTMLMediaElement* mediaElement = static_cast<HTMLMediaElement*>(mediaNode);
+ HTMLMediaElement* mediaElement = toHTMLMediaElement(mediaNode);
if (!mediaElement)
return false;
Modified: trunk/Source/WebCore/rendering/RenderThemeWinCE.cpp (152762 => 152763)
--- trunk/Source/WebCore/rendering/RenderThemeWinCE.cpp 2013-07-17 07:11:19 UTC (rev 152762)
+++ trunk/Source/WebCore/rendering/RenderThemeWinCE.cpp 2013-07-17 07:12:11 UTC (rev 152763)
@@ -485,7 +485,7 @@
if (!mediaNode || !mediaNode->isElementNode() || !toElement(mediaNode)->isMediaElement())
return 0;
- return static_cast<HTMLMediaElement*>(mediaNode);
+ return toHTMLMediaElement(mediaNode);
}
#endif
Modified: trunk/Source/WebCore/testing/Internals.cpp (152762 => 152763)
--- trunk/Source/WebCore/testing/Internals.cpp 2013-07-17 07:11:19 UTC (rev 152762)
+++ trunk/Source/WebCore/testing/Internals.cpp 2013-07-17 07:12:11 UTC (rev 152763)
@@ -2045,7 +2045,7 @@
void Internals::simulateAudioInterruption(Node* node)
{
#if USE(GSTREAMER)
- HTMLMediaElement* element = toMediaElement(node);
+ HTMLMediaElement* element = toHTMLMediaElement(node);
element->player()->simulateAudioInterruption();
#else
UNUSED_PARAM(node);
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (152762 => 152763)
--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2013-07-17 07:11:19 UTC (rev 152762)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2013-07-17 07:12:11 UTC (rev 152763)
@@ -2168,7 +2168,7 @@
imageElement = toHTMLAreaElement(node.get())->imageElement();
if (static_cast<HTMLElement*>(node.get())->isMediaElement())
- mediaElement = static_cast<HTMLMediaElement*>(node.get());
+ mediaElement = toHTMLMediaElement(node.get());
if (imageElement && imageElement->renderer()) {
context.setFlag(Platform::WebContext::IsImage);
@@ -4986,7 +4986,7 @@
if (!element)
return;
if (d->m_webSettings->fullScreenVideoCapable() && element->hasTagName(HTMLNames::videoTag))
- static_cast<HTMLMediaElement*>(element)->exitFullscreen();
+ toHTMLMediaElement(element)->exitFullscreen();
#if ENABLE(FULLSCREEN_API)
else
element->document()->webkitCancelFullScreen();
@@ -5615,7 +5615,7 @@
if (!node || !node->hasTagName(HTMLNames::videoTag))
return;
- MediaPlayer* player = static_cast<HTMLMediaElement*>(node)->player();
+ MediaPlayer* player = toHTMLMediaElement(node)->player();
if (!player)
return;
@@ -5648,7 +5648,7 @@
if (!node || !node->hasTagName(HTMLNames::videoTag))
return;
- MediaPlayer* player = static_cast<HTMLMediaElement*>(node)->player();
+ MediaPlayer* player = toHTMLMediaElement(node)->player();
if (!player)
return;
Modified: trunk/Source/WebKit/blackberry/ChangeLog (152762 => 152763)
--- trunk/Source/WebKit/blackberry/ChangeLog 2013-07-17 07:11:19 UTC (rev 152762)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2013-07-17 07:12:11 UTC (rev 152763)
@@ -1,3 +1,18 @@
+2013-07-17 Kangil Han <[email protected]>
+
+ Use toHTMLMediaElement
+ https://bugs.webkit.org/show_bug.cgi?id=118727
+
+ Reviewed by Ryosuke Niwa.
+
+ To avoid direct use of static_cast, this patch uses toHTMLMediaElement for code cleanup.
+
+ * Api/WebPage.cpp:
+ (BlackBerry::WebKit::WebPagePrivate::webContext):
+ (BlackBerry::WebKit::WebPage::notifyFullScreenVideoExited):
+ (BlackBerry::WebKit::WebPagePrivate::enterFullscreenForNode):
+ (BlackBerry::WebKit::WebPagePrivate::exitFullscreenForNode):
+
2013-07-16 Kangil Han <[email protected]>
Use toHTMLSelectElement and dismiss isHTMLSelectElement
Modified: trunk/Source/WebKit/gtk/ChangeLog (152762 => 152763)
--- trunk/Source/WebKit/gtk/ChangeLog 2013-07-17 07:11:19 UTC (rev 152762)
+++ trunk/Source/WebKit/gtk/ChangeLog 2013-07-17 07:12:11 UTC (rev 152763)
@@ -1,3 +1,18 @@
+2013-07-17 Kangil Han <[email protected]>
+
+ Use toHTMLMediaElement
+ https://bugs.webkit.org/show_bug.cgi?id=118727
+
+ Reviewed by Ryosuke Niwa.
+
+ To avoid direct use of static_cast, this patch uses toHTMLMediaElement for code cleanup.
+
+ * WebCoreSupport/ChromeClientGtk.cpp:
+ (WebKit::ChromeClient::enterFullscreenForNode):
+ (WebKit::ChromeClient::exitFullscreenForNode):
+ (WebKit::ChromeClient::enterFullScreenForElement):
+ (WebKit::ChromeClient::exitFullScreenForElement):
+
2013-07-09 Carlos Garcia Campos <[email protected]>
Unreviewed. Update NEWS and Versions.m4 for 2.1.3 release.
Modified: trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp (152762 => 152763)
--- trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp 2013-07-17 07:11:19 UTC (rev 152762)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp 2013-07-17 07:12:11 UTC (rev 152763)
@@ -938,7 +938,7 @@
HTMLElement* element = static_cast<HTMLElement*>(node);
if (element && element->isMediaElement()) {
- HTMLMediaElement* mediaElement = static_cast<HTMLMediaElement*>(element);
+ HTMLMediaElement* mediaElement = toHTMLMediaElement(element);
if (mediaElement->player() && mediaElement->player()->canEnterFullscreen())
mediaElement->player()->enterFullscreen();
}
@@ -951,7 +951,7 @@
HTMLElement* element = static_cast<HTMLElement*>(node);
if (element && element->isMediaElement()) {
- HTMLMediaElement* mediaElement = static_cast<HTMLMediaElement*>(element);
+ HTMLMediaElement* mediaElement = toHTMLMediaElement(element);
if (mediaElement->player())
mediaElement->player()->exitFullscreen();
}
@@ -995,7 +995,7 @@
#if ENABLE(VIDEO) && USE(NATIVE_FULLSCREEN_VIDEO)
if (element && element->isMediaElement()) {
- HTMLMediaElement* mediaElement = static_cast<HTMLMediaElement*>(element);
+ HTMLMediaElement* mediaElement = toHTMLMediaElement(element);
if (mediaElement->player() && mediaElement->player()->canEnterFullscreen()) {
element->document()->webkitWillEnterFullScreenForElement(element);
mediaElement->player()->enterFullscreen();
@@ -1036,7 +1036,7 @@
#if ENABLE(VIDEO) && USE(NATIVE_FULLSCREEN_VIDEO)
if (m_fullScreenElement && m_fullScreenElement->isMediaElement()) {
m_fullScreenElement->document()->webkitWillExitFullScreenForElement(m_fullScreenElement.get());
- HTMLMediaElement* mediaElement = static_cast<HTMLMediaElement*>(m_fullScreenElement.get());
+ HTMLMediaElement* mediaElement = toHTMLMediaElement(m_fullScreenElement.get());
if (mediaElement->player()) {
mediaElement->player()->exitFullscreen();
m_fullScreenElement->document()->webkitDidExitFullScreenForElement(m_fullScreenElement.get());
Modified: trunk/Source/WebKit/mac/ChangeLog (152762 => 152763)
--- trunk/Source/WebKit/mac/ChangeLog 2013-07-17 07:11:19 UTC (rev 152762)
+++ trunk/Source/WebKit/mac/ChangeLog 2013-07-17 07:12:11 UTC (rev 152763)
@@ -1,3 +1,15 @@
+2013-07-17 Kangil Han <[email protected]>
+
+ Use toHTMLMediaElement
+ https://bugs.webkit.org/show_bug.cgi?id=118727
+
+ Reviewed by Ryosuke Niwa.
+
+ To avoid direct use of static_cast, this patch uses toHTMLMediaElement for code cleanup.
+
+ * WebView/WebView.mm:
+ (-[WebView _enterFullscreenForNode:WebCore::]):
+
2013-07-16 Simon Fraser <[email protected]>
Protect against the LayerFlushController being deleted inside its flushLayers() callback
Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (152762 => 152763)
--- trunk/Source/WebKit/mac/WebView/WebView.mm 2013-07-17 07:11:19 UTC (rev 152762)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm 2013-07-17 07:12:11 UTC (rev 152763)
@@ -6504,7 +6504,7 @@
- (void)_enterFullscreenForNode:(WebCore::Node*)node
{
ASSERT(node->hasTagName(WebCore::HTMLNames::videoTag));
- HTMLMediaElement* videoElement = toMediaElement(node);
+ HTMLMediaElement* videoElement = toHTMLMediaElement(node);
if (_private->fullscreenController) {
if ([_private->fullscreenController mediaElement] == videoElement) {
Modified: trunk/Source/WebKit/win/ChangeLog (152762 => 152763)
--- trunk/Source/WebKit/win/ChangeLog 2013-07-17 07:11:19 UTC (rev 152762)
+++ trunk/Source/WebKit/win/ChangeLog 2013-07-17 07:12:11 UTC (rev 152763)
@@ -1,3 +1,15 @@
+2013-07-17 Kangil Han <[email protected]>
+
+ Use toHTMLMediaElement
+ https://bugs.webkit.org/show_bug.cgi?id=118727
+
+ Reviewed by Ryosuke Niwa.
+
+ To avoid direct use of static_cast, this patch uses toHTMLMediaElement for code cleanup.
+
+ * WebView.cpp:
+ (WebView::enterFullscreenForNode):
+
2013-07-16 Kangil Han <[email protected]>
Use toHTMLSelectElement and dismiss isHTMLSelectElement
Modified: trunk/Source/WebKit/win/WebView.cpp (152762 => 152763)
--- trunk/Source/WebKit/win/WebView.cpp 2013-07-17 07:11:19 UTC (rev 152762)
+++ trunk/Source/WebKit/win/WebView.cpp 2013-07-17 07:12:11 UTC (rev 152763)
@@ -6243,7 +6243,7 @@
#if ENABLE(VIDEO)
if (!toElement(node)->isMediaElement())
return;
- HTMLMediaElement* videoElement = static_cast<HTMLMediaElement*>(node);
+ HTMLMediaElement* videoElement = toHTMLMediaElement(node);
if (m_fullScreenVideoController) {
if (m_fullScreenVideoController->mediaElement() == videoElement) {
