Title: [152807] trunk/Source/_javascript_Core
- Revision
- 152807
- Author
- [email protected]
- Date
- 2013-07-17 15:14:47 -0700 (Wed, 17 Jul 2013)
Log Message
JSStringCreateWithCFString should not convert the empty string into the NULL string
https://bugs.webkit.org/show_bug.cgi?id=118816
Reviewed by Sam Weinig.
* API/JSStringRef.cpp:
(JSStringCreateWithUTF8CString): Removed an extraneous comment, which
a previous version of the patch made incorrect.
* API/JSStringRefCF.cpp:
(JSStringCreateWithCFString): Don't convert the empty string into the
null string.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/API/JSStringRef.cpp (152806 => 152807)
--- trunk/Source/_javascript_Core/API/JSStringRef.cpp 2013-07-17 22:08:35 UTC (rev 152806)
+++ trunk/Source/_javascript_Core/API/JSStringRef.cpp 2013-07-17 22:14:47 UTC (rev 152807)
@@ -56,7 +56,6 @@
}
}
- // Null string.
return OpaqueJSString::create().leakRef();
}
Modified: trunk/Source/_javascript_Core/API/JSStringRefCF.cpp (152806 => 152807)
--- trunk/Source/_javascript_Core/API/JSStringRefCF.cpp 2013-07-17 22:08:35 UTC (rev 152806)
+++ trunk/Source/_javascript_Core/API/JSStringRefCF.cpp 2013-07-17 22:14:47 UTC (rev 152807)
@@ -53,7 +53,7 @@
return OpaqueJSString::create(reinterpret_cast<UChar*>(buffer.get()), length).leakRef();
}
- return OpaqueJSString::create(static_cast<const LChar*>(0), 0).leakRef();
+ return OpaqueJSString::create(reinterpret_cast<const LChar*>(""), 0).leakRef();
}
CFStringRef JSStringCopyCFString(CFAllocatorRef alloc, JSStringRef string)
Modified: trunk/Source/_javascript_Core/ChangeLog (152806 => 152807)
--- trunk/Source/_javascript_Core/ChangeLog 2013-07-17 22:08:35 UTC (rev 152806)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-07-17 22:14:47 UTC (rev 152807)
@@ -1,3 +1,18 @@
+2013-07-17 Geoffrey Garen <[email protected]>
+
+ JSStringCreateWithCFString should not convert the empty string into the NULL string
+ https://bugs.webkit.org/show_bug.cgi?id=118816
+
+ Reviewed by Sam Weinig.
+
+ * API/JSStringRef.cpp:
+ (JSStringCreateWithUTF8CString): Removed an extraneous comment, which
+ a previous version of the patch made incorrect.
+
+ * API/JSStringRefCF.cpp:
+ (JSStringCreateWithCFString): Don't convert the empty string into the
+ null string.
+
2013-07-17 Chris Curtis <[email protected]>
Naming convention on createInvalidParamError is incorrect.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
