Modified: trunk/Source/WebKit2/ChangeLog (152832 => 152833)
--- trunk/Source/WebKit2/ChangeLog 2013-07-18 07:27:16 UTC (rev 152832)
+++ trunk/Source/WebKit2/ChangeLog 2013-07-18 07:29:19 UTC (rev 152833)
@@ -1,5 +1,20 @@
2013-07-18 Dong-Gwan Kim <[email protected]>
+ [EFL][WK2] Replace mouseClick with more meaningful method in test_ewk2_file_chooser_request.cpp
+ https://bugs.webkit.org/show_bug.cgi?id=118792
+
+ Reviewed by Christophe Dumez.
+
+ Some mouseClick methods are used in test_ewk2_file_chooser_request.cpp.
+ But it is difficult to understand what they mean.
+ So i would like to replace those with more meaningful method for readability.
+
+ * UIProcess/API/efl/tests/test_ewk2_file_chooser_request.cpp:
+ (EWK2FileChooserRequestTest::clickFileInput):
+ (TEST_F):
+
+2013-07-18 Dong-Gwan Kim <[email protected]>
+
[EFL][WK2] Move all the static methods into EWK2TextCheckerTest in test_ewk2_text_checker.cpp
https://bugs.webkit.org/show_bug.cgi?id=118790
Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_file_chooser_request.cpp (152832 => 152833)
--- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_file_chooser_request.cpp 2013-07-18 07:27:16 UTC (rev 152832)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_file_chooser_request.cpp 2013-07-18 07:29:19 UTC (rev 152833)
@@ -61,6 +61,11 @@
eina_stringshare_del(static_cast<char*>(data));
}
}
+
+ void clickFileInput()
+ {
+ mouseClick(15, 15);
+ }
};
TEST_F(EWK2FileChooserRequestTest, ewk_file_chooser_request_files_choose)
@@ -69,8 +74,7 @@
evas_object_smart_callback_add(webView(), "file,chooser,request", onFileChooserRequest, &request);
ASSERT_TRUE(loadUrlSync(environment->urlForResource("file_chooser.html").data()));
- // Click on the file input.
- mouseClick(15, 15);
+ clickFileInput();
// Wait for the file chooser request.
while (!request)
@@ -108,8 +112,7 @@
evas_object_smart_callback_add(webView(), "file,chooser,request", onFileChooserRequest, &request);
ASSERT_TRUE(loadUrlSync(environment->urlForResource("file_chooser.html").data()));
- // Click on the file input.
- mouseClick(15, 15);
+ clickFileInput();
// Wait for the file chooser request.
while (!request)
@@ -134,8 +137,7 @@
evas_object_smart_callback_add(webView(), "file,chooser,request", onFileChooserRequest, &request);
ASSERT_TRUE(loadUrlSync(environment->urlForResource("file_chooser.html").data()));
- // Click on the file input.
- mouseClick(15, 15);
+ clickFileInput();
// Wait for the file chooser request.
while (!request)
@@ -155,9 +157,9 @@
// Default behavior is to cancel if the client does not act on the request.
request = 0;
evas_object_smart_callback_add(webView(), "file,chooser,request", onFileChooserRequest, &request);
- // Click on the file input.
- mouseClick(15, 15);
+ clickFileInput();
+
// Wait for the file chooser request.
while (!request)
ecore_main_loop_iterate();
