Title: [152836] trunk
- Revision
- 152836
- Author
- [email protected]
- Date
- 2013-07-18 01:04:30 -0700 (Thu, 18 Jul 2013)
Log Message
ASSERTION FAILED: !listItems().size() || m_activeSelectionAnchorIndex >= 0 in WebCore::HTMLSelectElement::updateListBoxSelection
https://bugs.webkit.org/show_bug.cgi?id=118591
Patch by Santosh Mahto <[email protected]> on 2013-07-18
Reviewed by Kent Tamura.
Source/WebCore:
Test: fast/forms/select/selectall-command-crash.html
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::selectAll):
We should return this function if activeSelectionAnchorIndex is not valid index
LayoutTests:
* fast/forms/select/selectall-command-crash-expected.txt: Added.
* fast/forms/select/selectall-command-crash.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (152835 => 152836)
--- trunk/LayoutTests/ChangeLog 2013-07-18 08:01:22 UTC (rev 152835)
+++ trunk/LayoutTests/ChangeLog 2013-07-18 08:04:30 UTC (rev 152836)
@@ -1,3 +1,13 @@
+2013-07-18 Santosh Mahto <[email protected]>
+
+ ASSERTION FAILED: !listItems().size() || m_activeSelectionAnchorIndex >= 0 in WebCore::HTMLSelectElement::updateListBoxSelection
+ https://bugs.webkit.org/show_bug.cgi?id=118591
+
+ Reviewed by Kent Tamura.
+
+ * fast/forms/select/selectall-command-crash-expected.txt: Added.
+ * fast/forms/select/selectall-command-crash.html: Added.
+
2013-07-18 Ryuan Choi <[email protected]>
[EFL] Refactor spin.edc not to use offset
Added: trunk/LayoutTests/fast/forms/select/selectall-command-crash-expected.txt (0 => 152836)
--- trunk/LayoutTests/fast/forms/select/selectall-command-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/forms/select/selectall-command-crash-expected.txt 2013-07-18 08:04:30 UTC (rev 152836)
@@ -0,0 +1,3 @@
+This test is for crash when executing SelectAll command on focused select element containing only disabled element
+
+
Added: trunk/LayoutTests/fast/forms/select/selectall-command-crash.html (0 => 152836)
--- trunk/LayoutTests/fast/forms/select/selectall-command-crash.html (rev 0)
+++ trunk/LayoutTests/fast/forms/select/selectall-command-crash.html 2013-07-18 08:04:30 UTC (rev 152836)
@@ -0,0 +1,15 @@
+<!DOCTYPE html>
+<html>
+<head>
+<p>This test is for crash when executing SelectAll command on focused select element containing only disabled element </p>
+ <script>
+ if (window.testRunner)
+ window.testRunner.dumpAsText();
+ </script>
+</head>
+<body _onload_="document.execCommand('SelectAll')">
+ <select multiple="1" autofocus="autofocus">
+ <option disabled="DISABLED"></option>
+ </select>
+</body>
+<html>
Modified: trunk/Source/WebCore/ChangeLog (152835 => 152836)
--- trunk/Source/WebCore/ChangeLog 2013-07-18 08:01:22 UTC (rev 152835)
+++ trunk/Source/WebCore/ChangeLog 2013-07-18 08:04:30 UTC (rev 152836)
@@ -1,3 +1,16 @@
+2013-07-18 Santosh Mahto <[email protected]>
+
+ ASSERTION FAILED: !listItems().size() || m_activeSelectionAnchorIndex >= 0 in WebCore::HTMLSelectElement::updateListBoxSelection
+ https://bugs.webkit.org/show_bug.cgi?id=118591
+
+ Reviewed by Kent Tamura.
+
+ Test: fast/forms/select/selectall-command-crash.html
+
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::selectAll):
+ We should return this function if activeSelectionAnchorIndex is not valid index
+
2013-07-18 Ryuan Choi <[email protected]>
[EFL] Refactor spin.edc not to use offset
Modified: trunk/Source/WebCore/html/HTMLSelectElement.cpp (152835 => 152836)
--- trunk/Source/WebCore/html/HTMLSelectElement.cpp 2013-07-18 08:01:22 UTC (rev 152835)
+++ trunk/Source/WebCore/html/HTMLSelectElement.cpp 2013-07-18 08:04:30 UTC (rev 152836)
@@ -567,6 +567,8 @@
m_activeSelectionState = true;
setActiveSelectionAnchorIndex(nextSelectableListIndex(-1));
setActiveSelectionEndIndex(previousSelectableListIndex(-1));
+ if (m_activeSelectionAnchorIndex < 0)
+ return;
updateListBoxSelection(false);
listBoxOnChange();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
