Title: [152847] trunk/LayoutTests
Revision
152847
Author
[email protected]
Date
2013-07-18 08:44:12 -0700 (Thu, 18 Jul 2013)

Log Message

fullscreen/full-screen-iframe-with-max-width-height.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=118820

Patch by Zalan Bujtas <[email protected]> on 2013-07-18
Reviewed by Andreas Kling.

Don't start the test until after the iframe has finished loading.

* fullscreen/full-screen-iframe-with-max-width-height-expected.txt:
* fullscreen/full-screen-iframe-with-max-width-height.html:
* platform/mac/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (152846 => 152847)


--- trunk/LayoutTests/ChangeLog	2013-07-18 15:39:25 UTC (rev 152846)
+++ trunk/LayoutTests/ChangeLog	2013-07-18 15:44:12 UTC (rev 152847)
@@ -1,3 +1,16 @@
+2013-07-18  Zalan Bujtas  <[email protected]>
+
+        fullscreen/full-screen-iframe-with-max-width-height.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=118820
+
+        Reviewed by Andreas Kling.
+
+        Don't start the test until after the iframe has finished loading.
+
+        * fullscreen/full-screen-iframe-with-max-width-height-expected.txt:
+        * fullscreen/full-screen-iframe-with-max-width-height.html:
+        * platform/mac/TestExpectations:
+
 2013-07-18  Praveen R Jadhav  <[email protected]>
 
         Only the first call to 'stop' method of AudioBufferSourceNode must be entertained.

Modified: trunk/LayoutTests/fullscreen/full-screen-iframe-with-max-width-height-expected.txt (152846 => 152847)


--- trunk/LayoutTests/fullscreen/full-screen-iframe-with-max-width-height-expected.txt	2013-07-18 15:39:25 UTC (rev 152846)
+++ trunk/LayoutTests/fullscreen/full-screen-iframe-with-max-width-height-expected.txt	2013-07-18 15:44:12 UTC (rev 152847)
@@ -1,4 +1,4 @@
 
-EVENT(webkitfullscreenchange) TEST(frame.getBoundingClientRect().right == document.body.getBoundingClientRect().right && frame.getBoundingClientRect().bottom == document.body.getBoundingClientRect().bottom) OK
+EVENT(webkitfullscreenchange) TEST(testFrame.getBoundingClientRect().right == document.body.getBoundingClientRect().right && testFrame.getBoundingClientRect().bottom == document.body.getBoundingClientRect().bottom) OK
 END OF TEST
 

Modified: trunk/LayoutTests/fullscreen/full-screen-iframe-with-max-width-height.html (152846 => 152847)


--- trunk/LayoutTests/fullscreen/full-screen-iframe-with-max-width-height.html	2013-07-18 15:39:25 UTC (rev 152846)
+++ trunk/LayoutTests/fullscreen/full-screen-iframe-with-max-width-height.html	2013-07-18 15:44:12 UTC (rev 152847)
@@ -1,17 +1,25 @@
-<body style="margin: 0px;">
-    <iframe id='fullscreenFrame' src='' style='max-width: 10px; max-height: 10px;' frameborder='0' webkitallowfullscreen></iframe>
-    <script src=''></script>
-    <script>
-        var frame = document.getElementById('fullscreenFrame');
-        var testDiv = frame.contentWindow.document.getElementById('testDiv');
+<html>
+<head>
+  <script>
+    var testFrame;
+    var testDiv;
+
+    function runTest() {
+        testFrame = document.getElementById('fullscreenFrame');
+        testDiv = testFrame.contentWindow.document.getElementById('testDiv');
         // Bail out early if the full screen API is not enabled or is missing:
         if (Element.prototype.webkitRequestFullScreen == undefined) {
             logResult(false, "Element.prototype.webkitRequestFullScreen == undefined");
             endTest();
         } else {
             // Test if the iframe expands full screen when max-width/max-height are set.
-            waitForEventTestAndEnd(document, 'webkitfullscreenchange', "frame.getBoundingClientRect().right == document.body.getBoundingClientRect().right && frame.getBoundingClientRect().bottom == document.body.getBoundingClientRect().bottom");
+            waitForEventTestAndEnd(document, 'webkitfullscreenchange', "testFrame.getBoundingClientRect().right == document.body.getBoundingClientRect().right && testFrame.getBoundingClientRect().bottom == document.body.getBoundingClientRect().bottom");
             runWithKeyDown(function(){ testDiv.webkitRequestFullScreen(); });
         }
-    </script>
+    }
+  </script>
+  <script src=''></script>
+</head>
+<body style="margin: 0px;">
+    <iframe _onload_='runTest();' id='fullscreenFrame' src='' style='max-width: 10px; max-height: 10px;' frameborder='0' webkitallowfullscreen></iframe>
 </body>

Modified: trunk/LayoutTests/platform/mac/TestExpectations (152846 => 152847)


--- trunk/LayoutTests/platform/mac/TestExpectations	2013-07-18 15:39:25 UTC (rev 152846)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2013-07-18 15:44:12 UTC (rev 152847)
@@ -1302,6 +1302,3 @@
 webkit.org/b/118269 compositing/geometry/fixed-position-flipped-writing-mode.html
 
 webkit.org/b/118479 fast/repaint/fixed-right-in-page-scale.html [ Pass Crash ]
-
-webkit.org/b/118820 fullscreen/full-screen-iframe-with-max-width-height.html [ Pass Failure ]
-
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to