Title: [152882] trunk/Source/_javascript_Core
Revision
152882
Author
[email protected]
Date
2013-07-18 20:30:18 -0700 (Thu, 18 Jul 2013)

Log Message

CodeBlock DFG entry list isn't getting shrunk-to-fit after linking.
<http://webkit.org/b/118875>
<rdar://problem/14488577>

Reviewed by Geoffrey Garen.

Move the CodeBlock::shrinkToFit() call out of JITCompiler::link() and to the call sites
so SpeculativeJIT::linkOSREntries() can fill in CodeBlock::m_dfgData->osrEntry first.

886 kB progression on <http://twitter.com/awesomekling>

* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (152881 => 152882)


--- trunk/Source/_javascript_Core/ChangeLog	2013-07-19 03:24:43 UTC (rev 152881)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-07-19 03:30:18 UTC (rev 152882)
@@ -1,3 +1,21 @@
+2013-07-18  Andreas Kling  <[email protected]>
+
+        CodeBlock DFG entry list isn't getting shrunk-to-fit after linking.
+        <http://webkit.org/b/118875>
+        <rdar://problem/14488577>
+
+        Reviewed by Geoffrey Garen.
+
+        Move the CodeBlock::shrinkToFit() call out of JITCompiler::link() and to the call sites
+        so SpeculativeJIT::linkOSREntries() can fill in CodeBlock::m_dfgData->osrEntry first.
+
+        886 kB progression on <http://twitter.com/awesomekling>
+
+        * dfg/DFGJITCompiler.cpp:
+        (JSC::DFG::JITCompiler::link):
+        (JSC::DFG::JITCompiler::compile):
+        (JSC::DFG::JITCompiler::compileFunction):
+
 2013-07-18  Chris Curtis  <[email protected]>
 
         Fixed ASSERTION FAILED: callFrame == vm->topCallFrame in JSC::Interpreter::addStackTraceIfNecessary

Modified: trunk/Source/_javascript_Core/dfg/DFGJITCompiler.cpp (152881 => 152882)


--- trunk/Source/_javascript_Core/dfg/DFGJITCompiler.cpp	2013-07-19 03:24:43 UTC (rev 152881)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCompiler.cpp	2013-07-19 03:30:18 UTC (rev 152882)
@@ -236,8 +236,6 @@
         ASSERT(!m_exitSiteLabels.size());
     
     codeBlock()->saveCompilation(m_graph.m_compilation);
-    
-    codeBlock()->shrinkToFit(CodeBlock::LateShrink);
 }
 
 bool JITCompiler::compile(JITCode& entry)
@@ -265,6 +263,7 @@
         return false;
     link(linkBuffer);
     speculative.linkOSREntries(linkBuffer);
+    codeBlock()->shrinkToFit(CodeBlock::LateShrink);
 
     if (shouldShowDisassembly())
         m_disassembler->dump(linkBuffer);
@@ -354,6 +353,7 @@
         return false;
     link(linkBuffer);
     speculative.linkOSREntries(linkBuffer);
+    codeBlock()->shrinkToFit(CodeBlock::LateShrink);
     
     // FIXME: switch the stack check & arity check over to DFGOpertaion style calls, not JIT stubs.
     linkBuffer.link(callStackCheck, cti_stack_check);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to